[Finished] MP1-4777 Additional info for video and audio (1 Viewer)

[Sebastiii]

Hi
Yep i have link the branch where it's used :
https://github.com/MediaPortal/Medi...diaportal/Core/Player/VideoPlayerVMR7.cs#L923
https://github.com/MediaPortal/MediaPortal-1/tree/MP1-4745-Slow_down_playback

So maybe some plugins can herite too.
I have try it on my build and on some .TS file, i lead to nullreference on adaprefreshrate, i'm pretty sure it's related to MediaInfo

Here, i will debug to know exactly what happen : public static void AdaptRefreshRate(MediaInfoWrapper info, string strFile, MediaType type)

 

[Sebastiii]

Maybe @regeszter can tell why RealSpeed need to be into RTSPPlayer.cs too

 

[regeszter]

Maybe @regeszter can tell why RealSpeed need to be into RTSPPlayer.cs too

RealSpeed is the replacement of the Speed. The Speed supports only the integer values.

 

[Sebastiii]

Yep I know but needed to put everywhere then. So maybe we need another way to calculate fps ?

 

[Sebastiii]

Sorry, CurrentVideo property, of course. Not CurrentVideoStream

If we need to use CurrentVideo, then i'm not sure to understand why 'BestVideoStream' is used here :

if ((isVideo || isDVD) && (!isRTSP && !isTV))
      {
        if (info != null)
        {
          fps = info.BestVideoStream.FrameRate;
        }
        else
        {
          StackTrace st = new StackTrace(true);
          StackFrame sf = st.GetFrame(0);

          Log.Error("RefreshRateChanger.AdaptRefreshRate: g_Player.MediaInfo was null. file: {0} st: {1}", strFile,
                    sf.GetMethod().Name);
          return;
        }
      }

 

[Sebastiii]

I'm trying something by adding FrameRate value directly into MediaInfoWrapper.cs (like VideoDuration).
Like this i can get :

if (info != null)
        {
          fps = info.FrameRate;
        }

 

[Sebastiii]

@yartat : What do you think :
https://github.com/Sebastiii/MediaPortal-1/commit/f741bea4ce8ee9386d3078347fe57992f0fa634a

 

[yartat]

@Sebastiii I will prefer this commit. I added DirectShow graph analyze for media streams for BaseTSReaderPlayer and StreamBufferPlayer9. But problem still here, because MediaInfo does not support .wtv. I have an idea to create media info by the fly if mediainfo not loaded
See also my new commits on new pull request[DOUBLEPOST=1457187671][/DOUBLEPOST]

If we need to use CurrentVideo, then i'm not sure to understand why 'BestVideoStream' is used here :

The RefreshRateChanger.AdaptRefreshRate are called before _player initialization. So, we haven't at this moment information about current video stream. I didn't understand why we need to set refresh rate before initialize player (player can fail) and I upheld it.

 

[Sebastiii]

Thanks i just updated the branch :
https://github.com/MediaPortal/MediaPortal-1/compare/7e63f5e48104...2378ffbbbd1b

About refresh rate it depend (i think) i know that BD can get the value directly and parse it and for the other, it works so i don't understand why if there is an issue.

But i'm little lost in fact lol.

Your recent commit will not fix the issue with slow playback branch right ? (https://github.com/MediaPortal/MediaPortal-1/tree/MP1-4745-Slow_down_playback)

 

[Sebastiii]

@yartat

I have a better idea lol, can you try to fix this branch : https://git.io/v2Nmf and https://github.com/MediaPortal/MediaPortal-1/tree/MP1-4745-Slow_down_playback_TEMP_to_resolve

It's slow branch + MP1-4777, you will see now what to fix or how to handle and i will be really happy to see how you will handle it

Thanks.