[fixed] [MP2-611] Having problems with subtitles (ATSC) (1 Viewer)

aspik

Development Group
  • Team MediaPortal
  • April 14, 2008
    1,383
    553
    @Gcarr
    please try the attached dll. Make a backup of the current one and replace it with the attached one. Location is c:\Program Files (x86)\Team MediaPortal\MP2-Client\Plugins\VideoPlayers\

    I'm not happy about the solution, but for now it should fix your problem.
     

    Attachments

    Gcarr

    MP Donator
  • Premium Supporter
  • August 17, 2014
    95
    21
    United States of America United States of America
    Country flag
    @aspik I'm testing it now. Initially my screen froze a few minutes after I started. I rebooted and so far it's been 30 minutes and that problem hasn't come back. The only thing I notice is that I can't turn off ATSC subtitles from the Player Configuration Menu. I have to go back into settings to turn them off. Clicking on the Subtitle option in Player Configuration brings up an empty box and clicking does nothing. This problem was in the original dll also. I attached a screenshot of the menu so you can see what I am talking about. This is not a big problem for me, I appreciate your working on this so quick!
     

    Attachments

    aspik

    Development Group
  • Team MediaPortal
  • April 14, 2008
    1,383
    553
    The only thing I notice is that I can't turn off ATSC subtitles from the Player Configuration Menu.
    Yes, I know. The problem is, we are not able to know if the played TS file contains ATSC subtitles. This information is needed as we add then the CC parser to the direct show graph. Our current implementation is mainly based on the setting "Enable ATSC subtitles".

    @Owlsroost
    checking the provided sample with mediainfo, shows that it has four "text entries". Do you think that this information can be used to know about the existence of ATSC subtitles?
    VLC shows all four entries as an subtitle, but only when selecting the first one subtitles are displayed.

    Even when we find a way to determine the existence of ATSC subtitles, I don't know how we should implement the "No subtitles" option. The CC parser is added while to video is about to start to play, we can't just remove it from the graph. So in best case, you'll have to stop the video and play it again.
     

    mm1352000

    Development Group
  • Team MediaPortal
  • September 1, 2008
    21,571
    8,218
    New Zealand New Zealand
    Country flag
    The problem is, we are not able to know if the played TS file contains ATSC subtitles.
    The PMT video stream includes a caption service descriptor. For information about this descriptor please refer to ATSC A/65 section 6.9.2:
    https://www.atsc.org/wp-content/upl...tocol-for-Terrestrial-Broadcast-and-Cable.pdf

    In short: that descriptor should enable TsReader to determine how many closed captions streams/services there are, what language the caption streams/services are, and whether the caption streams/services are digital (EIA/CEA-708) or analog (EIA/CEA-608).

    It might be better (more accurate) if TsReader were able to check the EIT (EPG data), because some channels only have captions for specific events/shows. According to the linked standard, the broadcaster may or may not remove the descriptor from the PMT... but they must include the same descriptor for each event/program/show that has captions, and not include it for events/programs/shows that don't have captions. On the other hand, EIT/EPG data for ATSC is notoriously bad (inaccurate)... and TsReader doesn't have access to it.
     

    aspik

    Development Group
  • Team MediaPortal
  • April 14, 2008
    1,383
    553
    @morpheus_xx
    The provided .dll has the "old" check against the ATSC subs option. I realized that the method AddEvr() (where _closedCaptionsFilterAdded was evaluated in order to increment the stream count) is executed before AddSubtitleFilter (where _closedCaptionsFilterAdded was set) from TsVideoPlayer. So, even if we could know if the played TS stream has ATSC subs, we would know it too late to do something with this information.

    I pushed this fix to the teletext branch. If you do not have a better idea how to solve this nicer, I'll merge this to wip 2.2.2 and we have to accept that the option ATSC subs should be enabled only by users who can receive ATSC subs.
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    S [fixed] [MP2-611] Teletext subtitles language selection 2.2 Archive 20
    H MP2 database won't keep in synch with recordings General 3
    H [solved] MP2 Wiedergabe von Aufnahmen und Live TV geht nicht Allgemeines Support- und Diskussionsforum 6
    ge2301 [WiP] MP2Web - A platform independent web client for MP2 MediaPortal 2 58
    F Problems with new install of MP2 Newcomers Forum 3
    catalpa Bug MP2-837 Allgemeines Support- und Diskussionsforum 2
    P MP2: US user, OTA - can NOT get SchedulesDirect plugin to work on MP1 or MP2 --> how do I get OTA schedule? General 5
    bigboss97 Does anyone has a SoundGraph imon remote file for MP2 to share? General 0
    ge2301 Android based client for MP2 MediaPortal 2 3
    R MP2 GUI Issues General 7
    P [solved] MP2 new install, 2 x hdhomerun tuners, client on same PC unable to view TV & recordings Newcomers Forum 8
    Lichloathe MP2 importing keyart instead of poster General 0
    Lichloathe Trakt for MP2 question General 7
    C Streaming/transcoding MP2 vs MP1? General 1
    P MP 2 - Request to add an additional TV series Filename protocal Feature Requests 0
    C Streaming to clients over Wifi. MP1 or MP2? Newcomers Forum 0
    CyberSimian MP2 synchronising of stoptime MediaPortal 1 Talk 5
    M Initial Setup MP2 (On Wndows 10) General 2
    R [solved] MP2 Client ist extrem langsam Allgemeines Support- und Diskussionsforum 5
    D [solved] EPG Buddy for MP2 - Does it work? General 5
    T Amazon und Netflix in MP2 - Wie? Allgemeines Support- und Diskussionsforum 6
    J [solved] How to in MP2 General 19
    M [fixed] [MP2-831] 12h time format shown in TV Guide with Swedish language settings Submit: Bug Reports 27
    Volker MP2 Rewind / zurückspulen bei Live TV funktioniert nicht Allgemeines Support- und Diskussionsforum 3
    B [solved] MP2.2.3 TV Guide not scrolling with mouse wheel General 2
    Similar threads

























    Top Bottom