Music Player Rework (3 Viewers)

Status
Not open for further replies.
azzuro

azzuro

Test Group
  • Team MediaPortal
    • May 10, 2007
    9,984
    5,663
    France - IDF
    Home Country
    France France
    Hi @hwahrmann,

    EDIT : @Developers
    Workstation restarted, don't have slow and freeze anymore....
    But i have refresh rate changer is working when play m4a file (without video inside)
    TAK detect :
    Code: 
    2013-03-23 11:22:53.312083 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: DLL Version	  : MediaInfoLib - v0.7.61
2013-03-23 11:22:53.313083 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: Inspecting media : F:\MPmov\big TEST audio\Audio Conteneur\TAK\Camillo\Camillo TAK.tak
2013-03-23 11:22:53.315083 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: Parse speed	  : 0.3
2013-03-23 11:22:53.316083 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: FrameRate		: 0
2013-03-23 11:22:53.318084 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: Width			: 0
2013-03-23 11:22:53.319084 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: Height		  : 0
2013-03-23 11:22:53.320084 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: AspectRatio	  : widescreen
2013-03-23 11:22:53.322084 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: VideoCodec	  :  [ ".png" ]
2013-03-23 11:22:53.324084 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: Scan type		:
2013-03-23 11:22:53.325084 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: IsInterlaced	: False
2013-03-23 11:22:53.327084 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: VideoResolution  : SD
2013-03-23 11:22:53.329084 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: VideoDuration	: 0
2013-03-23 11:22:53.330084 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: AudioRate		: 44100
2013-03-23 11:22:53.332084 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: AudioChannels	: 2 [ "stereo.png" ]
2013-03-23 11:22:53.334084 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: AudioCodec	  : TAK [ "tak.png" ]
2013-03-23 11:22:53.335085 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: HasAudio		: True
2013-03-23 11:22:53.336085 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: HasVideo		: False
2013-03-23 11:22:53.338085 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: HasSubtitles	: False
2013-03-23 11:22:53.339085 [Info.][MPMain(1)]: MediaInfoWrapper.MediaInfoWrapper: NumSubtitles	: 0
2013-03-23 11:22:53.374087 [Info.][MPMain(1)]: RefreshRateChanger.AdaptRefreshRate: unable to guess framerate on file F:\MPmov\big TEST audio\Audio Conteneur\TAK\Camillo\Camillo TAK.tak
2013-03-23 11:22:53.381087 [Info.][MPMain(1)]: RefreshRateChanger.SetRefreshRateBasedOnFPS: could not find a matching refreshrate based on 0 fps (check config)
2013-03-23 11:22:53.383087 [Info.][MPMain(1)]: g_Player.OnChanged()
    When Press [STOP] button
    Code: 
    2013-03-23 11:23:27.644047 [Info.][MPMain(1)]: g_Player.OnStopped()
2013-03-23 11:23:27.646047 [Info.][MPMain(1)]: RadioRecorded:OnPlayRecordingBackStopped Music F:\MPmov\big TEST audio\Audio Conteneur\M4A\Hotel_California_by_The_Eagles_(51_secs_AAC_HE V2 (SBR+PS)).m4a
2013-03-23 11:23:27.648047 [Info.][MPMain(1)]: TvRecorded:OnPlayRecordingBackStopped Music F:\MPmov\big TEST audio\Audio Conteneur\M4A\Hotel_California_by_The_Eagles_(51_secs_AAC_HE V2 (SBR+PS)).m4a
2013-03-23 11:23:27.649047 [Debug][MPMain(1)]: g_Player.doStop() - stop
2013-03-23 11:23:27.655048 [Debug][MPMain(1)]: BASS: Stop of stream F:\MPmov\big TEST audio\Audio Conteneur\M4A\Hotel_California_by_The_Eagles_(51_secs_AAC_HE V2 (SBR+PS)).m4a.
2013-03-23 11:23:27.656048 [Debug][MPMain(1)]: BASS: Performing Softstop of F:\MPmov\big TEST audio\Audio Conteneur\M4A\Hotel_California_by_The_Eagles_(51_secs_AAC_HE V2 (SBR+PS)).m4a
2013-03-23 11:23:28.978123 [Debug][MPMain(1)]: BASS: Disposing Music Stream F:\MPmov\big TEST audio\Audio Conteneur\M4A\Hotel_California_by_The_Eagles_(51_secs_AAC_HE V2 (SBR+PS)).m4a
2013-03-23 11:23:28.980123 [Debug][MPMain(1)]: BASS: Disposing Mixer Stream
2013-03-23 11:23:29.011125 [Info.][MPMain(1)]: RefreshRateChanger.SetRefreshRateBasedOnFPS: current refreshrate is 60hz - changing it to 50hz
2013-03-23 11:23:29.013125 [Info.][MPMain(1)]: RefreshRateChanger.SetRefreshRateBasedOnFPS: using internal win32 method for changing refreshrate. current is 60hz, desired is 50
2013-03-23 11:23:29.038127 [Debug][MPMain(1)]: W7RefreshRateHelper.SetDisplayConfig(...): SDC_VALIDATE of 50000/1000 succesful
2013-03-23 11:23:30.266197 [Debug][MPMain(1)]: W7RefreshRateHelper.GetRefreshRate: QueryDisplayConfig returned 50/1
2013-03-23 11:23:30.269197 [Info.][MPMain(1)]: CycleRefreshRate: successfully changed refresh rate to 50Hz (50Hz requested)
2013-03-23 11:23:30.272197 [Debug][MPMain(1)]: CycleRefresh: DWM Detected, performing shenanigans

    Original Post
    i test your Branch, i don't undertand why, when start music file, Gui freeze 1-2 sec, switching next-previous files is slow also "file reading" information (Gui freeze when Music change). but MP ahve 150Mb of memory
    (No database used)

    Improvement : EDIT : [Already Exist]
    Add support of CUE + Audio file, for single file with external timestamp :
    CUE + WAV / CUE + APE / ....

    XML: 
    REM DISCID 3B122B17
PERFORMER "multis"
TITLE "dancefloor fg ete summer 2009"
CATALOG 0600753190197
REM DATE 2009
REM GENRE "Dance"
REM COMMENT "YEAR: 2009"
FILE "multis - dancefloor fg ete summer 2009.tak" WAVE
  TRACK 01 AUDIO
	PERFORMER "multis"
	TITLE "lady gaga-  Lovegame (Dave Aude Radio Edit)"
	ISRC USUM70966396
	INDEX 01 00:00:00
  TRACK 02 AUDIO
	PERFORMER "multis"
	TITLE "The Black Eyed Peas - Boom Boom Pow (David Guetta’s Electro Hop Remix)"
	ISRC USUM70964619
	INDEX 01 03:31:00
     
    Last edited:
    elliottmc

    elliottmc

    Retired Team Member
  • Premium Supporter
    • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    azzuro said:
    Hi @hwahrmann,
    i test your Branch, i don't undertand why, when start music file, Gui freeze 1-2 sec, switching next-previous files is slow also "file reading" information (Gui freeze when Music change).
    (No database used)

    Improvement :
    Add support of CUE + Audio file, for single file with external timestamp :
    CUE + WAV / CUE + APE / ....

    XML: 
    REM DISCID 3B122B17
PERFORMER "multis"
TITLE "dancefloor fg ete summer 2009"
CATALOG 0600753190197
REM DATE 2009
REM GENRE "Dance"
REM COMMENT "YEAR: 2009"
FILE "multis - dancefloor fg ete summer 2009.tak" WAVE
  TRACK 01 AUDIO
	PERFORMER "multis"
	TITLE "lady gaga-  Lovegame (Dave Aude Radio Edit)"
	ISRC USUM70966396
	INDEX 01 00:00:00
  TRACK 02 AUDIO
	PERFORMER "multis"
	TITLE "The Black Eyed Peas - Boom Boom Pow (David Guetta’s Electro Hop Remix)"
	ISRC USUM70964619
	INDEX 01 03:31:00
    Click to expand...


    ALWAYS POST LOGS IF YOU ARE REPORTING A PROBLEM!
     
    T

    tourettes

    Retired Team Member
  • Premium Supporter
    • January 7, 2005
    17,301
    4,800
    hwahrmann said:
    horned_reaper said:
    Why not setting the maximum quality of the sound system? Other applications don't have any problem with this setting.
    Click to expand...

    What would you gain by resampling a 44khz file to 96khz?
    Just get rid of the mixer and use WASAPI exclusive mode
    Click to expand...

    I think it is a perfectly valid use case since not all audio HW work properly in WASAPI exclusive mode (mainly because their drivers are bad). Some professional high quality audio HW falls into this case. We wont be able to expect the users to set the OS audio output to 44.1Khz so that MediaPortal will work, even MediaPortal would in some cases wanted to be able to use 44.1Khz resampled to highler sampling rates so that the higher quality audio doesn't have to be downsampled on HW / drivers that wont support WASAPI exclusive mode.

    Solution to the issue is to use mixer + resampler + bit depth conversion from the BASS even for the shared WASAPI mode use case.
     
    hwahrmann

    hwahrmann

    Development Group
  • Team MediaPortal
    • September 15, 2004
    4,633
    2,457
    Vienna, Austria
    Home Country
    Austria Austria
    tourettes said:
    hwahrmann said:
    horned_reaper said:
    Why not setting the maximum quality of the sound system? Other applications don't have any problem with this setting.
    Click to expand...

    What would you gain by resampling a 44khz file to 96khz?
    Just get rid of the mixer and use WASAPI exclusive mode
    Click to expand...

    I think it is a perfectly valid use case since not all audio HW work properly in WASAPI exclusive mode (mainly because their drivers are bad). Some professional high quality audio HW falls into this case. We wont be able to expect the users to set the OS audio output to 44.1Khz so that MediaPortal will work, even MediaPortal would in some cases wanted to be able to use 44.1Khz resampled to highler sampling rates so that the higher quality audio doesn't have to be downsampled on HW / drivers that wont support WASAPI exclusive mode.

    Solution to the issue is to use mixer + resampler + bit depth conversion from the BASS even for the shared WASAPI mode use case.
    Click to expand...

    But it's not a general issue.
    I can set my Audio device to any sample and it plays ok in Share mode
     
    Sebastiii

    Sebastiii

    Development Group
  • Team MediaPortal
    • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    azzuro said:
    Hi @hwahrmann,

    EDIT : @Developers
    Workstation restarted, don't have slow and freeze anymore....
    But i have refresh rate changer is working when play m4a file (without video inside)
    TAK detect :
    Click to expand...

    Hi, could you upload a sample on ftp ?
    Thanks :)
     
    T

    tourettes

    Retired Team Member
  • Premium Supporter
    • January 7, 2005
    17,301
    4,800
    Following use case is not working:

    1) set 96Khz 24 bit for OS mixer
    2) set shared WASAPI mode for MP
    3) play 44.1Khz 16 bit audio

    As the result couple of Disney cortoon squirels will invade the speakers.

    2013-03-28 22:59:09.100598 [Info.][MPMain(1)]: BASS: Initializing BASS audio engine...
    2013-03-28 22:59:09.100598 [Debug][MPMain(1)]: BASS: BASS audio engine was previously freed. Re-Init
    2013-03-28 22:59:09.102598 [Info.][MPMain(1)]: BASS: Using WASAPI device: TX-SR508-3 (NVIDIA High Definition Audio)
    2013-03-28 22:59:09.127601 [Info.][MPMain(1)]: BASS: Device Information
    2013-03-28 22:59:09.128602 [Info.][MPMain(1)]: BASS: ---------------------------------------------
    2013-03-28 22:59:09.128602 [Info.][MPMain(1)]: BASS: Name: TX-SR508-3 (NVIDIA High Definition Audio)
    2013-03-28 22:59:09.128602 [Info.][MPMain(1)]: BASS: Id: {0.0.0.00000000}.{f4a5707c-9d06-41a0-8900-8f561be4aad9}
    2013-03-28 22:59:09.129603 [Info.][MPMain(1)]: BASS: Type: BASS_WASAPI_TYPE_HDMI
    2013-03-28 22:59:09.129603 [Info.][MPMain(1)]: BASS: Shared Mode Channels: 2
    2013-03-28 22:59:09.129603 [Info.][MPMain(1)]: BASS: Shared Mode Samplerate: 96000
    2013-03-28 22:59:09.130602 [Info.][MPMain(1)]: BASS: This device supports following formats in WASAPI Shared mode:
    2013-03-28 22:59:09.131602 [Info.][MPMain(1)]: BASS: Rate Ch Maximum Supported
    2013-03-28 22:59:09.161606 [Info.][MPMain(1)]: BASS: 96000 2 BASS_WASAPI_FORMAT_FLOAT
    2013-03-28 22:59:09.170612 [Info.][MPMain(1)]: BASS: ---------------------------------------------
    2013-03-28 22:59:09.171607 [Info.][MPMain(1)]: BASS: Initialization done.
    2013-03-28 22:59:09.171607 [Debug][MPMain(1)]: PlayerFactory: Successfully created player instance for file - \\SLAVE\Media files\MP3\40 Below Summer\2001 - Invitation to the Dance\40 Below Summer - Invitation to the Dance - 01 - We the People.mp3
    2013-03-28 22:59:09.179607 [Info.][MPMain(1)]: BASS: ---------------------------------------------
    2013-03-28 22:59:09.180608 [Info.][MPMain(1)]: BASS: Creating BASS audio stream
    2013-03-28 22:59:09.243616 [Info.][MPMain(1)]: BASS: Stream Information
    2013-03-28 22:59:09.243616 [Info.][MPMain(1)]: BASS: ---------------------------------------------
    2013-03-28 22:59:09.243616 [Info.][MPMain(1)]: BASS: File: \\SLAVE\Media files\MP3\40 Below Summer\2001 - Invitation to the Dance\40 Below Summer - Invitation to the Dance - 01 - We the People.mp3
    2013-03-28 22:59:09.243616 [Info.][MPMain(1)]: BASS: Type of Stream: BASS_CTYPE_STREAM_MP3
    2013-03-28 22:59:09.244617 [Info.][MPMain(1)]: BASS: Number of Channels: 2
    2013-03-28 22:59:09.244617 [Info.][MPMain(1)]: BASS: Stream Samplerate: 44100
    2013-03-28 22:59:09.244617 [Info.][MPMain(1)]: BASS: Stream Flags: BASS_MUSIC_FLOAT, BASS_STREAM_DECODE, BASS_UNICODE
    2013-03-28 22:59:09.244617 [Info.][MPMain(1)]: BASS: ---------------------------------------------
    2013-03-28 22:59:09.245617 [Debug][MPMain(1)]: BASS: Registering stream playback events
    2013-03-28 22:59:09.249617 [Info.][MPMain(1)]: BASS: Successfully created BASS audio stream
    2013-03-28 22:59:09.249617 [Info.][MPMain(1)]: BASS: ---------------------------------------------
    2013-03-28 22:59:09.253617 [Info.][MPMain(1)]: BASS: ---------------------------------------------
    2013-03-28 22:59:09.254618 [Info.][MPMain(1)]: BASS: Creating BASS mixer stream
    2013-03-28 22:59:09.254618 [Info.][MPMain(1)]: BASS: Freed WASAPI device
    2013-03-28 22:59:09.254618 [Debug][MPMain(1)]: BASS: Creating 2 channel mixer with sample rate of 44100
    2013-03-28 22:59:09.256618 [Info.][MPMain(1)]: BASS: Initialising WASAPI device
    2013-03-28 22:59:09.256618 [Debug][MPMain(1)]: BASS: Init WASAPI shared mode with Event driven system enabled.
    2013-03-28 22:59:09.275622 [Info.][MPMain(1)]: BASS: ---------------------------------------------
    2013-03-28 22:59:09.275622 [Info.][MPMain(1)]: BASS: Buffer Length: 15360
    2013-03-28 22:59:09.275622 [Info.][MPMain(1)]: BASS: Channels: 2
    2013-03-28 22:59:09.275622 [Info.][MPMain(1)]: BASS: Frequency: 96000
    2013-03-28 22:59:09.276621 [Info.][MPMain(1)]: BASS: Format: BASS_WASAPI_FORMAT_FLOAT
    2013-03-28 22:59:09.276621 [Info.][MPMain(1)]: BASS: InitFlags: BASS_WASAPI_AUTOFORMAT, BASS_WASAPI_EVENT
    2013-03-28 22:59:09.276621 [Info.][MPMain(1)]: BASS: Exclusive: False
    2013-03-28 22:59:09.277620 [Info.][MPMain(1)]: BASS: ---------------------------------------------
    2013-03-28 22:59:09.277620 [Info.][MPMain(1)]: BASS: WASAPI Device successfully initialised
    2013-03-28 22:59:09.278621 [Info.][MPMain(1)]: BASS: Successfully created BASS Mixer stream
    2013-03-28 22:59:09.278621 [Info.][MPMain(1)]: BASS: ---------------------------------------------
    2013-03-28 22:59:09.280627 [Info.][MPMain(1)]: BASS: playback started
    Click to expand...
     
    Last edited:
    T

    tourettes

    Retired Team Member
  • Premium Supporter
    • January 7, 2005
    17,301
    4,800
    bug#2 If some other application steals the WASAPI device MP cannot continue the playback unles user presses the stop + play. MP should detect the lost WASAPI device and then stop the audio playback so that user doesn't have to wonder why the music seems to be in "paused" mode and play cannot be used to continue.
     
    Status
    Not open for further replies.

    Users who are viewing this thread

    Online now: 4 (members: 0, guests: 4)

    About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

    Quick Navigation

    Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!

    Community platform by XenForo® © 2010-2021 XenForo Ltd.
    Top Bottom