Music Player Rework (1 Viewer)

[azzuro]

Hi, could you upload a sample on ftp ?

I upload actually 3 files on FTP
Sample /
M4A : 2 files
TAK : 1 file (add this extension to MP audio config, Warn MP don't play this extension, is only for reproduce the bug )
refresh rate must be activate.

 

[Sebastiii]

I can reproduce Refresh Rate issue but not related to this thread
It's a false detection from MP (should be fixed in local)

But when debugging this, i have some music speedup (windows is set to 44.1) and also get easy crash when music is played and a breakpoint is hit, when i run (F5) -> MP Crash.

Will grab log is needed

 

[Sebastiii]

Attached log :
I start to play Aaron - U-turn (Lili).mp4 and when i try to play Will + New Directions - Fix You.mp4, MP Crash.
AHAH

Aaron - U-turn (Lili).mp4 = audio
Will + New Directions - Fix You.mp4 = video + audio

Starting directly Will + New Directions - Fix You.mp4 -> playing speedy.

 

[Sebastiii]

Ok the crash is random and didn't happen each time :

Starting by Will + New Directions - Fix You.mp4 (video+audio) is playing fast -> click on Aaron - U-turn (Lili).mp4 -> playing fast too
Starting by Aaron - U-turn (Lili).mp4 is playing normal -> click on -> Will + New Directions - Fix You.mp4 (video+audio) -> playing fast too or crash.

 

[Sebastiii]

Hey,

It's fixed on my side (fork branch with your music rework @hwahrmann).
The crash was because MPAR was in use and use Wasapi and then cleanup method need to be change to really cleanup audiorenderer.
I have added a check if the file is really a video and then (it will be played correctly).
Ofc better is to not have video / audio in the same folder lol.

I will provide a patch based on your branch / master
Thanks.

 

[Sebastiii]

This is the patch, not full related to this branch but this one trigger it

 

[hwahrmann]

Improvement :
Add support of CUE + Audio file, for single file with external timestamp :
CUE + WAV / CUE + APE / ....

REM DISCID 3B122B17
PERFORMER "multis"
TITLE "dancefloor fg ete summer 2009"
CATALOG 0600753190197
REM DATE 2009
REM GENRE "Dance"
REM COMMENT "YEAR: 2009"
FILE "multis - dancefloor fg ete summer 2009.tak" WAVE
  TRACK 01 AUDIO
	PERFORMER "multis"
	TITLE "lady gaga-  Lovegame (Dave Aude Radio Edit)"
	ISRC USUM70966396
	INDEX 01 00:00:00
  TRACK 02 AUDIO
	PERFORMER "multis"
	TITLE "The Black Eyed Peas - Boom Boom Pow (David Guetta’s Electro Hop Remix)"
	ISRC USUM70964619
	INDEX 01 03:31:00

I don't understand what you would like to have enhanced?
We can run CUE with single audio files. Just the TAK format, which you have in your sample above, is not supported by BASS.

 

[azzuro]

Yep, sorry, i have tested this yesterday and it's working correctly .... i don't understand why, isn't working on last test ...

 

[elliottmc]

I am a little bit lost with this thread. Would it be possible to have a summary of the status of this rework?

We have 9 separate mantis entries.

- 0003695: [Music] Rework BASS implementation (hwahrmann) - ready for testing.
- 0003477: [MediaPortal 1] Playing TV from EPG crashes MP, when music is playing (hwahrmann) - ready for testing.
- 0004021: [Music] Implement Resume Playback in Music Player (hwahrmann) - ready for testing.
- 0003697: [Music] Rework ASIO code within BASS Player (hwahrmann) - ready for testing.
- 0003377: [Music] MediaPortal does not play music with sample rates not equal to 44.1kHz properly when using ASIO (hwahrmann) - ready for testing.
- 0004032: [Music] The Delete Button inside a Music Playlist does not work - new.
- 0003698: [Music] Implement Replay Gain support in BASS player (hwahrmann) - assigned.
- 0003696: [Music] Implent WASAPI support within BASS (hwahrmann) - assigned.
- 0002551: [Music] Skip Steps no longer working in My Music (hwahrmann) - ready for testing.

Are they all included in the fix? I am thinking in particular of 4032, 3698, 3696 which are not flagged as ready for testing.

What issues are known?

Thanks,

Mark

 

[hwahrmann]

All of them are included and all of them should be set ready for testing.

Only known issues are:
- Too fast playback, when using WASAPI Shared Mode. Working on that
- Possible crash, when WASAPI device is in use by other application - also working on that