New DVB subtitle filter (TsReader based) (2 Viewers)

[ziphnor]

I have added two small fixes in builds >= 16160. There seemed to be a problem such that if the max number of teletext buffers in tsreader is reached it would crash (so if you had crashes with 'contains too much!' this might help). However, the line that causes the crashes is not a bug, it really should work, so it might indicate memory corruption in TsReader which was just brought to light by the teletext pin on tsreader (or of course, introduced by it so dont expect everything to be fixed yet.

I know logs would be great but that behavour is just so random it doesn't happen every day.

Well, even if the crash is random, what prevents you from posting the log files? Whenever you encounter a crash, just take a backup of the log files, and post them here when you can find the time.

There is no doubt that TsReader and the teletext subtitle stuff has some issues, but we will never get them fixed if people don't provide information on the problems they encounter.

 

[pmcguire]

The crashes to desktop over here seem to be preceded by a breakup in the picture and sound, lot's of blocks in the picture and crackling and stuttering.

mediaportals final log entry is..

009814 [info][mpmain] PlaneScene: Presentimages() dispose surfaces

 

[wemppu]

I have added two small fixes in builds >= 16160.

Just to make sure; to test right tsreader, these fixes are available for testing from TVE3 build above 16160?
TVE3 build 16148 is latest available when typing this.

 

[pmcguire]

TVE3 build 16148 is latest available when typing this.

It will be up in a few hours.

 

[lugiber]

First of all, thanks for making this "plugin". I love watching asian flicks on tv and they are no good to me without subtitles as i wouldn't understand anything.

Heres my impressions on tve3 (svn 16163) and Media Portal (svn 16049).
The subtitles are working great with a few minor flaws:

The subs lag behind about 7-10 seconds.
The subtitles stay on screen until they are replaced by new subtitles. This means that a subtitle (single line) can stay on screen for a very long time of no one says anything in the movie.

This is my DVBsub.log

11-10-2007 01:16:37 -------------- MediaPortal DVBSub2.ax version 6 (+teletext mod) ----------------
11-10-2007 01:16:37 Subtitle: Input pin created
11-10-2007 01:16:37 Teletext decoder ctor ..
11-10-2007 01:16:37 Magazine ctor
11-10-2007 01:16:37 Magazine ctor
11-10-2007 01:16:37 Magazine ctor
11-10-2007 01:16:37 Magazine ctor
11-10-2007 01:16:37 Magazine ctor
11-10-2007 01:16:37 Magazine ctor
11-10-2007 01:16:37 Magazine ctor
11-10-2007 01:16:37 Magazine ctor
11-10-2007 01:16:37 TeletextInputPin: Reset
11-10-2007 01:16:37 Teletext: Input pin constructor!
11-10-2007 01:16:37 STATUSTEST : 111
11-10-2007 01:16:37 SetBitmapCallback called
11-10-2007 01:16:37 SetTeletextCallback called
11-10-2007 01:16:37 STATUSTEST : 222
11-10-2007 01:16:37 SetTimestampResetedCallback called
11-10-2007 01:16:37 SetUpdateTimeoutCallback called
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - DID NOT FIND MEDIASUBTYPE_MPEG2_TRANSPORT!
11-10-2007 01:16:37 Subtitle: CSubtitleInputPin::CheckMediaType() - found MEDIASUBTYPE_MPEG2_TRANSPORT
11-10-2007 01:16:37 TeletextInputPin: CheckMediaType
11-10-2007 01:16:37 Teletext: CTeletextInputPin::CheckMediaType() - found MEDIASUBTYPE_MPEG2_TRANSPORT
11-10-2007 01:16:37 TeletextPin: Complete Connect
11-10-2007 01:16:37 CDVBSub::Pause
11-10-2007 01:16:37 CDVBSub::Pause - done
11-10-2007 01:16:37 CDVBSub::Run
11-10-2007 01:16:37 CDVBSub::Run - done
11-10-2007 01:16:37 TEST : 1
11-10-2007 01:16:37 CDVBSub::SetTeletextPid() 96
11-10-2007 01:16:37 Teletext PID has changed!
11-10-2007 01:16:37 CDVBSub::Pause
11-10-2007 01:16:37 CDVBSub::Pause - done
11-10-2007 01:16:37 CDVBSub::Reset()
11-10-2007 01:16:37 TeletextPin: PID is 96
11-10-2007 01:16:37 CDVBSub::Run - done
11-10-2007 01:16:37 CDVBSub::NotifySubPageInfo
11-10-2007 01:16:37 CTeletextInputPin::NotifySubPageInfo
11-10-2007 01:16:37 Page 692 is lang nor
11-10-2007 01:16:37 CDVBSub::NotifySubPageInfo
11-10-2007 01:16:37 CTeletextInputPin::NotifySubPageInfo
11-10-2007 01:16:37 Page 693 is lang dan
11-10-2007 01:16:37 CDVBSub::NotifySubPageInfo
11-10-2007 01:16:37 CTeletextInputPin::NotifySubPageInfo
11-10-2007 01:16:37 Page 694 is lang fin
11-10-2007 01:16:37 TeletextPin: reset
11-10-2007 01:16:37 SetTimeCompensation 0:00:00.102
11-10-2007 01:16:37 CDVBSub::Pause

Again thanks for making this possible!
If you need more/different logs please let me know and i'll post them.

/Peter

 

[gibman]

Hi Ziphnor!

Another ttxt based crash just like I posted before, this time with dvbsubs.log.

This was with eabins tsreader patch with ttxt enabled - but the problem has been there for a while.
So not related to eabin.

Regards Gibman

 

[ziphnor]

Hi Ziphnor!
Another ttxt based crash just like I posted before, this time with dvbsubs.log.

This was with eabins tsreader patch with ttxt enabled - but the problem has been there for a while.
So not related to eabin.

Thanks! Just so i understand, is this before or after the fixes i posted about above? Ie. is it before or after build 16160?

Hmm, i guess if by eabins fix, you refer to the files tourettes posted earlier, then i guess its before 16160. In that case the problem should hopefully be fixed in more recent version( higher than 16160 ). Ive run my HTPC on a channel with ttxt subtitles for 8+ hours without issue (not that this proves anything however

 

[tourettes]

Hi Ziphnor!
Another ttxt based crash just like I posted before, this time with dvbsubs.log.

This was with eabins tsreader patch with ttxt enabled - but the problem has been there for a while.
So not related to eabin.

Thanks! Just so i understand, is this before or after the fixes i posted about above? Ie. is it before or after build 16160?

Hmm, i guess if by eabins fix, you refer to the files tourettes posted earlier, then i guess its before 16160. In that case the problem should hopefully be fixed in more recent version( higher than 16160 ). Ive run my HTPC on a channel with ttxt subtitles for 8+ hours without issue (not that this proves anything however

I'm able to reproduce one crash with the latest TsReader & DVBSub when the teletext pin is enabled on the TsReader. The crash is really easy to reproduce with some .ts recordings, just press arrow up & arrow down (i.e. cause seeking quickly) rapidly many times in a row. I think this might be the same issue what gibman is seeing.

I'm, currently uploading Punainen viiva - YLE TV2 - 2007-10-09.ts recording to the FTP if you aren't able to reproduce it with your own recordings.

 

[gibman]

The build I tried with eabins mod was #16181
Both on server and on client.

Multiseat.

Also another issue.
I recorded a movie in TS format, acording to vlcplayer it contains nice ttxt subs -and they work fine, but only in vlc.

In MP nothing happens when I hit the L key on this recorded file.
Ofcourse I then tested ttxt subs on a live channel and there they worked fine.

Maybe it's because the TS file starts out with no subs (pre/post recording 5mins)
But isnt dynamic PID detection supposed to fix this ?
just let me know if u want a small preview of the that clip ?

/Gibman

 

[tourettes]

Maybe it's because the TS file starts out with no subs (pre/post recording 5mins)
But isnt dynamic PID detection supposed to fix this ?

If the VLC shows the subtitles then the .ts file should be ok (and TsWriter either recorded the stuff with or without the help of dynamic PMT detection.).

Could you upload that show to the FTP so Ziphnor can have a look on it?