New DVB subtitle filter (TsReader based) (1 Viewer)

[gibman]

Ok, its being uploaded to the FTP now using the tsdump ftp account.

gibman/Colors-2007-10-11-09_00.ts (340 mb)

good movie btw

The orig file was 4.5 gig, but I stopped the file transfer at a point where the movie has started using ttxt subs.
otherwise nothing has changed.

/Gibman

 

[ziphnor]

I'm able to reproduce one crash with the latest TsReader & DVBSub when the teletext pin is enabled on the TsReader. The crash is really easy to reproduce with some .ts recordings, just press arrow up & arrow down (i.e. cause seeking quickly) rapidly many times in a row. I think this might be the same issue what gibman is seeing.

I'm, currently uploading Punainen viiva - YLE TV2 - 2007-10-09.ts recording to the FTP if you aren't able to reproduce it with your own recordings.

I managed to crash that after alot of time ( and after forcing MP to run only on one CPU ).
However the error i got at the end which crashed it was:

13-10-2007 09:51:04 vid:fillbuffer exception

But it was preceeded by some Teletextbuffer full messages. This is a really tricky problem.

The build I tried with eabins mod was #16181
Both on server and on client.

Really? Your log shows the message "TeletextBuffer contains too much!" but i changed that log message to be "TeletextBuffer contains too much! ( <number of buffers> )". But maybe i forgot to update the binary, i will have to check...

 

[tourettes]

I'm able to reproduce one crash with the latest TsReader & DVBSub when the teletext pin is enabled on the TsReader. The crash is really easy to reproduce with some .ts recordings, just press arrow up & arrow down (i.e. cause seeking quickly) rapidly many times in a row. I think this might be the same issue what gibman is seeing.

I'm, currently uploading Punainen viiva - YLE TV2 - 2007-10-09.ts recording to the FTP if you aren't able to reproduce it with your own recordings.

I managed to crash that after alot of time ( and after forcing MP to run only on one CPU ).
However the error i got at the end which crashed it was:

13-10-2007 09:51:04 vid:fillbuffer exception

I have dual core CPU on my HTPC and I didn't have to force the MP to run on one core. It's really easy to trigger that crash on my system (just seek rapidly and usualy it crashes after few seeking operations). And with the ttxt pin disabled I haven't managed to crash the TsReader / MP.

I'll try to reproduce the crash on my dev machine to get some more info about it.

 

[ziphnor]

Regarding the teletext stuff, it seems the bug is somewhere in the DirectShow nightmare (teletext pin), so i have decided to move the teletext stuff into MP proper, passing the data directly from TSReader to MP bypassing DirectShow. This will avoid further DirectShow problems, and having the code in C# will make it easier to debug as well.

This will also open up for showing general teletext pages from timeshifted and recorded files (once i have time to talk to misterd .

I have already copied and adapted the necessary code, so now i will have to resolve any problems there might be. I will be back with more news when i am done rewiring (might be a few days).

 

[tourettes]

Regarding the teletext stuff, it seems the bug is somewhere in the DirectShow nightmare (teletext pin), so i have decided to move the teletext stuff into MP proper, passing the data directly from TSReader to MP bypassing DirectShow. This will avoid further DirectShow problems, and having the code in C# will make it easier to debug as well.

This will also open up for showing general teletext pages from timeshifted and recorded files (once i have time to talk to misterd .

I have already copied and adapted the necessary code, so now i will have to resolve any problems there might be. I will be back with more news when i am done rewiring (might be a few days).

Ziphnor, do you mind if I disabled the teletext pin from the SVN version TsReader? As currently it seems to responsible of some of the seeking & channel changing crashes we are seeing.

 

[ziphnor]

Ziphnor, do you mind if I disabled the teletext pin from the SVN version TsReader? As currently it seems to responsible of some of the seeking & channel changing crashes we are seeing.

Not at all, go right ahead, no reason to test it any further while im moving code around. I forgot to answer your PM, sorry

 

[tourettes]

Ziphnor, do you mind if I disabled the teletext pin from the SVN version TsReader? As currently it seems to responsible of some of the seeking & channel changing crashes we are seeing.

Not at all, go right ahead, no reason to test it any further while im moving code around. I forgot to answer your PM, sorry

Ok. DVB teletext subtitle support is disabled in SVN versions bigger than 16222.

So if you guys need to keep the teletext based subtitles supported, please don't update the TVE3!

:sorry:

 

[Hojou]

First off - thanks a bunch to tourettes and all of you other people putting so much work into this.

But for the love of .... why? why!!?? does MP not support subtitles by default? Why does this seem like this efford is being ignored by the core developers? Haven't most work not already been made - is it not a smaller matter of fitting all this work into the core to lauch MP with this feature, instead of removing the support in the new release? I do understand this might only be an issue to europeans and scandinavians especially, but we're humans too. We too cry salty tears and shed red warm blood, why have we been damned to hell by the... *cough* ok i got carried away sorry about that, but really... this is BIG "over here".


<-- boy i hate these lame icons, but it's so warrented here!

Hojou

 

[ziphnor]

But for the love of .... why? why!!?? does MP not support subtitles by default? Why does this seem like this efford is being ignored by the core developers? Haven't most work not already been made - is it not a smaller matter of fitting all this work into the core to lauch MP with this feature, instead of removing the support in the new release?

I think you misunderstood whats going on:

1. The subtitle support is dependent on TsReader which is not stable yet.

2. As long as TsReader is not the default file reader for .ts files, subtitle support cannot be default

3. The teletext support is unstable, and is being moved into the MP client to fix the problem, hence the temporary removal from SVN. It will be back as soon as i have time to make the last adjustments (on my dev machine im already watching teletext subs through the relocated code).

4. DVB subtitle support is still in SVN, though not enabled by default (see 3.) its only the teletext stuff thats been temp. removed.

 

[Hojou]

Allright i think i got it now It seems it's a work in progress and it's going somewhere so that's cool I just got the impression it was stabile but since it's not i understand why it's not a part of the release/beta.

Another thing i was speculating about - if i get cable tv (digital & analog) will I be able to view subtitles on the digital signal (my tv card is supposed to support it)? Is it the same encoding/format as DVB-T for subtitles or is it completely different?

Keep up the great work!