New DVB subtitle filter (TsReader based) (2 Viewers)

[ziphnor]

Unfortunately rev16500 crashes on my PC.

My apologies, as mentioned above i screwed up when resolving some SVN conflicts, leading to me replacing one of my own files with the old SVN. I have fixed that now, so you will need a higher revision.

Thanks for taking the time to test it, and sorry giving you the wrong stuff to test

 

[gibman]

I had forgotten about that one ( i used it for some testing in the old version ). Good thing you brought it up, in testing it, i found out i just screwed up some of my own code with SVN. I fixed that now

Where did you record this from? It appears to have the interesting property that the DVB PES packets carrying the teletext data are not marked as carrying subtitle data (so i disregard them), but apparently they do contain teletext pages that are marked as subtitle pages.

I recorded it off canal digital nordic on dvb-s (skystar2)

/Gibman

 

[gibman]

also, still crashing here ;

private void assert(bool ok, string msg) {
if (!ok) throw new Exception("Assertion failed! " + msg);
}

"Data alignment bit not set"

/gibman

 

[ziphnor]

"Data alignment bit not set"

Could you supply a .ts sample for that?

These assertions are checks that i do to make sure the stream is correct. In the future they will just turn into warning messages, but for now to make sure i know some people are seeing this (and to make sure its a stream problem and not a bug in my code), i throw an exception instead

The thing is, if that bit is really not set, then someone is not following the DVB teletext standard correctly....

 

[gibman]

Sure...

check gibman/live1-0.ts.tsbuffer1.ts

it's quite short.

 

[ziphnor]

check gibman/live1-0.ts.tsbuffer1.ts

I replaced the assert exception with a Log.Error, and it plays fine, showing one subtitle, no other sanity checks are tripped. I guess that the provider of that transport stream didnt read the standard correctly...

I have committed the change. I would be interested to see how many of your channels you get this error on (you only need to update MP itself).

 

[Seidelin]

Unfortunately rev16500 crashes on my PC.

My apologies, as mentioned above i screwed up when resolving some SVN conflicts, leading to me replacing one of my own files with the old SVN. I have fixed that now, so you will need a higher revision.

Thanks for taking the time to test it, and sorry giving you the wrong stuff to test

No problem. Rev16503 seems to work fine.

Regards
Seidelin

 

[Seidelin]

Oops, just had a crash watching a channel for 15 minutes or so.

Huge logs attached.

Regards
Seidelin

 

[ziphnor]

Huge logs attached.

I think i left some logging on by mistake

Its again one of my assertions (meaning its a non-critical error i made critical to make its reported). You dont happen to have the timeshift file that corresponds to the logs do you?

Its probably just some discontinuity, but i would really like to prevent it happening. I have committed a change removing those redundant log messages, and also doing Log.Error instead of throwing an exception (change is in 16504+).

 

[Seidelin]

Its again one of my assertions (meaning its a non-critical error i made critical to make its reported). You dont happen to have the timeshift file that corresponds to the logs do you?

I reproduced the error (using svn16503). Logs attached, and timeshift file (164 MB) will be on ftp in 12 minutes in teletext subtitles\crash...

Regards
Seidelin