Online Videos fails after MP 1.23 upgrade. (1 Viewer)

Sebastiii

Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Look my MvCentral (based on Movpics code) commit - Update for 1.22 Pre · andrewjswan/mvcentral@3dd9e95 - Wrong in the figure when describing a commit, read not 1.22 but 1.23.
    In a nutshell. I threw a wrapper for media info (which repeated the media portal code) from the plugin, and replaced all the wrapper calls with a new media portal. And it's all..
    View attachment 202004

    About movpic, i have try to change some code but not fully working :
    upload_2019-7-17_11-56-13.png


    Code:
    17-Jul-2019 08:26:41 Error [             DBField]: Error parsing DBLocalMedia.FileSize Property: Input string was not in a correct format.
    17-Jul-2019 08:26:41 Error [             DBField]: Error parsing DBLocalMedia.FileSize Property: Input string was not in a correct format.
    17-Jul-2019 08:26:41 Error [             DBField]: Error parsing DBLocalMedia.FileSize Property: Input string was not in a correct format.
    17-Jul-2019 08:27:11 Error [             DBField]: Error parsing DBMovieInfo.Year Property: Input string was not in a correct format.

    But some other files look OK :
    upload_2019-7-17_12-0-18.png


    OK movpic crash lol, so the change is not good !
     
    Last edited:

    ltfearme

    Community Plugin Dev
  • Premium Supporter
  • June 10, 2007
    6,751
    7,196
    Sydney
    Home Country
    Australia Australia
    Hey @Sebastii, I tried applying your patch and got an error:
    Code:
    git.exe am --3way --ignore-space-change --keep-cr "C:\Development\moving-pictures\317159_0001-Master-Trying-to-make-new-MediaInfo.Wrapper.dll-work (1).patch"
    Applying: Master : Trying to make new MediaInfo.Wrapper.dll working for MovingPictures.
    Patch failed at 0001 Master : Trying to make new MediaInfo.Wrapper.dll working for MovingPictures.
    The copy of the patch that failed is found in: .git/rebase-apply/patch
    When you have resolved this problem, run "git am --continue".
    If you prefer to skip this patch, run "git am --skip" instead.
    To restore the original branch and stop patching, run "git am --abort".
    error: sha1 information is lacking or useless (MovingPictures/MovingPictures.csproj).
    error: could not build fake ancestor
    Fail
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Hey @Sebastii, I tried applying your patch and got an error:
    Code:
    git.exe am --3way --ignore-space-change --keep-cr "C:\Development\moving-pictures\317159_0001-Master-Trying-to-make-new-MediaInfo.Wrapper.dll-work (1).patch"
    Applying: Master : Trying to make new MediaInfo.Wrapper.dll working for MovingPictures.
    Patch failed at 0001 Master : Trying to make new MediaInfo.Wrapper.dll working for MovingPictures.
    The copy of the patch that failed is found in: .git/rebase-apply/patch
    When you have resolved this problem, run "git am --continue".
    If you prefer to skip this patch, run "git am --skip" instead.
    To restore the original branch and stop patching, run "git am --abort".
    error: sha1 information is lacking or useless (MovingPictures/MovingPictures.csproj).
    error: could not build fake ancestor
    Fail

    Hey :)
    Attached is a clean repo patched (along with all patches I have on my side) but the MediaInfo one is the last one ofc :p
    Thanks
     

    Attachments

    • moving-picturesdamienpatched.zip
      46.3 MB

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Hey [emoji106]
    Yep the patch is not working and need help to make it works :)
    Maybe @ajs can help too
    Thanks

    Tapatalk
     

    Users who are viewing this thread

    Top Bottom