[fixed] Pictures currentSlideIndex resetting to -1 [Mantis #4461] (2 Viewers)

[mbuzina]

Sounds again like a thread accessing the GUI which is not GUI. Will add this info to mantis.

 

[Sebastiii]

I can confirm the same and when i try to debug that the first time all label etc. are not null, the second time it's ok.
Now why ??

 

[mbuzina]

@Sebastiii @jameson_uk is also checking on this, see thread https://forum.team-mediaportal.com/threads/1-4-0-final-test-builds.119153/page-6#post-997663. Somehow for me going back is not possible (neither ESC key not TopBar control).

 

[Sebastiii]

Try 'H' key to go to home

 

[Sebastiii]

There is a new bin for test (Exif fix + lastItem)

 

[mbuzina]

Did not find the bin. Where is it? Sorry, next test can only be somewhere tomorrow, got to go.

 

[Guzzi]

Sounds again like a thread accessing the GUI which is not GUI. Will add this info to mantis.

a bit offtopic, but maybe it is worth adding something like

	  // add thread check to log calls not running in main thread/GUI
	  int iCurrentThread = Thread.CurrentThread.ManagedThreadId;
	  if (iCurrentThread != 1)
	  {
		Log.Error("LoadSkin: Running on thread <{0}> instead of main thread - StackTrace: '{1}'", iCurrentThread, Environment.StackTrace);
	  }

I used this in GUIWindow.cs in Loadskin() to easily find calls for GUI not coming from main thread.
Could be in a "if debug" if we want to make sure it is not running in non debug mode ...

 

[Sebastiii]

Did not find the bin. Where is it? Sorry, next test can only be somewhere tomorrow, got to go.

Yep, need to recreate one from latest commit

 

[mbuzina]

I can not at the moment. Could someone trigger a build & post the link?

Thanks!

 

[mbuzina]

Ah - I guess you meant the latest build of 1.4.0 final? OK will get that one.

UPDATE: OK That's not it. So please could someone build it for me to test? Thx again