[fixed] - Pictures currentSlideIndex resetting to -1 [Mantis #4461] | Page 7

Discussion in '1.4.0 Pre-Release' started by markus_g, May 24, 2013.

  1. mbuzina
    • Premium Supporter

    mbuzina Retired Team Member

    Joined:
    April 11, 2005
    Messages:
    2,839
    Likes Received:
    627
    Location:
    Germany
    Ratings:
    +723 / 4
    Home Country:
    Germany Germany
    Show System Specs
    It did for me - that might be pure coincidence (I used the same folder with pictures) but in 3 tests it randomized the pics.


     
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    • Like Like x 1
  4. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,318
    Likes Received:
    6,259
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,297 / 9
    Home Country:
    France France
    Show System Specs
    Yep it's related :)

    I'm debugging right now and now on folder with 3 pictures random is respected :) but when we have folder1 with inside some pictures then folder2 with pictures and so on.

    Random will work but it's possible that we see again already seen pictures, i try to find a way to remove already seeing pictures but like pictures use index from a list and use cache and use prev/current/next etc. that not easy :(
     
  5. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Looking at the logic, it does seem to make a list and then use it.
     
  6. mbuzina
    • Premium Supporter

    mbuzina Retired Team Member

    Joined:
    April 11, 2005
    Messages:
    2,839
    Likes Received:
    627
    Location:
    Germany
    Ratings:
    +723 / 4
    Home Country:
    Germany Germany
    Show System Specs
    Progress - it does look like it is Shuffling too often. 1.3 does re-shuffle after the whole slide show if loop is turned on - so you do not get the exact same slide show twice.

    P.S.: What did the commit try to achieve? It moved the shuffling to another place? Maybe revert it?
     
    Last edited: May 29, 2013
  7. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,318
    Likes Received:
    6,259
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,297 / 9
    Home Country:
    France France
    Show System Specs
    Hi,

    I'm not in mood to do full regression lol (i have the mind tired :) ), can you try attached bin ?

    In this bin, should be fixed :
    • EXIF
    • Going to Fullscreen (when shuffle is enable) right/left should stay in order
    • ESC after going to fullscreen, should go on last item played
    • Recursive SlideShow (no more duplicate played item)
    • Auto-repeat with Recursive SlideShow should work and again no duplicate files should be played
    Can you try and see regression ? (could be nice to test with music and with video/pictures)

    Thanks :)
     
    Last edited: May 31, 2013
    • Like Like x 1
  8. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    @mbuzina - did you have time to test?

    @Sebastiii - I will mantis the remaining two issues for 1.4.0. Just to clarify, these are

    1. Picture slideshow in random order can repeat some pictures and miss others

    2. help me out here. What is the exact issue with recursive slideshow? What is a recursive slideshow and how does the issue differ from 1 ? Do we even need a second mantis entry since these seem like similar issues? Will it actually be possible to provide a fix for one and a separate fix for the other?
     
    • Like Like x 1
  9. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,318
    Likes Received:
    6,259
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,297 / 9
    Home Country:
    France France
    Show System Specs
    Yep

    You are right both issues has to be solved together (so it's in fact one issue with some effect).
    When fixing 1. issue, Recursive should be fixed too but like recursive slideshow analyse subfolder only when item is a folder (from a list), random option will rearrange already seen picture + new one found in folder (hmmm i'm not clear). Now it shouldn't happen with the fix.

    So 'What is the exact issue with recursive slideshow?' :
    -> Random order can repeat some pictures and miss others (Fixed in issue 1.)
    -> when folder is found, it reorder the list (so already seeing picture is back to play.)

    so 'What is a recursive slideshow and how does the issue differ from 1 ?':
    -> when adding new picture from a folder -> we go to : when folder is found, it reorder the list (so already seeing picture is back to play.)

    so 'Do we even need a second mantis entry since these seem like similar issues?' :
    -> I think not because the fix need to be global.

    so 'Will it actually be possible to provide a fix for one and a separate fix for the other?' :
    -> i would say no.
     
  10. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    • Like Like x 1
  11. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,318
    Likes Received:
    6,259
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,297 / 9
    Home Country:
    France France
    Show System Specs

    Done :) for 4472, about the second EXIF fix, i would like to be sure that actual mike's one failed :) and i will supply it
     
    Last edited: May 31, 2013
    • Like Like x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!