- March 24, 2007
- 12,073
- 7,459
- Home Country
- Germany
- Thread starter
- Moderator
- #61
Yes, the issue probably is not related to refresh rate changing at all. Maybe only the retrieval of video frame "hangs" at the end of playback?
public void UICapture(object sender, EventArgs args)
{
if (!AtmoLightObject.IsConnected() || !AtmoLightObject.IsAtmoLightOn() || AtmoLightObject.GetCurrentEffect() != ContentEffect.MediaPortalLiveMode)
{
return;
}
No, not that i can think of. Worst case scenario, The calculations in ChangeDelay() result in 0 or a negative number.One question: I only found one place where the refreshrate is considered:
https://github.com/ambilight-4-medi...er/AtmoLight.MediaPortal2/Plugin.cs#L212-L213
Is it possible that inside the "AtmoLightObject" might appear problems, if at player ending the refresh rate is changed back to original one?
I know very little of DirectX, SharpDX or redering in generall, so might be. But UICapture() is called by the event SkinContext.DeviceSceneEnd (see: https://github.com/ambilight-4-medi.../master/AtmoLight.MediaPortal2/Plugin.cs#L118) so i was under the impression this only gets called when a frame has been rendered completly and is ready?!Another thing comes into my mind: it could be required to sync frame grabbing to rendering (see SkinContext.DeviceSceneEnd event), so you don't query surface while scene is still being rendered (although this has also nothing todo with refresh rate)
No problem, i was not expecting you to look through all of the code .Ok, if you use this event it's good. I have not checked all code, so sorry if I missed it.
No . Tested on 2 systems (htpc and laptop) and with last official release and our current dev build.Can you reproduce the "hang" in video end with refresh rate change and AtmoLight enabled?
Count me in this group!I think a lot of people will start to move over to mp2 once this is finished, i think a big part of people avoiding it is the lack of a skin that makes it shine to show what it can do.
And Powerscheduler not working 100% for me too...but this it totally off topic I guess...For me, it's the RefreshRate Changer who breaks me to do the switch.