[Approved] rightalign tag for Image control (1 Viewer)

[Migue]

Similar to the <centered> tag but for right-alignment instead.

EDIT: New patch attached using align tag as other controls do.
2nd EDIT: Forgot to update summary description for property in the patch.

 

[Dadeo]

Hi Migue, team is currently evaluating, stay tuned

Added to Mantis Issue 3064

 

[arion_p]

Hi Migue,

We have been discussing your patch and we have agreed that it would be preferable to have one tag named <align> with values left, center, right (left being the default) so that it is consistent with the rest of the controls. Also since only one alignment can be applied at any time the <centered> should internally be mapped to <align>center</align> (essentially it should be a property get/set pair that should get/set its value from/to the align property). We do not want to remove the <centered> tag for backward compatibility (perhaps in a later version we will)

Do you think you could provide a patch for that?

Thanks in advance

Arion

 

[Migue]

Yes this was my idea originally except I didn't thought of remapping centered and so I did it the way I did to prevent existing skin breaking.
I'll get working on the new patch now.

 

[Migue]

New patch posted on first post.

 

[Dadeo]

Thanks Migue any chance of a binary for testing?

 

[arion_p]

Thanks Migue, patch looks good

 

[arion_p]

Modified patch (added valign) committed in SVN 26529.
Thx Migue