Scythe42's fixes for 1.4.0 (6 Viewers)

[FreakyJ]

yes I did changes there two years ago... I compared the values with my backup and the values are the standard ones, nevertheless I deleted the regkeys and restored the backup from 2011 So everything should right again?

 

[Scythe42]

@Scythe42
Any idea regarding my volume problem? i still got sometimes a not working volume control but no error in log.

No idea. But as you are compiling MP yourself, give it a try re-initializing the volume handler at a later stage (Dispose and Re-Create). Also check how the mixer in Windows is looking in regards to volume level and muting for the device you have choose to be used by MP. Also try not to use the default direct show audio device and select it explicitly. In case it changes during resuming.

 

[Scythe42]

yes I did changes there two years ago... I compared the values with my backup and the values are the standard ones, nevertheless I deleted the regkeys and restored the backup from 2011 So everything should right again?

Windows will re-create them the next time the system is started. You should see that on the first startup afterwards you Desktop is set to 1024x768 and you have to adjust it again. That should Windows now allow to send proper display change messages MP can track and re-act to them.

 

[azzuro]

@disaster123 you don't use MPAR ?

 

[FreakyJ]

And I just updated to the latest version I can't reproduce the error on demand so only the time will tell
Attached are the latest logs what I did:
- start MP
- unplugged HDMi cable
- waited 20 sec
- plugged it in again
- everything was fine...

But with 18c there was everything fine for a long time, I had only two times problems with this version regarding the Tv switch off... But I will observe the latets version and report if it should happen again, this cases are really rare

 

[FreakyJ]

Windows will re-create them the next time the system is started.

deleted it again and restarted -> windows recreated it -> reconfigured my resolution and now lets see how it behaves Thanks for the tip

 

[Sebastiii]

Hi,

Latest version (GIT) seems in fullscreen, the font are not clear, it happen when going from windowed to fullscreen.
If we start on fullscreen -> it's OK -> but after doing alt-enter (to go in windowed) -> font are not ok.

Also fullscreen to windowed seems to take time (previous was really fast).

 

[FreakyJ]

the fonts are looking good to me in your screenshot.... but I think we already discussed that "issue".. Scythe won't fix that because he will replace the fontengine anyway

 

[Sebastiii]

Effectively on screenshot it seems good but it's not lol.
i will take a picture to show the diff

 

[Owlsroost]

I'll add a note to Mantis 3991 to explain the symptoms/effects of the problem (for the benefit of users who don't know much about how MP works inside).
Tony

Thank you. I experimented with using additional swap chains. But has not yet worked out properly because of too many stuff that is directly tied in to the device creation. But does not mean that I do not find a trick here.

I added a compromise: If on a toggle windowed/fullscreen mode the backbuffer size does not equal the skin size, the D3D device is reset.

When does it happen:

• Using a 16:9 skin on a 16:10 display
• Using a 720p skin on a 1080p display (I know, same aspect ratio, but I do not want too much complexity here)
• Using a 4:3 skin on a 16:9 display (that will result in letterboxed plackback of 16:9 movies anyway)
• MP started in Windowed mode and you switch the first time to a full screen mode (backbuffer was initially limited to maximum aspect ratio safe size of the skin)
• ... and so on

We go through a full device reset, unloading and reloading every resource here. No need to check if we are using EVR or not. That is the quickest solution I can offer without spending hours and hours on something that's is not needed for a very long time.

The Skin defines the aspect ratio MP is using for windowed mode. In other words in windowed mode the aspect ratio set by the skin can be obeys, whereas in full screen mode it cannot.

That should hold until the player side has its own D3D device. Needs it anyway when we are moving to D3D11 as EVR needs a D3D9Ex device anyway. Also at this time the refresh rate changer is managed from the presenter side.

Just tried the latest build on 1680 x 1050 display (16:10 aspect ratio)

Start MP in fullscreen -> video OK (top/bottom black bars), switch to windowed -> video OK (no black bars, and D3D device reset), switch back to fullscreen -> video not OK (stretched vertically, no top/bottom black bars) and no D3D reset (as far as I can tell). I stopped playback before each mode switch.

So it appears to be doing the D3D reset on the fullscreen -> windowed transition, but not on the windowed -> fullscreen transition (and once it is in windowed aspect ratio mode, it won't switch back to fullscreen aspect ratio - you have to quit and restart MP)

Logs attached (MP started in fullscreen mode, followed by several fullscreen/windowed/fullscreen/... switches)