[Approved] Small Setup Patch (2 Viewers)

[Smeulf]

Hi,

Just moved shortcuts from "StartMenu\MediaPortal 2" to "StartMenu\Team MediaPortal\MediaPortal 2" folder.

Patch attached.

Cheers.

 

[Oxan]

I might be wrong, but I don't think the ICE 38 workaround is needed. We use code like in the patch below (untested) in MPExtended without triggering any ICE warnings. Clue is to don't have an Id attribute on the directory.

diff --git a/MediaPortal/Setup/MP2-Setup/MediaPortal2.wxs b/MediaPortal/Setup/MP2-Setup/MediaPortal2.wxs                                                                           
index 8e5711f..3bd8ec1 100644                                                                                                                                                      
--- a/MediaPortal/Setup/MP2-Setup/MediaPortal2.wxs                                                                                                                                 
+++ b/MediaPortal/Setup/MP2-Setup/MediaPortal2.wxs                                                                                                                                 
@@ -105,7 +105,9 @@                                                                                                                                                                
       </Directory>                                                                                                                                                                
                                                                                                                                                                                   
       <Directory Id="ProgramMenuFolder">                                                                                                                                          
-        <Directory Id="MP2StartMenu" Name="MediaPortal 2" />                                                                                                                      
+        <Directory Name="Team MediaPortal">                                                                                                                                       
+          <Directory Id="MP2StartMenu" Name="MediaPortal 2" />
+        </Directory>
       </Directory>
 
       <Directory Id="DesktopFolder" />

 

[Smeulf]

Thanks Oxan for the input. I'll check this later, I moved to another issue ATM

Smeulf.

 

[Albert]

AW: Small Setup Patch

I'll wait for your investigations Smeulf before I merge the patch.

 

[morpheus_xx]

AW: Small Setup Patch

I've applied this path to the recent installer. Without adding a Component for the directory it did not work.