[Approved] - Small Setup Patch

Discussion in 'Submit: Code Patches' started by Smeulf, December 30, 2011.

  1. Smeulf
    • Team MediaPortal

    Smeulf Test Group

    Joined:
    October 27, 2010
    Messages:
    672
    Likes Received:
    227
    Location:
    France
    Ratings:
    +228 / 0
    Home Country:
    France France
    Show System Specs
    Hi,

    Just moved shortcuts from "StartMenu\MediaPortal 2" to "StartMenu\Team MediaPortal\MediaPortal 2" folder.



    Patch attached.

    Cheers.
     

    Attached Files:

  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. Oxan
    • Premium Supporter

    Oxan Retired Team Member

    Joined:
    August 29, 2009
    Messages:
    1,730
    Likes Received:
    1,024
    Gender:
    Male
    Ratings:
    +1,115 / 2
    Home Country:
    Netherlands Netherlands
    I might be wrong, but I don't think the ICE 38 workaround is needed. We use code like in the patch below (untested) in MPExtended without triggering any ICE warnings. Clue is to don't have an Id attribute on the directory.

    Code (Text):
    1. diff --git a/MediaPortal/Setup/MP2-Setup/MediaPortal2.wxs b/MediaPortal/Setup/MP2-Setup/MediaPortal2.wxs                                                                          
    2. index 8e5711f..3bd8ec1 100644                                                                                                                                                      
    3. --- a/MediaPortal/Setup/MP2-Setup/MediaPortal2.wxs                                                                                                                                
    4. +++ b/MediaPortal/Setup/MP2-Setup/MediaPortal2.wxs                                                                                                                                
    5. @@ -105,7 +105,9 @@                                                                                                                                                                
    6.        </Directory>                                                                                                                                                                
    7.                                                                                                                                                                                    
    8.        <Directory Id="ProgramMenuFolder">                                                                                                                                          
    9. -        <Directory Id="MP2StartMenu" Name="MediaPortal 2" />                                                                                                                      
    10. +        <Directory Name="Team MediaPortal">                                                                                                                                      
    11. +          <Directory Id="MP2StartMenu" Name="MediaPortal 2" />
    12. +        </Directory>
    13.        </Directory>
    14.  
    15.        <Directory Id="DesktopFolder" />
    16.  
     
    • Like Like x 1
  4. Smeulf
    • Team MediaPortal

    Smeulf Test Group

    Joined:
    October 27, 2010
    Messages:
    672
    Likes Received:
    227
    Location:
    France
    Ratings:
    +228 / 0
    Home Country:
    France France
    Show System Specs
    Thanks Oxan for the input. I'll check this later, I moved to another issue ATM ;)

    Smeulf.
     
  5. Albert
    • Premium Supporter

    Albert MP2 Developer

    Joined:
    February 18, 2008
    Messages:
    1,297
    Likes Received:
    1,125
    Gender:
    Male
    Occupation:
    Dipl.-Inform.
    Location:
    Freiburg im Breisgau, Germany
    Ratings:
    +1,130 / 1
    Home Country:
    Germany Germany
    AW: Small Setup Patch

    I'll wait for your investigations Smeulf before I merge the patch.
     
  6. morpheus_xx
    • Team MediaPortal

    morpheus_xx Lead Dev MP2

    Joined:
    March 24, 2007
    Messages:
    11,065
    Likes Received:
    4,760
    Ratings:
    +6,814 / 11
    Home Country:
    Germany Germany
    Show System Specs
    AW: Small Setup Patch

    I've applied this path to the recent installer. Without adding a Component for the directory it did not work.
     
    • Like Like x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!