Subtitle issue (2 Viewers)

[Sebastiii]

Thanks for the sample and it can help other for the testing
I have one bluray where i can reproduce the issue too

 

[Sebastiii]

Hey

With idea of @Rick164 (i was testing this it but i surely mixed repo lol).
So on my side it works, i only port the change related HDMV and i was able to compil (ofc it could be nice to have the full latest MPC-HC Engine update but like it works, we surely stay like this )

Attached is the binary to test

Commit : https://github.com/Sebastiii/MediaPortal-1/commit/286b7ca45ea404400a1cf63fa63eb4594ad8f386

 

[fredco]

Hey Sebastiii,

Don't know what you guys were all talking about, but I know ONE thing: you're a fuckin' WIZARD. It works like a charm! This should definitely be put into the next MP-release.
Thank you very very much!

 

[Rick164]

Hey

With idea of @Rick164 (i was testing this it but i surely mixed repo lol).
So on my side it works, i only port the change related HDMV and i was able to compil (ofc it could be nice to have the full latest MPC-HC Engine update but like it works, we surely stay like this )

Attached is the binary to test

Commit : https://github.com/Sebastiii/MediaPortal-1/commit/286b7ca45ea404400a1cf63fa63eb4594ad8f386

Awesome fix

Merging the newer MPC-HC engine completely might be possible but requires a lot of work and some deeper understanding of the MPC-HC code (which without documentation is hard), would also have to weigh it against the benefits compared to how it's now as well

 

[Helios61]

Hi @Sebastiii
Big Thanks for your effort and this great fix . Subtitles are looking great now.
Best regards
Helios

 

[Sebastiii]

Jira + Review + Branch opened
https://issues.team-mediaportal.com/browse/MP1-4682

 

[Sebastiii]

@regeszter , i have merged it to the pre release branch too

 

[regeszter]

@regeszter , i have merged it to the pre release branch too

Please create a new build for internal testing and link to the 1st post of our internal thread.