SubtitleDownloader (6 Viewers)

[DuckTest]

Re: SubtitleDownloader 2.7

I can confirm that the family guy subs are working, but too bad there is a (new) problem.

New testcase:
Reproduce:
1) Download the subtitle of "For Whom the Sleigh Bell Tolls" of American Dad (S07E08) manual (dutch) - note the subtitle says S06
2) Download it with MP-Tvseries

When comparing the two files: check line 227.
Manual:

kan je beter weg zijn, oké?

with MP-Tvseries:

kan je beter weg zijn, ok�?

When I checked the encoding with Notepad++:
Manual: ANSI
with MP-TVseries: UTF-8 with BOM


Concluding, Bierdopje has different encoded subtitles (now ANSI instead of UTF-8) and this goes wrong in the bierdopje API. 'Funny' is that the manual download don't give any problems.

I try to contact bierdopje (API) - team
edit: made an issue @bierdopje API


UPDATE
I'm now confused: when debugging the bierdopjeApi code in Visual Studio there is no problem. The problem cannot be reproduced with only the code, so
- manual download from bierdopje.com: OK
- download with code in Visual Studio: OK
- download with MP-TVseries: encoding problem.

I assumed that the encoding problem was of problem of bierdopjeApi because:
- The bierdopjeApi downloads really the file
- With the update of bierdopjeApi in subtitleDownloader 2.7 the 'family guy'-problem is solved
- I assumed no component alters the file after download.

Anyway, I'm not sure where the problem is located: bierdopjeApi, SubtitleDownloader or MP-tvseries. Please keep in mind that I don't want to blame anyone, I just want to solve the problem and let MP rock!

I need to do some more investigation, but there is no time before the weekend now.

 

[seco]

Re: SubtitleDownloader 2.7

I can confirm that the family guy subs are working, but too bad there is a (new) problem.

New testcase:
Reproduce:
1) Download the subtitle of "For Whom the Sleigh Bell Tolls" of American Dad (S07E08) manual (dutch) - note the subtitle says S06
2) Download it with MP-Tvseries

When comparing the two files: check line 227.
Manual:

kan je beter weg zijn, oké?

with MP-Tvseries:

kan je beter weg zijn, ok�?

When I checked the encoding with Notepad++:
Manual: ANSI
with MP-TVseries: UTF-8 with BOM

Concluding, Bierdopje has different encoded subtitles (now ANSI instead of UTF-8) and this goes wrong in the bierdopje API. 'Funny' is that the manual download don't give any problems.

I try to contact bierdopje (API) - team

edit: made an issue: Issue 3 - bierdopjeapi - Encoding problem (ANSI-UTF8) - An C# wrapper of the Bierdopje API - Google Project Hosting


UPDATE
I'm now confused: when debugging the bierdopjeApi code in Visual Studio there is no problem. The problem cannot be reproduced with only the code, so
- manual download from bierdopje.com: OK
- download with code in Visual Studio: OK
- download with MP-TVseries: encoding problem.

I assumed that the encoding problem was of problem of bierdopjeApi because:
- The bierdopjeApi downloads really the file
- With the update of bierdopjeApi in subtitleDownloader 2.7 the 'family guy'-problem is solved
- I assumed no component alters the file after download.

Anyway, I'm not sure where the problem is located: bierdopjeApi, SubtitleDownloader or MP-tvseries. Please keep in mind that I don't want to blame anyone, I just want to solve the problem and let MP rock!

I need to do some more investigation, but there is no time before the weekend now.

Please try the attached DLL and report back

EDIT: Download removed

 

[DuckTest]

Re: SubtitleDownloader 2.7

Please try the attached DLL and report back

I tried the two testcases double and both are successful Also the MD5 hashes compared to the manual download are the same.


Looks like it works prefect know.

I'm curious what changed in the new compiled DLL

PS. give the new DLL a new version number (it's still 2.7 I see) if it gets released - also the file description is stuck tot 2.6
I have seen too much problems with DLL's with the same version number but which were different builds. (on other code projects)

 

[seco]

Re: SubtitleDownloader 2.7

Please try the attached DLL and report back

I tried the two testcases double and both are successful Also the MD5 hashes compared to the manual download are the same.


Looks like it works prefect know.

I'm curious what changed in the new compiled DLL

PS. give the new DLL a new version number (it's still 2.7 I see) if it gets released - also the file description is stuck tot 2.6
I have seen too much problems with DLL's with the same version number but which were different builds. (on other code projects)

Hi,

Thanks for testing. I didn't bump up version yet since this build was only for testing. Please let me know if you have any more problems, otherwise I'll release 2.8 in a few days with this fix.

The problem was in the SubtitleDownloader itself, the implementation doesn't use Bierdopje API's downloading since it doesn't fit my needs, but it's has it's own code for downloading which was faulty. Sorry for the trouble.

 

[DuckTest]

Re: SubtitleDownloader 2.7

Please try the attached DLL and report back

I tried the two testcases double and both are successful Also the MD5 hashes compared to the manual download are the same.


Looks like it works prefect know.

I'm curious what changed in the new compiled DLL

PS. give the new DLL a new version number (it's still 2.7 I see) if it gets released - also the file description is stuck tot 2.6
I have seen too much problems with DLL's with the same version number but which were different builds. (on other code projects)

Hi,

Thanks for testing. I didn't bump up version yet since this build was only for testing. Please let me know if you have any more problems, otherwise I'll release 2.8 in a few days with this fix.

The problem was in the SubtitleDownloader itself, the implementation doesn't use Bierdopje API's downloading since it doesn't fit my needs, but it's has it's own code for downloading which was faulty. Sorry for the trouble.

Just tested some more and didn't found any problems
For the complete picture, in the new versions the Bierdopje API's downloading is also not used?

Thx for changing the code and for the quick replies.

 

[yoavain]

Re: SubtitleDownloader 2.8

Hi,

To all Israelis out there, here's subscenter.org SubtitleDownloader provider for usage in SubCentral.

Links:
Project site
Downloads
Installation And Configuration

I've been doing some testings for Movies & TV Shows and it's faster then most providers (from within Israel).
It will be my first provider of choice from now on

If you have any problem, you know how to reach me,

Take care,
Yoav

 

[seco]

Re: SubtitleDownloader 2.8

Hi,

To all Israelis out there, here's subscenter.org SubtitleDownloader provider for usage in SubCentral.

Links:
Project site
Downloads
Installation And Configuration

I've been doing some testings for Movies & TV Shows and it's faster then most providers (from within Israel).
It will be my first provider of choice from now on

If you have any problem, you know how to reach me,

Take care,
Yoav

Hi Yoav and thanks again for your contribution.

Sorry I missed you at IRC, we will add this in the next version of SubCentral

 

[MrJul]

Re: SubtitleDownloader 2.9

Hello everyone! First of all, this is my first post on this forum. I set up my first HTPC a few days ago, stumbled accross MediaPortal and immediately loved it and its plugins.

Thank you for writing SubCentral and SubtitleDownloader, it will save me so much time in the future After using it, I'll never download my subtitles manually again!

So, here is my first contribution : a subtitle downloader for sous-titres.eu, a high-quality french subtitles website that I frequently use.

The downloader supports series and movies search, is built against SubtitleDownloader 2.9 and was tested on MediaPortal 1.2 beta.

Concerning source control, I know I could have created a Google code, Codeplex or similar project but since the downloader is only a couple of classes, is there any way the source code can be integrated within SubtitleDownloader or do I have to maintain the code separately?

You'll find both the binary and the code attached to this post.
--
Julien

 

[SilentException]

Re: SubtitleDownloader 2.9

Very good first post

I'll integrate the downloader with next version of SubCentral. If you PM me your Google Code username, I will add you as contributor to SubCentral so you can add and update binary in SubCentral SVN. Third party downloader DLL files should go here

You will have to maintain code separately, be it on your computer or some online service.

 

[seco]

Re: SubtitleDownloader 2.9

Hello everyone! First of all, this is my first post on this forum. I set up my first HTPC a few days ago, stumbled accross MediaPortal and immediately loved it and its plugins.

Thank you for writing SubCentral and SubtitleDownloader, it will save me so much time in the future After using it, I'll never download my subtitles manually again!

So, here is my first contribution : a subtitle downloader for sous-titres.eu, a high-quality french subtitles website that I frequently use.

The downloader supports series and movies search, is built against SubtitleDownloader 2.9 and was tested on MediaPortal 1.2 beta.

Concerning source control, I know I could have created a Google code, Codeplex or similar project but since the downloader is only a couple of classes, is there any way the source code can be integrated within SubtitleDownloader or do I have to maintain the code separately?

You'll find both the binary and the code attached to this post.
--
Julien

The code looks very clear and professional, good job

At this point I haven't been integrating 3rd party downloaders to SubtitleDownloader since I probably won't have enough resources to maintain all of them, so at the moment they are under author's responsibility.