switch to a new logging framework (Log4Net) (1 Viewer)

[elliottmc]

Hi, when is set for merge ?

When it is tested and ready. For that we need comment from @Bavarian.

 

[Bavarian]

For my point of view, it is tested and ready to merge.

 

[elliottmc]

For my point of view, it is tested and ready to merge.

Is it just the one mantis entry?

- 0003273: [general] switch to a new logging framework C# Side (Bavarian) - ready for testing.

 

[HomeY]

OK, Mantis set to 'Merge pending'. Will you do the merge yourself @Bavarian ?

 

[Bavarian]

I am a git newbie - can somebody give me a helping hand?

 

[Sebastiii]

Sure

 

[Sebastiii]

Done https://github.com/MediaPortal/MediaPortal-1/commit/7706a04def9fb08ca4b88b103a13534c20026f74

 

[tourettes]

Done https://github.com/MediaPortal/MediaPortal-1/commit/7706a04def9fb08ca4b88b103a13534c20026f74

Please tell me that we aren't adding stuff like log engine changes on RC releases. The world must have gone insane if this is happening...

 

[Sebastiii]

Yeah i think i surely too happy today for the new year and follow this branch to be tested and have good report but in final it's a feature and you are right, we shouldn't commit in RC phase.

It's not too late to revert it but make ugly master log.

I would like to help Bavarian about GIT Stuff and was happy to help for sure.

The good point is that all is working correctly and next time i will follow my intuition.

 

[elliottmc]

So, what do we do?

It does seem to be working okay, but my gut is telling me that there is too much chance of a problem, and if the problem means that we don't get logging when we should, it's going to make finding other problems even harder.

If we are going to follow our new development model, then reverting this and putting it into 1.4.0, as we had intended, is not so bad.

I think that is what we have to do.

That certainly doesn't mean that I don't appreciate the efforts of you and @Bavarian, but this is just too much of a risk for a RC.

Mark