switch to a new logging framework (Log4Net) (4 Viewers)

[Sebastiii]

Need to be tested for sure but original branch was really old (april if i'm not wrong) or it was not the branch to take ?

 

[elliottmc]

In the original branch

https://github.com/MediaPortal/MediaPortal-1/commits/FEAT-3273-Switch_to_log4net

we only have four commits changing a total of 18 files. The new branch changes 4940 files. I think it is fair to say something is definitely wrong.

Is it possible to see how the four specific commits in the previous branch apply to master?

 

[elliottmc]

Here are the four patches. I am about to see if they still apply fine to current master.

These merge fine, so perhaps we need a new GIT branch from the patches. Let me test first!

 

[elliottmc]

Tested with these patches and all seems fine. Just need a GIT branch from these (and the other two branches deleting I guess - maybe not the original in case I have screwed up!).

 

[Sebastiii]

The big change is because i merge master to log4net branch to make it up to date, so if we merge that new branch into master, only above 18 files will be changed (if i'm not wrong)

 

[Sebastiii]

Mark

In order to have a proper log, patching only with your files into a new branch will be cleaner i think

 

[Sebastiii]

This is the new branch witch include only latest commit from @Bavarian :
https://github.com/MediaPortal/MediaPortal-1/tree/FEAT-3273-Switch_to_log4net_Cleaner

Bavarian, can you look if only 4 path are ok (i think it's ok too but when i looking in history log we have more commit).
Thanks Guys

 

[elliottmc]

This is the new branch witch include only latest commit from @Bavarian :
https://github.com/MediaPortal/MediaPortal-1/tree/FEAT-3273-Switch_to_log4net_Cleaner

Bavarian, can you look if only 4 path are ok (i think it's ok too but when i looking in history log we have more commit).
Thanks Guys

Bavarian hasn't been around since 20th Feb.

However, I can confirm that with these 4 patches, it seems to be working! The GIT history suggests that the first of these really is the first, so we haven't missed anything before it.

 

[vuego]

Here is the Wiki page. I hope all is correct.

 

[elliottmc]

Here is the Wiki page. I hope all is correct.

Thanks. Much better than my original version.