switch to a new logging framework (Log4Net) (5 Viewers)

[elliottmc]

Please decide next time first and then push the start trigger!

I did. I scheduled it in mantis for 1.4.0. Then you said you consider this ready for merge, and Homey and Seb got a bit excited.

Sorry Manfred, i forgot that the Train model will take affect as of MP v1.4 and since i tested this a long time ago (as did others) and you agreed it was tested enough, i thought we were good.

My bad!!

The train model will take affect as of MP 1.4, but we are still developing MP 1.3

 

[HomeY]

We also need Docs for this rework.

 

[elliottmc]

Bump. Can we confirm that enough people have tested this? Do we have docs - essential before this can be merged.

Edit: cannot test this since Tortoise GIT thinks it is already merged, so I can't merge it again.

 

[Holzi]

Bump. Can we confirm that enough people have tested this? Do we have docs - essential before this can be merged.

Edit: cannot test this since Tortoise GIT thinks it is already merged, so I can't merge it again.

@Bavarian already said that it is good to go from his point of view and I doubt we get much more testers on this one.
What needs to be documented?

 

[elliottmc]

Bump. Can we confirm that enough people have tested this? Do we have docs - essential before this can be merged.

Edit: cannot test this since Tortoise GIT thinks it is already merged, so I can't merge it again.

@Bavarian already said that it is good to go from his point of view and I doubt we get much more testers on this one.
What needs to be documented?

Not sure. Is the logging rotatable? Do developers need to change their code for this (I assume not).

Bavarian hasn't been on the forum since 20th Feb, so I am not sure whether we will get a comment on this.

 

[elliottmc]

And can someone fix the

https://github.com/MediaPortal/MediaPortal-1/tree/FEAT-3273-Switch_to_log4net

branch so that it can be merged? Right now, I can't merge it to master because it was merged and then reverted, so when I try to merge locally it tells me it is already merged!

Thanks,

Mark

 

[Holzi]

@Developers ?!

 

[Sebastiii]

lol

I will try do it (i'm working on it actually lol) i will create a new branch to keep old one intact

 

[Sebastiii]

Updated branch : https://github.com/MediaPortal/MediaPortal-1/tree/FEAT-3273-Switch_to_log4net_update

 

[elliottmc]

Updated branch : https://github.com/MediaPortal/MediaPortal-1/tree/FEAT-3273-Switch_to_log4net_update

Are you sure this is right? Seem to be a lot of skin and filter changes when merging to master.