switch to a new logging framework (Log4Net) (1 Viewer)

Sebastiii

Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Need to be tested for sure :) but original branch was really old (april if i'm not wrong) or it was not the branch to take ?
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    Here are the four patches. I am about to see if they still apply fine to current master.

    These merge fine, so perhaps we need a new GIT branch from the patches. Let me test first!
     

    Attachments

    • 0001-First-implementation-with-Common-Logger-in-Common-MP.patch
      38.2 KB
    • 0002-adding-Log4netWrapper.patch
      3.7 KB
    • 0003-fix-TVLib-logger-path-issue.patch
      2.4 KB
    • 0004-Fixing-Path.Combine-issue.patch
      1.9 KB

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    Tested with these patches and all seems fine. Just need a GIT branch from these (and the other two branches deleting I guess - maybe not the original in case I have screwed up!).
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    The big change is because i merge master to log4net branch to make it up to date, so if we merge that new branch into master, only above 18 files will be changed (if i'm not wrong) :)
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    This is the new branch witch include only latest commit from @Bavarian :
    https://github.com/MediaPortal/MediaPortal-1/tree/FEAT-3273-Switch_to_log4net_Cleaner

    Bavarian, can you look if only 4 path are ok (i think it's ok too but when i looking in history log we have more commit).
    Thanks Guys :)


    Bavarian hasn't been around since 20th Feb. :(

    However, I can confirm that with these 4 patches, it seems to be working! The GIT history suggests that the first of these really is the first, so we haven't missed anything before it.
     

    Users who are viewing this thread

    Top Bottom