Thumbnail generation - design problem: thumbnails are almost same and not very informative. (1 Viewer)

tourettes

Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    And here are the logs from the thumbs attempt last night ;)
    First thumb has a timestamp of 20:36 and the last 1 was made @ 00:57
    that's 4,5 hours for 122 high quality 2x2 thumbs (and that covers all recordings), with a total size of 39,3 MB.

    Pretty horrible results. We cannot spend more than few seconds per video file when generating thumbnails, anything longer than that is just too long. Based on the results it is now around 2 minutes per thumbnail. Not acceptable in any way.
     

    regeszter

    Retired Team Member
  • Premium Supporter
  • October 29, 2005
    5,335
    4,954
    Home Country
    Hungary Hungary
    And here are the logs from the thumbs attempt last night ;)
    First thumb has a timestamp of 20:36 and the last 1 was made @ 00:57
    that's 4,5 hours for 122 high quality 2x2 thumbs (and that covers all recordings), with a total size of 39,3 MB.

    Pretty horrible results. We cannot spend more than few seconds per video file when generating thumbnails, anything longer than that is just too long. Based on the results it is now around 2 minutes per thumbnail. Not acceptable in any way.

    I made some rework. Pls test it. I have not finished yet (1 x 2 and 2 x 1 not like me) but you can test the speed of the generation (1 x 1 and 2 x 2).

    Edit: updated binaries (1 x 2 and 2 x 1 is good now).
     

    Attachments

    • MP_1.4.0_thumb_patchV3d.zip
      2.8 MB
    Last edited:

    regeszter

    Retired Team Member
  • Premium Supporter
  • October 29, 2005
    5,335
    4,954
    Home Country
    Hungary Hungary
    @Sebastiii

    pls. update the branch with attached file.

    If the 1st impression is good, I will rework the tvserver too. ;)

    Thanks.
     

    Attachments

    • MP_1.4.0_thumb_patchV3d source.zip
      35.2 KB

    HomeY

    Test Group
  • Team MediaPortal
  • February 23, 2008
    6,475
    4,645
    49
    ::1
    Home Country
    Netherlands Netherlands
    I made some rework. Pls test it. I have not finished yet (1 x 2 and 2 x 1 not like me) but you can test the speed of the generation (1 x 1 and 2 x 2).

    Tested, and speeds is a lot better now. I noticed that my 4:3 recordings often show a lot of pixelation on the thumb:
    Pixelation.PNG

    And what also bothers me (but that's not related to this rework) is the layout of the thumbs.... How can a 16:9 recording show thumbs that have a bigger hight then width... :(
    12-01-34.png
     

    HomeY

    Test Group
  • Team MediaPortal
  • February 23, 2008
    6,475
    4,645
    49
    ::1
    Home Country
    Netherlands Netherlands
    I think it´s because the size for the image shown is fixed in skin xml ;)
    Would be better to add <keepaspectratio>yes</keepaspectratio> to that image control ;)

    @ncoH could this be improved?
     

    regeszter

    Retired Team Member
  • Premium Supporter
  • October 29, 2005
    5,335
    4,954
    Home Country
    Hungary Hungary
    Tested, and speeds is a lot better now.

    Your log showes:

    [2013-07-20 11:54:21,937] [Log ] [16 ] [INFO ] - MediaInfoWrapper.MediaInfoWrapper: Inspecting media : \\SERVER\TV_Opnames\Buch In De Bajes - RTL 4 HD - 2013-07-18.ts
    ...Deleted....

    [2013-07-20 11:54:21,940] [Log ] [16 ] [DEBUG] - \\SERVER\TV_Opnames\Buch In De Bajes - RTL 4 HD - 2013-07-18.ts duration is 2955.
    [2013-07-20 11:54:21,940] [Log ] [16 ] [DEBUG] - VideoThumbCreator: No thumb in share \\SERVER\TV_Opnames\Buch In De Bajes - RTL 4

    ...Deleted....

    2013-07-20 11:54:25,871] [Log ] [16 ] [DEBUG] - CreateVideoThumbV2: Saving thumb!

    There was 4 seconds a 2x2 thumbnail generation. The pictures were made on 60, 783, 1506, 2229 seconds of the movie. Is it acceptable by developers?
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    It seems each thumbs (2X2) (so 4 pictures) stay in video folder.

    Debugging thingy and i see what happen so the code is not 100% ok (it seems)
    I can reproduce low quality thumb (like Homey) if 'CreateVideoThumbV2' is used (and file should be created correctly.

    It failed to go on 'CreateVideoThumbV2' because of : 'if (i == PreviewColumns * PreviewRows - 1)' (don't know why but will try to see).

    So i can get Good Thumb because MP use : 'Success = Utils.StartProcess(ExtractorPath, ExtractorFallbackArgs, TempPath, 120000, true, GetMtnConditions());'
     

    Users who are viewing this thread

    Top Bottom