TSWriter deadlock potential fix. (2 Viewers)

[Sebastiii]

Is this with the modified files in this thread or from the git branch?

The issue i have seen is not related to this fix
It's related to do quickly stop/start tvservice, i think i have try something on my fork to fix that and seems working.
So sorry about false alarm, i'm running the fix and DVB EPG seems to not trigger TVService crash here

 

[Owlsroost]

In case anyone is interested, this branch - https://github.com/MediaPortal/MediaPortal-1/tree/MP1-EXP_TsWriter_MP15x_Owlsroost - is DJBlu's branch with other recent TsWriter.ax (potential) mods added to it.

Commit message:

"Based on 'BUG-3947-TSWriter-Deadlock-v2' branch, with async logging mods from 'EXP-TsWriter_async_logging', packetSync mods from 'MP1-EXP_TsReader_PacketSync', 'otherMux (0x46)' channel scanning mods from 'MP1-EXP_tvserver_0x46_scan_fixes' and minor Unicode logging fix manually merged into the code. Version resources also added."

I've run this on my test PC today with no problems/regressions, so I'll probably put the latest 1.5.0 release on the main HTPC tomorrow, update it with TVLibrary.dll/TVService.exe/TsWriter.ax built from the branch and give it a proper long-term test

 

[mm1352000]

Tony, do you think we should put the patch from here into that test branch?
https://forum.team-mediaportal.com/threads/dvb-c-radio-not-working.118141/page-5#post-986197

 

[Owlsroost]

Tony, do you think we should put the patch from here into that test branch?
https://forum.team-mediaportal.com/threads/dvb-c-radio-not-working.118141/page-5#post-986197

Good idea - I'd been waiting for some user testing for that patch, but I suspect we're not going to get any in a reasonable timeframe, so yes, we should regression test it anyway. I can probably addit to the branch later today.

 

[Owlsroost]

Tony, do you think we should put the patch from here into that test branch?
https://forum.team-mediaportal.com/threads/dvb-c-radio-not-working.118141/page-5#post-986197

Good idea - I'd been waiting for some user testing for that patch, but I suspect we're not going to get any in a reasonable timeframe, so yes, we should regression test it anyway. I can probably addit to the branch later today.

Done.

 

[Sebastiii]

Tony

You just need to add JIRA issue key in each commit (i know merging older branch will not really work, except if we add it in commit log manually before committing )

Thanks

 

[Owlsroost]

You just need to add JIRA issue key in each commit

No - that's admin, and this is meant to be fun (this is my non-conformist streak popping up ).

I do need to create Jira entries for some of the mods in that branch (not sure if it's worth creating separate branches for those - it would basically just be for code reviews, mostly).

 

[Owlsroost]

I do need to create Jira entries for some of the mods in that branch

Added https://issues.team-mediaportal.com/browse/MP1-4216 and https://issues.team-mediaportal.com/browse/MP1-4217

 

[nimrodel50]

Hi
I've been using the patch since then and no problem appeared.

I'm able to say that the problem I had is gone!!

I'm going to update to the final version tonight any chance to get the patch for that version?

Thanks

 

[doskabouter]

Just updated to 1.5.0, which patch would you want me to test? (kinda lost track of all the patches in this thread)