TSWriter deadlock potential fix. (2 Viewers)

Sebastiii

Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Is this with the modified files in this thread or from the git branch?

    The issue i have seen is not related to this fix :)
    It's related to do quickly stop/start tvservice, i think i have try something on my fork to fix that and seems working.
    So sorry about false alarm, i'm running the fix and DVB EPG seems to not trigger TVService crash here :p
     

    Owlsroost

    Retired Team Member
  • Premium Supporter
  • October 28, 2008
    5,540
    5,038
    Cambridge
    Home Country
    United Kingdom United Kingdom
    In case anyone is interested, this branch - https://github.com/MediaPortal/MediaPortal-1/tree/MP1-EXP_TsWriter_MP15x_Owlsroost - is DJBlu's branch with other recent TsWriter.ax (potential) mods added to it.

    Commit message:

    "Based on 'BUG-3947-TSWriter-Deadlock-v2' branch, with async logging mods from 'EXP-TsWriter_async_logging', packetSync mods from 'MP1-EXP_TsReader_PacketSync', 'otherMux (0x46)' channel scanning mods from 'MP1-EXP_tvserver_0x46_scan_fixes' and minor Unicode logging fix manually merged into the code. Version resources also added."

    I've run this on my test PC today with no problems/regressions, so I'll probably put the latest 1.5.0 release on the main HTPC tomorrow, update it with TVLibrary.dll/TVService.exe/TsWriter.ax built from the branch and give it a proper long-term test :)
     

    Owlsroost

    Retired Team Member
  • Premium Supporter
  • October 28, 2008
    5,540
    5,038
    Cambridge
    Home Country
    United Kingdom United Kingdom

    Owlsroost

    Retired Team Member
  • Premium Supporter
  • October 28, 2008
    5,540
    5,038
    Cambridge
    Home Country
    United Kingdom United Kingdom

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Tony :)

    You just need to add JIRA issue key in each commit (i know merging older branch will not really work, except if we add it in commit log manually before committing :) )

    Thanks :)
     

    Owlsroost

    Retired Team Member
  • Premium Supporter
  • October 28, 2008
    5,540
    5,038
    Cambridge
    Home Country
    United Kingdom United Kingdom
    You just need to add JIRA issue key in each commit

    No - that's admin, and this is meant to be fun (this is my non-conformist streak popping up ;)).

    I do need to create Jira entries for some of the mods in that branch (not sure if it's worth creating separate branches for those - it would basically just be for code reviews, mostly).
     

    nimrodel50

    Portal Pro
    February 6, 2008
    67
    15
    Home Country
    Spain Spain
    Hi
    I've been using the patch since then and no problem appeared.

    I'm able to say that the problem I had is gone!!

    I'm going to update to the final version tonight any chance to get the patch for that version?

    Thanks
     

    doskabouter

    Development Group
  • Team MediaPortal
  • September 27, 2009
    4,566
    2,938
    Nuenen
    Home Country
    Netherlands Netherlands
    Just updated to 1.5.0, which patch would you want me to test? (kinda lost track of all the patches in this thread)
     

    Users who are viewing this thread

    Top Bottom