Update allmusic.com scraper (1 Viewer)

elliottmc

Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    United Kingdom United Kingdom
    Country flag
    @Sebastiii

    I was being serious. If the music scraper has become totally broken, we should consider this a show-stopper and we should try to fix it.

    If this is the case, we need to prioritise testing efforts to ensure that this can be safe to include.
     

    jameson_uk

    Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    United Kingdom United Kingdom
    Country flag
    I tested the new version, and it is an improvement. It found info for 'Beach Boys, The'. But it didn't find the album 'Pet Sounds' by the same group. I'm attaching debug logs.
    Schoolboy error. Should be fixed in v3a in first post
     

    jameson_uk

    Retired Team Member
  • Premium Supporter
  • January 27, 2005
    7,258
    2,528
    Birmingham
    United Kingdom United Kingdom
    Country flag
    I was being serious. If the music scraper has become totally broken, we should consider this a show-stopper and we should try to fix it.

    If this is the case, we need to prioritise testing efforts to ensure that this can be safe to include.
    Is low risk (due to the nature of the web-scraping the current way of doing this is going to break often).
    The only thing I know needs sorting is that there is a NuGet package that is downloaded and we will need to copy this binary in the NSIS installer
     

    catavolt

    Design Group Manager
  • Team MediaPortal
  • August 13, 2007
    12,955
    9,302
    Lanzarote
    Germany Germany
    Country flag
    Thanks Mike, this one looks very good - scraped about 20 albums to test and all got all fields filled (rating, styles, influences etc).
    Nice work - would be a pity if this wouldn´t make it into 1.5 Final (y)
    ***EDIT*** Will now test how it works with your latest MusicInfoHandler :p
     
    Last edited:

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,447
    10,273
    France
    France France
    Country flag
    @Sebastiii

    I was being serious. If the music scraper has become totally broken, we should consider this a show-stopper and we should try to fix it.

    If this is the case, we need to prioritise testing efforts to ensure that this can be safe to include.

    Because it was not ready (from Mike POV) and seem to be a big rework etc.
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    United Kingdom United Kingdom
    Country flag
    @Sebastiii

    I was being serious. If the music scraper has become totally broken, we should consider this a show-stopper and we should try to fix it.

    If this is the case, we need to prioritise testing efforts to ensure that this can be safe to include.

    Because it was not ready (from Mike POV) and seem to be a big rework etc.
    Well, that's partly why I was asking. If Mike says it is not ready then it is definitely not ready. If Mike feels it is ready, and then we can get it tested, it could potentially be ready.

    A big rework in terms of lines of code does not inherently make it risky. If the changes are localised to the scraper, and right now it is 100% broken, then as Mike says, the risk of regression (which isn't the same as saying it is a 100% perfect fix) is low.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,447
    10,273
    France
    France France
    Country flag
    Yep i agree on that but can we sure it will not trigger something ? (I trust Mike on his skill :) )
     

    catavolt

    Design Group Manager
  • Team MediaPortal
  • August 13, 2007
    12,955
    9,302
    Lanzarote
    Germany Germany
    Country flag
    Hi Mike, after testing this further I encountered two bugs:
    1. When using the modified windowsplugins.dll, the topbar items won´t show focussed state (they still work, just do not show the focus image of the control).
    2. The HtmlAgilitypack breaks some plugins, e.g. ScoreCenter ;)
     

    ed76

    MP Donator
  • Premium Supporter
  • August 4, 2012
    170
    14
    40
    Germany Germany
    is it possible to get the updated music scraper for mp1.3? at the moment i cant get any album covers.
     
    Last edited:

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    M.Hulot After Update 1.25 internal blu-ray-player doesn't work General Support 8
    M.Hulot Interner Blu-ray-Player spielt nach Update auf 1.25 keine Discs mehr ab Allgemeines Supportforum 2
    E retaining Watch Status when updating? Newcomers Forum 1
    J Update .NET framework? Improvement Suggestions 9
    G Update von MediaPortal Installationsprobleme? 0
    morpheus_xx [Evaluate] Update to VS 2019? MediaPortal 2 4
    Golf4 Nach Windows-Updates läuft TV-Plugin nicht mehr Allgemeines Support- und Diskussionsforum 0
    B MPEM update list never completes. General Support 0
    JJDoherty Updated DTT frequencies for Ireland... Submit: EPG-Grabbers and tuningdetails 1
    Dark Eyes Updated to Windows 10, now TVServer won't work Installation, configuration support 1
    R [solved] Files moved to new location - Easy way to update database? My TVSeries 7
    M.Hulot Moving Pictures lässt sich nach Windows-Update nicht mehr öffnen Plugins & Erweiterungen 1
    R Files moved to different location - Easy way to update database? Moving Pictures 2
    k12158 [solved] Kein direkter Wechsel von TV-Kanal zu TV-Kanal mehr nach Update? Allgemeines Support- und Diskussionsforum 16
    ajs Mediaportal update to .Net 4.6.2+ MediaPortal 1 13
    Mr6686 [solved] Titan skin broken since update to 1.23 Installation, configuration support 6
    B TV-Server Auto-Update mptvdb after x hours General Support 0
    Terra LAVFilter Plugin cannot be updated (MP1.23) MediaPortal 1 Plugins 10
    TLD Windows 10 1903 feature update General Support 3
    azzuro [WiP] 5043: Update MP1 to VisualStudio 2019 MediaPortal 1 138
    A Problem Windows 10 64 bit prof. Update auf Version 1903(gelöst) Installationsprobleme? 0
    T No TV after updating Windows 10 to latest Version 1903 / OS build 18362.175 (logs attached) General Support 2
    M [solved] Updated Swedish translation for MP 1.24 Submit: Localization of MediaPortal and DeployTool 0
    framug 1.22.0 BasicHome Editor settings for DefaultWide HD skin not kept when update 1.22 3
    Neoculture Bulk file name update My TVSeries 6
    Similar threads

























    Top Bottom