Update allmusic.com scraper | Page 3

Discussion in 'Area 51 - Testing Area' started by jameson_uk, August 4, 2013.

  1. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    @Sebastiii



    I was being serious. If the music scraper has become totally broken, we should consider this a show-stopper and we should try to fix it.

    If this is the case, we need to prioritise testing efforts to ensure that this can be safe to include.
     
    • Agree Agree x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. jameson_uk
    • Premium Supporter

    jameson_uk Retired Team Member

    Joined:
    January 27, 2005
    Messages:
    7,258
    Likes Received:
    2,228
    Gender:
    Male
    Occupation:
    Data Warehousing Consultant
    Location:
    Birmingham
    Ratings:
    +2,405 / 0
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Schoolboy error. Should be fixed in v3a in first post
     
  4. jameson_uk
    • Premium Supporter

    jameson_uk Retired Team Member

    Joined:
    January 27, 2005
    Messages:
    7,258
    Likes Received:
    2,228
    Gender:
    Male
    Occupation:
    Data Warehousing Consultant
    Location:
    Birmingham
    Ratings:
    +2,405 / 0
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Is low risk (due to the nature of the web-scraping the current way of doing this is going to break often).
    The only thing I know needs sorting is that there is a NuGet package that is downloaded and we will need to copy this binary in the NSIS installer
     
    • Like Like x 1
  5. catavolt
    • Team MediaPortal
    • Administrator

    catavolt Design Group Manager

    Joined:
    August 13, 2007
    Messages:
    12,252
    Likes Received:
    4,988
    Gender:
    Male
    Occupation:
    Technical Documentation, Translation
    Location:
    Lanzarote
    Ratings:
    +7,408 / 38
    Home Country:
    Germany Germany
    Show System Specs
    Thanks Mike, this one looks very good - scraped about 20 albums to test and all got all fields filled (rating, styles, influences etc).
    Nice work - would be a pity if this wouldn´t make it into 1.5 Final (y)
    ***EDIT*** Will now test how it works with your latest MusicInfoHandler :p
     
    Last edited: August 18, 2013
    • Agree Agree x 1
  6. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs
    Is there a Jira issue created?
     
    • Like Like x 1
  7. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,269
    Likes Received:
    6,221
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,228 / 9
    Home Country:
    France France
    Show System Specs

    Because it was not ready (from Mike POV) and seem to be a big rework etc.
     
    • Agree Agree x 1
  8. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Well, that's partly why I was asking. If Mike says it is not ready then it is definitely not ready. If Mike feels it is ready, and then we can get it tested, it could potentially be ready.

    A big rework in terms of lines of code does not inherently make it risky. If the changes are localised to the scraper, and right now it is 100% broken, then as Mike says, the risk of regression (which isn't the same as saying it is a 100% perfect fix) is low.
     
  9. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,269
    Likes Received:
    6,221
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,228 / 9
    Home Country:
    France France
    Show System Specs
    Yep i agree on that but can we sure it will not trigger something ? (I trust Mike on his skill :) )
     
  10. catavolt
    • Team MediaPortal
    • Administrator

    catavolt Design Group Manager

    Joined:
    August 13, 2007
    Messages:
    12,252
    Likes Received:
    4,988
    Gender:
    Male
    Occupation:
    Technical Documentation, Translation
    Location:
    Lanzarote
    Ratings:
    +7,408 / 38
    Home Country:
    Germany Germany
    Show System Specs
    Hi Mike, after testing this further I encountered two bugs:
    1. When using the modified windowsplugins.dll, the topbar items won´t show focussed state (they still work, just do not show the focus image of the control).
    2. The HtmlAgilitypack breaks some plugins, e.g. ScoreCenter ;)
     
  11. ed76
    • Premium Supporter

    ed76 MP Donator

    Joined:
    August 4, 2012
    Messages:
    170
    Likes Received:
    7
    Gender:
    Male
    Ratings:
    +14 / 3
    Home Country:
    Germany Germany
    is it possible to get the updated music scraper for mp1.3? at the moment i cant get any album covers.
     
    Last edited: August 19, 2013
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!