Vista and EVR support (2 Viewers)

[Eabin]

ok, so someone else already did the dynamic loading for me. thanks
i removed the dependecy on mf.dll, so evr should work on XP to now (without acceleration that is).

as i said, i did some work on aspect ratio. if you have troubles with AR after the attached files have been committed, please let me know in this thread, and - if possible - provide a video which does not work correctly, so i can test and fix it.


frodo: please commit the attached changes.

 

[Frodo]

Looking good to me;-)
Its in SVN at the moment

Are your also planning to make exclusive mode to work with EVR??

Frodo

 

[Eabin]

i am, but it is not an important point on my todo list, since i don't see any tearing (i think this is because of vista's aero).

the list is looking something like this (ordered by importance):
*) fixing bugs that get reported here
*) switch scheduler to high resolution multimedia timer, for smoother playback and less (hopefully: none) skipped frames.
*) better media-type negotiation (at the moment i create a default D3D-surface, which may lead to black screens for some, but nobody provided any logs so far, so i will stick to documentation)
*) things i haven't thought of yet, like exclusive mode support.

comments and suggestions are always welcome.

btw: have you tried it on XP?

 

[ziphnor]

comments and suggestions are always welcome.

First off, nice work.

Secondly, i noticed that the frame grabbing functionality that i use for capturing video frames for the autocropper doesnt work when EVR playback is used.

What i do is take the surface handed to PresentSurface in PlaneScene.cs and hand that over to the OnFrame method in FrameGrabber.cs. In there i call a helper method "VideoSurfaceToRGBSurface" in DXUtil.dll to convert the surface to an RGB surface from which a bitmap can be obtained.

The source for that method is:

VideoSurfaceToRGBSurface(IDirect3DSurface9* source, IDirect3DSurface9* dest)
{
IDirect3DDevice9* device = NULL;
HRESULT hr = source->GetDevice(&device);
if(!FAILED(hr)){
hr = device->StretchRect(source,NULL,dest,NULL,D3DTEXF_NONE);
}
return hr;
}

When in EVR mode this call fails returning D3DERR_INVALIDCALL. Is there something special about the surface that gets handed to PresentSurface when using EVR compared to VMR9?

 

[tourettes]

Looking good to me;-)
Its in SVN at the moment

Are your also planning to make exclusive mode to work with EVR??

Frodo

To my knowledge there isn't any need for the exclusive mode with EVR (it's one of it's new 'features'). Full screen and windowed modes should be both tear free automatically.

 

[tourettes]

One Vista EVR related update: http://support.microsoft.com/kb/935878

 

[Eabin]

Looking good to me;-)
Its in SVN at the moment

Are your also planning to make exclusive mode to work with EVR??

Frodo

To my knowledge there isn't any need for the exclusive mode with EVR (it's one of it's new 'features'). Full screen and windowed modes should be both tear free automatically.

i would say, that depends on how you use EVR. the default presenter is tear-free by design, but as MP does it's own D3D rendering, it may very well result in tearing. AERO-drawn windows are again synchronized to v-blank automatically by default, so with AERO --> no tearing. if you turn it off, there should be tearing again in MP (note to self: try this yourself, and say the word tearing a thousand times for using it in every single sentence...).

edit: there are a few methods how one can tweak the presentation scheduler to get a tear-free experience, which i plan to have a look at sooner or later.

 

[Frodo]

i'm running evr/mp on vista (with areo) and i do see tearing

Frodo

 

[tourettes]

i'm running evr/mp on vista (with areo) and i do see tearing

Frodo

Do you have v-sync enabled in the driver config? (I'm just guessing, as I haven't even installed Vista yet.)

 

[spuck]

Well I've got v-sync enabled and I get a lot of tearing, same with the MPC mod with EVR. Well with Direct3D Fullscreen option tearing disappears.

A question. Can EVR do Video->PC levels? That'd be a neat option in configuration.