[Finished] Weather - Temperature in Celsius (2 Viewers)

[octessence]

The weather plugin supplied by default does not provide a configuration option to show the temperature in Celsius. It would be nice for us non-Americans.

 

[chefkoch]

The weather plugin supplied by default does not provide a configuration option to show the temperature in Celsius. It would be nice for us non-Americans.

This is already working, but:

It depends on your localization settings in windows, whether it is displayed in Celsius or Fahrenheit.
Please check you system's control panel: (the screenshots are from German OS, hope it still helps)

Without changing anything in the system's control panel you should configure you Culture / Region within the MP2 settings by setting the correct language, see my example:

• My system's default culture is German (Germany)
  Weather is display in °C
  
  
• MP2 uses by default the system's culture:
  
  
• Now let's change the culture to English (USA)
  
  
• Tada, what a magic.
  
  

This is a great example that it is not necessary to reinvent the wheel over and over again and having a setting for every small part of an application.
This is the MP2 way of doing things
The locale defined in MP2 is reused for the language / translations and for the measuring units.
If this is a non-US, metric culture you'll get Celsius.

I assume for 99.98 % of all users this is perfectly fine. And for the other 0.02% we have to say sorry, but this simplifies the configuration and the code for a default plugin. Nevertheless, if a developer would like to implement such additional customizations, it is no problem to fork the weather plugin and release it as an additional community plugin Weather++ or something like that


For the relevant code see:
https://github.com/MediaPortal/Medi...er/Grabbers/WorldWeatherOnlineCatcher.cs#L238
https://github.com/MediaPortal/Medi...er/Grabbers/WorldWeatherOnlineCatcher.cs#L317

I added this to the todo list for documentation in wiki.

 

[octessence]

Thanks. My locale setting were already set to Metric and I still saw Fahrenheit. Only changing the language to English (United Kingdom) made it change to Celsius.

Associating what is seen to the system locale makes perfect sense however associating it to the language setting makes no sense at all. In the UK there are plenty of people who still think in imperial but that has nothing to do with the language they speak.

EDIT:
If the "Language" page in the MP2 settings was called something more general like "Locale" it would be obvious but having a language option that also controls other things is misleading.

 

[chefkoch]

EDIT:
If the "Language" page in the MP2 settings was called something more general like "Locale" it would be obvious but having a language option that also controls other things is misleading.

I fully agree with you and will add this to the todo list as well. I'll report the link here when I added it to the issue tracker. This also might needs some general planning / discussion for what the locale is / could be used as well.

Nevertheless thanks for reporting this

 

[jpichie]

Sorry to bring this back up, I was looking for an answer for this today.
I will make that change, but why not just have a celsius/fahrenheit changer under the weather module config?

 

[morpheus_xx]

Sorry to bring this back up, I was looking for an answer for this today.
I will make that change, but why not just have a celsius/fahrenheit changer under the weather module config?

There are many places where a regional setting is used inside MP2. It would not be consistent to change only °C/°F for this special case.
So selecting your region is all you need actually.

 

[octessence]

My only issue was that the option said it was for language only and it wasn't clear that this also controlled region.

 

[morpheus_xx]

Ok, we consider a clearer message. Thanks for your input!

 

[jpichie]

Thanks for the info @morpheus_xx I am just thinking back to other weather apps, and they all have the option to change from celcius to fahrenheit and vice-versa regardless of region.