Winamp Visualisations. Finally :-) (2 Viewers)

[Sebastiii]

Can you supply a patch ?
Thanks

 

[CypherMK]

Can you supply a patch ?
Thanks

Who? Me? No skills for that.

 

[Sebastiii]

lol sorry, it was for @BassFan

 

[rich76]

Just been trying the new files and got to say how impressed I am and that it all works great.

Sorry if this has already been asked within the 55 pages but isthere anyway to change the visualisations within mediaportal to save quiting and going to the mediaportal configuration everytime? Also anyway to change between the different presets for milkdrop within mediaportal too?

TIA

Rich

 

[BassFan]

@BassFan

Logs attached.

I started Mediaportal
Put HTPC in standby.
Resumed.
Played music (The Who) and turned on winamp vis
no issue, stopped playback

Liebe Forumsmitglieder
Ich bin kein Mitglied der MP Developergruppe.
Von meiner seite her wurde alles getan um die visualisierungen unter MP wieder funktionstüchtig zu machen,
Ich kann aber sagen das die Visualisierungen so wie im Quelltext gesehen niemals beendet sondern lediglich in den Hintergrund verschoben werden.
Das führt dazu das beim hochfahren aus dem Ruhezustand ein schwarzer Bildschirm erscheint.
Das müssen aber die Developer von MP in Ordnung bringen.
--------------------------------------------
google translator.
Dear forum members
I am not a member of the MP Developers group.
From my side and pushed everything was done to the visualization of MP to make functional again,
But I can say that the visualizations are seen as the source never ended but only moved to the background.
This leads to a black screen that appears when you boot up from hibernation.
But the need to bring the developer of MP in order.

Can you supply a patch ?
Thanks

i can not supply a patch only upload the Files which are changed.. is that enough?
or your mean this Visualization.patch? please check is corrected
ADDED: The new and changed files

Just been trying the new files and got to say how impressed I am and that it all works great.
Also anyway to change between the different presets for milkdrop within mediaportal too?
Rich

That would be possible.
If the developer of MP three keys (A, S, D) provide for the visualization.
previous / random / next preset
then you can switch the presets manually.

function are simple

  if (mVisParam.VisHandle <> 0) and (mVisParam.Kind = BASSVISKIND_WINAMP) then
	BASSVIS_WINAMP_VisButtonClicked(@mVisParam, presFlag);

presFlag.. one of this..
BASS_VIS_BUTTON_PREV; BASS_VIS_BUTTON_RANDOM and BASS_VIS_BUTTON_NEXT


greets

 

[CypherMK]

Thanks for answering. Let's hope some developer can fix this! Maybe @hwahrmann?

 

[BassFan]

Thanks for answering. Let's hope some developer can fix this! Maybe @hwahrmann?

should fix from a developer which work on hibernation (GUI related)
Also when go to hibernation then the Vis should close(not hide)... after back Vis should create.

greets

 

[Sebastiii]

i have found the mistake in MP
now i have a other
speed of song with wasapi after activate visualization is verry fast.

i hope i can fix it. ( i can )
i think i will send a update this night Wasapi should work now..
debug million of lines is a hard job

greets

Big Thanks
I know that debugging take really hours and really thanks again
I have created a branch based on your rework (https://github.com/MediaPortal/MediaPortal-1/tree/MP1-4091-Bass_Visualisations_Fix) hope @hwahrmann can look at it soon

I have change a little space (VS for MP should be set to 2 tab or something, i will try to find where is explain on wiki) but except that your patch is 1:1 with the branch

 

[Sebastiii]

The wiki link : http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/18_Contribute/4_Development/Coding_Standards ( IMPORTANT: Indentation section )

 

[CypherMK]

should fix from a developer which work on hibernation (GUI related)
Also when go to hibernation then the Vis should close(not hide)... after back Vis should create.

greets

@Sebastiii any suggestions who could do this?