Winamp Visualisations. Finally :-) (2 Viewers)

Sebastiii

Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    I would say @Scythe42 but he is busy :) so i don't really know maybe i could try but i can't for now (vacation) and debugging is tricky :)
     
    Last edited:
    B

    BassFan

    Guest
    I have created a branch based on your rework (https://github.com/MediaPortal/MediaPortal-1/tree/MP1-4091-Bass_Visualisations_Fix) hope @hwahrmann can look at it soon :)

    I have change a little space (VS for MP should be set to 2 tab or something, i will try to find where is explain on wiki) but except that your patch is 1:1 with the branch :)

    thanks .. this should help Helmut ..

    I have change a little space
    no problem ..
    i use VS2012 not configure the space (this is in 2012) 4 tabs.
    i will change the tab for the future ;)

    other mistake should fixed..
    • 1. from fullcreeen to Windowmode visualization not resize
    • 2. from Windowmode to MiniTV mode visualization not resize
    • 3. fix hibernation and stand-by problem
    • 4. Window or MiniTV-mode should have a fixed size of 4:3 or all OpenGL Visualization are shown wrong dimension
    this is all GUI related.

    Ideas/Tips:
    • add: a toggle Key left STRG: for VisualisationWindow (enable/disable the Window) so user can configuration the Plugin over mouse or Key Input from Plugin Window (not Visualisation or MP Window) this is recommend for Winamp, BassBox or Sonique Plugins is in running mode.
    • add: tree Key A/S/D for change presets on the fly or Randomize for VisualisationWindow. (used by AVS and Milk2)
    See
    BASS_VIS_BUTTON


    The problems were then solved visualizations should be fine

    greets
     
    Last edited by a moderator:

    Guzzi

    Retired Team Member
  • Premium Supporter
  • August 20, 2007
    2,161
    747
    I would say Scythe42 but he is busy :) so i don't really know maybe i could try but i can't for now (vacation) and debugging is tricky :)
    Hi Sebastii,
    just to throw in some ideas ...

    Register to powermode changed events:
    Code:
    Microsoft.Win32.SystemEvents.PowerModeChanged += new Microsoft.Win32.PowerModeChangedEventHandler(SystemEvents_PowerModeChanged);

    Implement required action:
    Code:
    	void SystemEvents_PowerModeChanged(object sender, Microsoft.Win32.PowerModeChangedEventArgs e)
    	{
    	  switch (e.Mode)
    	  {
    		case Microsoft.Win32.PowerModes.Resume:
    		  {
    			RestartVis();
    		  }
    		  break;
    		case Microsoft.Win32.PowerModes.Suspend:
    		  {
    			StopVis();
    		  }
    		  break;
    		default:
    		  Log.Debug("Unhandled PowerModeChanged event ...");
    		  break;
    	  }
    	}
     
    Last edited:
    B

    BassFan

    Guest
    Can anyone tell whether the visualization works with Asio anyone?
    I still have time to change something.

    greets
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    I can't really test (not @home) and limited connection, but for wasapi it seems working :) (even cpu usage is high on my laptop lol)
     
    B

    BassFan

    Guest
    I can't really test (not @home) and limited connection, but for wasapi it seems working :) (even cpu usage is high on my laptop lol)

    all OpenGL Plugin like BassBox used GPU
    Milk2 Fullscreen 1920x1200 by me 25% > 35% (Core2 Quad Q9650) 3Ghz
    I think that is acceptable ;)

    Sonique:
    Higher resolution rendering provides better image quality and uses more CPU power.

    On the other hand:
    My Media Player uses only 10% CPU.. with the same files used in MP (BassVis.. vis_Milk2)
    no full screen but with television.
    But I do not use DirectX :rolleyes:

    the question also is why
    'mscorwks.dll!CreateApplicationContext' used to many CPU ?

    greets
     
    Last edited by a moderator:
    B

    BassFan

    Guest
    Ich habe nun nach dem Fehler wegen der hohen CPU auslastung gesucht.
    Es hat nichts mit irgendeiner art der Visualisierung zu tun
    Warum nicht?
    Ich habe alle zugriffe auf Bassvis gesperrt
    So das nur noch der Renderthread aktiv ist ohne das irgend ein Plugin gestartet wurde.
    Ohne das irgendein Plugin läuft verwendet der RunRenderThread 25-30% CPU
    Irgend etwas stimmt hier nicht

    Deshalb stelle ich mir erneut die Frage
    Warum verwendet die mscorwks.dll soviele CPU Resourcen ohne das der Thread
    etwas tut?
    --------------------------------------------------
    Now I have to search for the error due to the high CPU utilization
    It has nothing to do with any kind of visualization
    Why not you?
    I have blocked all accesses to Bassvis
    So that's only the render thread running without any plugin was started
    Without any plugin runs the RunRenderThread used 25-30% CPU
    Something is wrong here

    Therefore, I ask myself the question again
    Why does the mscorwks.dll as many CPU resources without the thread
    do something?

    greets
     

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    Therefore, I ask myself the question again
    Why does the mscorwks.dll as many CPU resources without the thread
    do something?

    Probably because the visualization code in MP1 is pretty horrible. It is done completely wrong and should be re-written, but it is not on high priority (no one is currently even planning to do so to my knowledge).
     

    Users who are viewing this thread

    Top Bottom