Comskip Markers in Timeline (2 Viewers)

[mattjcurry]

Hey Everyone,

I just wanted to get some additional feedback from everyone on a feature I am hoping makes it into the next release.

It shows markers on the tv progress bar.

Here is the thread:
https://forum.team-mediaportal.com/threads/show-comskip-markers-in-timeline.105894/

Here is the mantis link:
http://mantis.team-mediaportal.com/view.php?id=3853

Here is the github link for the branch to pull the changes:
https://github.com/MediaPortal/MediaPortal-1/tree/FEAT-3853-Show_Comskip_Markers_in_Timeline

I am kind of new at this, so please let me know if there is any additional information that I need to provide, or if you guys need me to provide the Skin files and DLL binaries.

Thanks,
Matt

--
Adding Binaries for 1.3.0Alpha
-----
Updating Zip file to most current binaries. Sorry for the mistake.

 

[Holzi]

It would be nice to have the skinfiles for DefaultWide + DLL binaries based on the MP 1.3.0 Alpha release.
Thanks!

 

[HomeY]

Hi Matt,

Just tried to test your Comskip Markers but as soon as i open the plugin section in MP Config, i'm getting an error on Dialogs.dll

View attachment 107406 Error log attached.

I also noticed that your TvPlugin.dll is 12KB smaller than the version which comes with 1.3Alpha release, but the problem seems to be your Core.dll

 

[mattjcurry]

OK, the binaries are built off of a build I had on my machine from a couple weeks ago.

It sounds like I need to go ahead and rebuild. I will do that tonight and do some more thorough testing to make sure that you do not run into any issues.

 

[Holzi]

Problem is that current master branch is not MP 1.3.0 Alpha release branch..

 

[HomeY]

Problem is that current master branch is not MP 1.3.0 Alpha release branch..

But we still have the '1.3.0Alpha_final' branch, right?

 

[Holzi]

Problem is that current master branch is not MP 1.3.0 Alpha release branch..

But we still have the '1.3.0Alpha_final' branch, right?

Have we? I don't know..

Did a quick search and don't find it.. anyway maybe it is best to build on current master.. the .dll version just has to be the same as MP 1.3.0 Alpha release version so that people don't get any compatibility issues while testing.

 

[HomeY]

Yes, we do

 

[mattjcurry]

There is a Release_1.3.0_Alpha tag. I can rebase against that and do a fresh build. I do not anticipate having any merge conflicts, so it should be easy breezy.

Matt

 

[Holzi]

Thank you very much!