[Videos] - Comskip Timeline | Page 2

Discussion in 'Improvement Suggestions' started by dareh, July 30, 2009.

  1. mattjcurry
    • Team MediaPortal

    mattjcurry Development Group

    Joined:
    October 24, 2011
    Messages:
    261
    Likes Received:
    195
    Ratings:
    +226 / 0
    I started working on this patch. I am looking for an answer to a couple questions:
    https://forum.team-mediaportal.com/...ection-guipropertymanager-setproperty-103459/

    https://forum.team-mediaportal.com/...st-here-48/question-about-g_player-cs-103447/



    If any developers has a couple seconds to answer those then it would be really helpful, otherwise, I am just going to give it my best shot.

    I think that there are a couple things that need to be done.

    1.) I need to make the jump points accessible via a getter method
    2.) need to pass jump points and chapters to the skin
    3.) need to have an option in the skin for a texture for commercials.
    4.) update GUITVProgressControl to render the new texture for any given jump points.
     
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. mattjcurry
    • Team MediaPortal

    mattjcurry Development Group

    Joined:
    October 24, 2011
    Messages:
    261
    Likes Received:
    195
    Ratings:
    +226 / 0
    Hey Guys,

    I finally got around to getting to spend a couple hours on this. The coding was actually not bad. I have working code in my Git Trunk, so I just need to work with the Devs to try to get it into the main repo.

    Feedback is welcome...
    The skin config looks like this - For the jump texture I used the existing orange image, but you could use anything:
    Code (Text):
    1. <control>
    2.       <description>TV Progress Bar</description>
    3.       <type>tvcomskipprogress</type>
    4.       <id>1</id>
    5.       <posX>90</posX>
    6.       <posY>484</posY>
    7.       <width>362</width>
    8.       <height>16</height>
    9.       <toptexture>osd_progress_indicator.png</toptexture>
    10.       <TextureOffsetY>17</TextureOffsetY>
    11.       <bottomtexture>-</bottomtexture>
    12.       <texturetick>-</texturetick>
    13.       <lefttexture>-</lefttexture>
    14.       <midtexture>-</midtexture>
    15.       <righttexture>-</righttexture>
    16.       <logotexture>-</logotexture>
    17.       <fillbackgroundtexture>-</fillbackgroundtexture>
    18.       <fillbgxoff>0</fillbgxoff>
    19.       <fillbgyoff>0</fillbgyoff>
    20.       <filltexture1>osd_progress_mid_red.png</filltexture1>
    21.       <filltexture2>osd_progress_mid.png</filltexture2>
    22.       <filltexture3>osd_progress_mid_orange.png</filltexture3>
    23.       <jumptexture>osd_progress_mid_orange.png</jumptexture>
    24.       <fillheight>16</fillheight>
    25.       <label>#TV.Record.percent1</label>
    26.       <label1>#TV.Record.percent2</label1>
    27.       <label2>#TV.Record.percent3</label2>
    28.       <labeljumppoints>#TV.Record.jumppoints</labeljumppoints>
    29.       <labelchapters>#TV.Record.chapters</labelchapters>
    30.       <startlabel />
    31.       <endlabel />
    32.       <toplabel />
    33.       <font>font10</font>
    34.       <textcolor>FFffffff</textcolor>
    35.       <visible>!control.hasfocus(1237)</visible>
    36.     </control>
     

    Attached Files:

    • Like Like x 2
  4. mbuzina
    • Premium Supporter

    mbuzina Retired Team Member

    Joined:
    April 11, 2005
    Messages:
    2,839
    Likes Received:
    627
    Location:
    Germany
    Ratings:
    +723 / 4
    Home Country:
    Germany Germany
    Show System Specs
    I am really looking forward to it. If you have a compiled version I can put on my system I wouldn't mind testing (based of 1.2.2).
     
  5. SimondusMaximus
    • Premium Supporter

    SimondusMaximus MP Donator

    Joined:
    December 27, 2009
    Messages:
    171
    Likes Received:
    26
    Gender:
    Male
    Ratings:
    +26 / 0
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    I was wathching recorded TV last night thinking how nice it would be to have ad break markers. And Lo! Here it is the very next morning. Sweet!

    Nice one mattjcurry, looking forward to testing this too. Thank you!
     
  6. mattjcurry
    • Team MediaPortal

    mattjcurry Development Group

    Joined:
    October 24, 2011
    Messages:
    261
    Likes Received:
    195
    Ratings:
    +226 / 0
    Alright, so the files that are attached I think will do it...

    You still have to make the skin edits manually as oulined in the previous post.

    Please let me know if you have any issues with it and I can go ahead and upload additional files if needed.

    Also, if you like the feature, then please like my post here:
    https://forum.team-mediaportal.com/threads/show-comskip-markers-in-timeline.105894/#post-845308

    I am very interested on your impressions on performance. It was hard to guage on my system, but it seemed like the whole OSD gets redrawn on a timer if you leave it open, so there may be a bit of a performance penalty to this enhancement. I am going to post on the developer forum to see if anyone has any ideas.
     

    Attached Files:

    • Like Like x 2
  7. manyakim
    • Premium Supporter

    manyakim MP Donator

    Joined:
    November 20, 2005
    Messages:
    36
    Likes Received:
    9
    Gender:
    Male
    Location:
    Zeeland
    Ratings:
    +10 / 0
    Home Country:
    Netherlands Netherlands
    Show System Specs
    I tried to see this in action but unfortunately this version is designed for 1.2.0, and my machines run on the 1.2.2. version.
    I'm so curious that i will downgrade to test this option.

    Thank you for all your time and effort to make MePo even better :)
     
  8. manyakim
    • Premium Supporter

    manyakim MP Donator

    Joined:
    November 20, 2005
    Messages:
    36
    Likes Received:
    9
    Gender:
    Male
    Location:
    Zeeland
    Ratings:
    +10 / 0
    Home Country:
    Netherlands Netherlands
    Show System Specs
  9. mbuzina
    • Premium Supporter

    mbuzina Retired Team Member

    Joined:
    April 11, 2005
    Messages:
    2,839
    Likes Received:
    627
    Location:
    Germany
    Ratings:
    +723 / 4
    Home Country:
    Germany Germany
    Show System Specs
    Wow, completly wrong thread, sorry, will remove my posts immediatly....
     
  10. mattjcurry
    • Team MediaPortal

    mattjcurry Development Group

    Joined:
    October 24, 2011
    Messages:
    261
    Likes Received:
    195
    Ratings:
    +226 / 0
    Yes, the version will show as 1.2.0, because when you checkout from Git that is the version of the master branch, even though it contains all of the changes from 1.2.2, as well as additional changes that have been vetted and approved.

    I do wish that MP was a little bit less sensitive about version numbers, or that there was an easy way to disable version checking in the config. It would make testing a lot easier.

    If you would like, I can probably upload a full installer with the patch compiled in tonight, assuming that I do not run into an attachment file size limitation.

    Matt
     
  11. mbuzina
    • Premium Supporter

    mbuzina Retired Team Member

    Joined:
    April 11, 2005
    Messages:
    2,839
    Likes Received:
    627
    Location:
    Germany
    Ratings:
    +723 / 4
    Home Country:
    Germany Germany
    Show System Specs
    mattjcurry, you can base your patch on the Tag 1.2.2 and then you get 1.2.2 compatible versions (I had the same issue, that was why I mistook the thread ;-) )
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!