[solved] How Do I Get The Colours That I Want? (1 Viewer)

[wizard123]

With MP 1.16 Pre and the new functions it will work without # and full ARGB

I am on 1.16pre i was just stating simply without the # it won't work i.e eaeaea or ffeaeaea or 99eaeaea will not work that's all

 

[ajs]

With MP 1.16 Pre and the new functions it will work without # and full ARGB

It can work (for values like 8900346), but more often, the error will occur.. Will work with # and with color names. Like: Blue, White etc...

 

[catavolt]

I am on 1.16pre i was just stating simply without the # it won't work i.e eaeaea or ffeaeaea or 99eaeaea will not work that's all

Ah, sorry for my comment before - you´re absolutely right - ajs only added the x/y positioning and did not change the colour coding

 

[ajs]

ajs only added the x/y positioning and did not change the colour coding

He can do this. But then he would make changes in the skin engine (color definition).

 

[ajs]

Like: https://github.com/MediaPortal/Medi...al.Application/FullScreenSplashScreen.cs#L160

if (xmlNode != null)
{
  string valueText = xmlNode.Value;
  if (!string.IsNullOrEmpty(valueText))
  {
    bool isNamedColor = false;

    if (valueText[0] == '#' && valueText.Length > 1)
    {
      valueText = valueText.Substring(1);
    }

    foreach (char ch in valueText)
    {
      if (ch >= '0' && ch <= '9' || ch >= 'A' && ch <= 'F' || ch >= 'a' && ch <= 'f')
      {
        continue;
      }

      isNamedColor = true;
      break;
    }

    if (!isNamedColor)
    {
      valueText = "#" + valueText;
    }

    try
    {
      Color textColor = ColorTranslator.FromHtml(valueText);
      Log.Debug("FullScreenSplash: TextColor value found: {0}", textColor);
      lblMain.ForeColor = textColor;
      lblVersion.ForeColor = textColor;
      lblCVS.ForeColor = textColor;
      Log.Debug("FullScreenSplash: TextColor successfully set: {0}", textColor);
    }
    catch
    {
      Log.Debug("FullScreenSplash: TextColor set failed: {0}", valueText);
    }
  }
}

No exception, splash always work and all color support ...

 

[mm1352000]

To be clear: splashscreen.xml is a very special case - it´s not a standard window of MP, so the colour tag there is correct...

Can you please explain this in more detail?

 

[ajs]

Can you please explain this in more detail?

SplashScreen not equal FullSplashScreen and not equal GUIWindow
FullSplashScreen not equal GUIWindow
MP Window equal GUIWindow
MP Window work according to the rules skins engine. Support all controls ...
FullSplashScreen not work according to the rules skins engine. Support couple controls. Picture and text. Text supports quite a few properties and their values are not such as to control in GUI Window.
SplashScreen Not adjusted at all.
That such a leapfrog.

 

[CyberSimian]

It seems to me that the situation is this: without changing any MP C++ or C# code, there are two choices for "splashscreen.xml":

(1) Use a notation that is valid everywhere within MP.

(2) Use a notation that is not valid everywhere within MP.

For those who have lost track of this discussion, the notation that is valid everywhere within MP means using named colours, such as "lightblue" or "ivory". I would also add an XML comment to the file saying that "Only named colours can be used in this file", to avoid a different set of people having this discussion again five years from now.

-- from CyberSimian in the UK

 

[ajs]

I would also add an XML comment to the file saying that "Only named colours can be used in this file"

Why limit people?
In this window, it is not so in MP windows ... Look: https://forum.team-mediaportal.com/...abel-in-fullsplashscreen.135527/#post-1203433

 

[catavolt]

For those who have lost track of this discussion, the notation that is valid everywhere within MP means using named colours, such as "lightblue" or "ivory". I would also add an XML comment to the file saying that "Only named colours can be used in this file", to avoid a different set of people having this discussion again five years from now.

First of all you´re a bit wrong
1. Not only named colours are allowed in all screens (except splashscreen), but also ARGB values
2. As splashscreen is an exception to all (and also well known by all skinners), there shouldn´t be any need of any comment (because in splashscreen.xml we use #RGB)
3. The discussion was raised by you only, other skinners were already aware of the things discussed here