Integration of MPC-HC subtitle's engine (1 Viewer)

[stoked]

I'm just curious, how would this "hack" interfere with MPs internal sub engine regarding other containers/codecs when trying to show subs.

The new engine is intended to replace DirectVobSub. So, it will work whenever DirectVobSub was working

So to enable this, do we disable VSFilter loading in Haali media splitter and this will take over?

 

[hoborg]

Best you can do is unregister "VSFilter.dll".

 

[Pretoriano]

i'm now using this patch with MP (i compiled the latest svn with the sources from CPP2005 so configuration work to) and i must say that i don't have any issue so far,divx/xvid subtitles are working (i unregistred vsfilter) no conflicts so far.Thx again CPP2005 and i hope this will be integrated soon (and a i dont have to compile MP my own)

 

[red5goahead]

i'm now using this patch with MP (i compiled the latest svn with the sources from CPP2005 so configuration work to) and i must say that i don't have any issue so far,divx/xvid subtitles are working (i unregistred vsfilter) no conflicts so far.Thx again CPP2005 and i hope this will be integrated soon (and a i dont have to compile MP my own)

I quote you. Flavio e buona serata.

CPP2005 remember check the sub synch because seem there is some problem. the video/audio seems lags from its sub. the sub hastes for about half second. the internal sub slide delay control seems not work.

ps:I tried with an MKV 720p h.264/ac3 and its srt files.

again cpp2005.

 

[tourettes]

the internal sub slide delay control seems not work.

I'm almost sure that it has never worked

 

[red5goahead]

the internal sub slide delay control seems not work.

I'm almost sure that it has never worked

Ok so it's time to go...

 

[Pretoriano]

the internal sub slide delay control seems not work.

I'm almost sure that it has never worked

so thats why ,i almost breaked my remote one day.

And yes subs are a bit outsynch here too,not much but it is...

 

[damaster]

2 bugs to report
1: Slight delay as others have reported.

2: When I close MediaPortal, the MediaPortal.exe process keeps running in the background and I have to kill it with Task Manager. This is due to loading of mpcSubs.dll. As a test, I changed MpcSubtitles.cs to NOT import the DLL and just stubbed out empty methods as below, and then when I exit MediaPortal it exits just fine:

    /*
    [DllImport("mpcSubs.dll", ExactSpelling = true)]
    public static extern unsafe bool SetDevice(void* device, int w, int h);

    [DllImport("mpcSubs.dll", ExactSpelling = true, CharSet = CharSet.Unicode)]
    public static extern void SetDefaultStyle([In] ref SubtitleStyle style);

    [DllImport("mpcSubs.dll", ExactSpelling = true, CharSet = CharSet.Unicode)]
    public static extern bool LoadSubtitles(string filename, IGraphBuilder graphBuilder);

    [DllImport("mpcSubs.dll", ExactSpelling = true)]
    public static extern int GetCount();

    [DllImport("mpcSubs.dll", ExactSpelling = true)]
    [return: MarshalAs(UnmanagedType.BStr)]
    public static extern string GetLanguage(int i);

    [DllImport("mpcSubs.dll", ExactSpelling = true)]
    public static extern int GetCurrent();
    
    [DllImport("mpcSubs.dll", ExactSpelling = true)]
    public static extern void SetCurrent(int current);

    [DllImport("mpcSubs.dll", ExactSpelling = true)]
    public static extern bool GetEnable();
    
    [DllImport("mpcSubs.dll", ExactSpelling = true)]
    public static extern void SetEnable(bool enable);

    [DllImport("mpcSubs.dll", ExactSpelling = true)]
    public static extern void Render();

    [DllImport("mpcSubs.dll", ExactSpelling = true)]
    public static extern void FreeSubtitles();
    */

    public static unsafe bool SetDevice(void* device, int w, int h) { return true; }

    public static void SetDefaultStyle([In] ref SubtitleStyle style) { }

    public static bool LoadSubtitles(string filename, IGraphBuilder graphBuilder) { return true; }

    public static int GetCount()  { return 1; }

    public static string GetLanguage(int i) { return "English"; }

    public static int GetCurrent() { return 1; }
    
    public static void SetCurrent(int current) { }

    public static bool GetEnable() { return true; }
    
    public static void SetEnable(bool enable) { }

    public static void Render() { } 

    public static void FreeSubtitles() { }

 

[mr viggo]

When I close MediaPortal, the MediaPortal.exe process keeps running in the background and I have to kill it with Task Manager.

Same here.

 

[cpp2005]

Ok I'm checking it, tourettes may be you have a hint why it would stay in memory?
Regarding delay: with what kind of subtitles did you get it (all/external/internal)? And what renderer are you using?

So to enable this, do we disable VSFilter loading in Haali media splitter and this will take over?

DirectVobSub is removed automatically from graph, so you don't have to do anything to enable it.

damaster, mr viggo
can you check mediaportal logs, if there are any errors after it stays in memory?