Integration of MPC-HC subtitle's engine | Page 5

Discussion in 'General Development (no feature request here!)' started by cpp2005, February 3, 2009.

  1. stoked
    • Premium Supporter

    stoked MP Donator

    Joined:
    December 14, 2007
    Messages:
    297
    Likes Received:
    8
    Ratings:
    +8 / 0
    Home Country:
    Canada Canada
    So to enable this, do we disable VSFilter loading in Haali media splitter and this will take over?


     
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. hoborg

    hoborg Portal Pro

    Joined:
    June 13, 2008
    Messages:
    4,413
    Likes Received:
    1,593
    Location:
    Nový Jičín
    Ratings:
    +1,621 / 2
    Home Country:
    Czech Republic Czech Republic
    Show System Specs
    Best you can do is unregister "VSFilter.dll".
     
  4. Pretoriano
    • Team MediaPortal

    Pretoriano Retired Team Member

    Joined:
    October 1, 2007
    Messages:
    526
    Likes Received:
    137
    Gender:
    Male
    Location:
    Roma, Italia
    Ratings:
    +137 / 0
    Home Country:
    Romania Romania
    i'm now using this patch with MP (i compiled the latest svn with the sources from CPP2005 so configuration work to) and i must say that i don't have any issue so far,divx/xvid subtitles are working (i unregistred vsfilter) no conflicts so far.Thx again CPP2005 and i hope this will be integrated soon (and a i dont have to compile MP my own):D
     
    • Like Like x 2
  5. red5goahead
    • Premium Supporter

    red5goahead MP Donator

    Joined:
    November 24, 2007
    Messages:
    695
    Likes Received:
    96
    Gender:
    Male
    Occupation:
    Software engineering
    Location:
    Italy, North West
    Ratings:
    +144 / 1
    Home Country:
    Italy Italy
    Show System Specs
    I quote you. Flavio e buona serata.

    CPP2005 remember check the sub synch because seem there is some problem. the video/audio seems lags from its sub. the sub hastes for about half second. the internal sub slide delay control seems not work.

    ps:I tried with an MKV 720p h.264/ac3 and its srt files.

    :D again cpp2005.
     
  6. tourettes
    • Team MediaPortal

    tourettes Retired Team Member

    Joined:
    January 7, 2005
    Messages:
    17,301
    Likes Received:
    4,595
    Ratings:
    +4,810 / 3
    I'm almost sure that it has never worked :)
     
    • Like Like x 1
  7. red5goahead
    • Premium Supporter

    red5goahead MP Donator

    Joined:
    November 24, 2007
    Messages:
    695
    Likes Received:
    96
    Gender:
    Male
    Occupation:
    Software engineering
    Location:
    Italy, North West
    Ratings:
    +144 / 1
    Home Country:
    Italy Italy
    Show System Specs
    Ok so it's time to go... :D
     
    • Like Like x 1
  8. Pretoriano
    • Team MediaPortal

    Pretoriano Retired Team Member

    Joined:
    October 1, 2007
    Messages:
    526
    Likes Received:
    137
    Gender:
    Male
    Location:
    Roma, Italia
    Ratings:
    +137 / 0
    Home Country:
    Romania Romania
    so thats why ,i almost breaked my remote one day:D.

    And yes subs are a bit outsynch here too,not much but it is...
     
    • Like Like x 1
  9. damaster

    damaster Portal Pro

    Joined:
    November 23, 2007
    Messages:
    412
    Likes Received:
    35
    Ratings:
    +35 / 0
    Home Country:
    Canada Canada
    2 bugs to report
    1: Slight delay as others have reported.

    2: When I close MediaPortal, the MediaPortal.exe process keeps running in the background and I have to kill it with Task Manager. This is due to loading of mpcSubs.dll. As a test, I changed MpcSubtitles.cs to NOT import the DLL and just stubbed out empty methods as below, and then when I exit MediaPortal it exits just fine:

    Code (Text):
    1.  
    2.     /*
    3.     [DllImport("mpcSubs.dll", ExactSpelling = true)]
    4.     public static extern unsafe bool SetDevice(void* device, int w, int h);
    5.  
    6.     [DllImport("mpcSubs.dll", ExactSpelling = true, CharSet = CharSet.Unicode)]
    7.     public static extern void SetDefaultStyle([In] ref SubtitleStyle style);
    8.  
    9.     [DllImport("mpcSubs.dll", ExactSpelling = true, CharSet = CharSet.Unicode)]
    10.     public static extern bool LoadSubtitles(string filename, IGraphBuilder graphBuilder);
    11.  
    12.     [DllImport("mpcSubs.dll", ExactSpelling = true)]
    13.     public static extern int GetCount();
    14.  
    15.     [DllImport("mpcSubs.dll", ExactSpelling = true)]
    16.     [return: MarshalAs(UnmanagedType.BStr)]
    17.     public static extern string GetLanguage(int i);
    18.  
    19.     [DllImport("mpcSubs.dll", ExactSpelling = true)]
    20.     public static extern int GetCurrent();
    21.    
    22.     [DllImport("mpcSubs.dll", ExactSpelling = true)]
    23.     public static extern void SetCurrent(int current);
    24.  
    25.     [DllImport("mpcSubs.dll", ExactSpelling = true)]
    26.     public static extern bool GetEnable();
    27.    
    28.     [DllImport("mpcSubs.dll", ExactSpelling = true)]
    29.     public static extern void SetEnable(bool enable);
    30.  
    31.     [DllImport("mpcSubs.dll", ExactSpelling = true)]
    32.     public static extern void Render();
    33.  
    34.     [DllImport("mpcSubs.dll", ExactSpelling = true)]
    35.     public static extern void FreeSubtitles();
    36.     */
    37.  
    38.     public static unsafe bool SetDevice(void* device, int w, int h) { return true; }
    39.  
    40.     public static void SetDefaultStyle([In] ref SubtitleStyle style) { }
    41.  
    42.     public static bool LoadSubtitles(string filename, IGraphBuilder graphBuilder) { return true; }
    43.  
    44.     public static int GetCount()  { return 1; }
    45.  
    46.     public static string GetLanguage(int i) { return "English"; }
    47.  
    48.     public static int GetCurrent() { return 1; }
    49.    
    50.     public static void SetCurrent(int current) { }
    51.  
    52.     public static bool GetEnable() { return true; }
    53.    
    54.     public static void SetEnable(bool enable) { }
    55.  
    56.     public static void Render() { }
    57.  
    58.     public static void FreeSubtitles() { }
     
  10. mr viggo
    • Premium Supporter

    mr viggo MP Donator

    Joined:
    March 1, 2008
    Messages:
    500
    Likes Received:
    58
    Ratings:
    +67 / 0
    Home Country:
    Sweden Sweden
    Show System Specs
    Same here.
     
  11. cpp2005
    • Team MediaPortal

    cpp2005 Retired Team Member

    Joined:
    November 7, 2006
    Messages:
    164
    Likes Received:
    127
    Ratings:
    +127 / 0
    Ok I'm checking it, tourettes may be you have a hint why it would stay in memory?
    Regarding delay: with what kind of subtitles did you get it (all/external/internal)? And what renderer are you using?

    DirectVobSub is removed automatically from graph, so you don't have to do anything to enable it.

    damaster, mr viggo
    can you check mediaportal logs, if there are any errors after it stays in memory?
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!