[Pending] - Live commercial skip detection | Page 6

Discussion in 'Submit: code patches (MediaPortal/TV-Server/etc.)' started by sccrgoalie1, September 16, 2013.

  1. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,269
    Likes Received:
    6,221
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,229 / 9
    Home Country:
    France France
    Show System Specs
    yep :)


     
    • Thank You! Thank You! x 2
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,269
    Likes Received:
    6,221
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,229 / 9
    Home Country:
    France France
    Show System Specs
    I can't right now latest TortoiseGIT didn't work well, so will try to figure out later or tomorrow.
     
    • Thank You! Thank You! x 2
  4. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,527
    Likes Received:
    4,738
    Ratings:
    +8,205 / 17
    Home Country:
    New Zealand New Zealand
    I just had a quick peak at the code. Not really within my area of expertise - I'm just curious to know what needed to be changed on the server side. :)

    If I've understood correctly, you need to be able to retrieve the frame rate of the stream/recording?

    I guess I'm wondering how well this would work for VFR IPTV streams... but maybe I misunderstood?
     
    • Thank You! Thank You! x 1
  5. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    I changed two things on the server side.

    1. As you mention I need to grab the framerate as comskip doesn't output the framerate until it's done processing. I can only use MediaInfo on local or SMB files that's why it has to be done at the server for RTSP.

    2. I changed the way the text file is read, being sure to open it read only and allow comskip to keep writing as I read it. Previously reading the file would cause comskip to stop processing the file.

    As far as VFR IPTV streams go, I'll be honest I have no idea what that is, I guess the only way to see if those work will be to test. I assume your mostly concerned with grabbing the framerate of these files. It should be noted this doesn't work while watching live TV, rather it works after you start recording the program and then play it back from your recordings list (even though the program may still be recording). So, we should be reading the framerate from the local .ts file on the server, not the stream itself. Let me know if that doesn't make sense.
     
    • Thank You! Thank You! x 1
  6. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,527
    Likes Received:
    4,738
    Ratings:
    +8,205 / 17
    Home Country:
    New Zealand New Zealand
    Okay, thanks for the info. (y)

    VFR stands for variable frame rate. Some IPTV providers encode with VFR to reduce the bandwidth as much as possible. I guess maybe comskip would not be able to work with such recordings. As far as I know providers that use VFR are in the minority.

    Thanks for your work on this. :)
     
    • Thank You! Thank You! x 1
  7. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Long term, do we need to be thinking about modifying comskip to export times in minutes/seconds rather than frames? Is it even possible to do this?
     
  8. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    If we add support for edl it would do that.
     
  9. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs

    To me that sounds like a good reason to switch from .txt to .edl, but I don't really understand the issues.

    Also, if we did switch to .edl, would we need to make the server/plugin changes to get the frame rate?
     
  10. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    Yeah maybe we should add edl support.

    It will require different changes to the tv server and plugin for RTSP. Basically to pull the edl file.
     
  11. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,527
    Likes Received:
    4,738
    Ratings:
    +8,205 / 17
    Home Country:
    New Zealand New Zealand
    I wonder whether it would be possible for the RTSP server to include the required details as metadata rather than querying the server directly. Maybe that isn't convenient (because TsReader would then have to provide some kind of interface for accessing these details)... but maybe it could enable other TV Server front ends to more seamlessly support the same feature. Only a [probably very] dumb idea.
     
    • Like Like x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!