[Pending] - Live commercial skip detection | Page 5

Discussion in 'Submit: code patches (MediaPortal/TV-Server/etc.)' started by sccrgoalie1, September 16, 2013.

  1. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Thanks. Could you also supply the comskip.ini file so that we are all using the same for testing?


     
    • Like Like x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    So, I've got everything pretty much worked out, but I'm a little stumped as to the best way to get commercial file changes in a multiseat environment when using RTSP. The only thing I can think of is to set a timer in the TVPlugin to go and ask the server for a new commercial file every 60 seconds or so, but this is not an ideal method. Does anyone have any suggestions? I've been reviewing the following commit below when RTSP commercial skipping was first added.

    http://sources.team-mediaportal.com...l/Core/Player/g_player.cs&rev=26857&peg=19528
     
    • Thank You! Thank You! x 2
  4. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    I've built some changes into the TVPlugin to hopefully make this work, but before I push them I would like to test it out. Does anyone know how I can force Media Portal to use RTSP for a recording even if it's local to the TVServer? I don't have another PC setup with Media Portal, using the built in TVPlugin.
     
  5. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    One thing you need to be aware of is that we are in codefreeze on the TV side of things, after a couple of already agreed fixes. Therefore if this needs to change the TvPlugin there is a good chance it cannot be included in 1.6.0.

    Of course, it is always possible to put a patch/binaries into area 51 for wider testing, so don't let this discourage you.

    The reason for the code freeze is a focus on TV Engine version 3.5.
     
  6. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    There will be no way to make RTSP work without a change to the TVPlugin. UNC and local work just fine. I guess it will be up to the team as to whether they want to push the live patch (MP side of things), knowing RTSP live commercial skip won't work or not... Thanks for letting me know. My question still stands though as I would like to test the changes I made to the TVPlugin for RTSP, and am not sure how to force the plugin to use RTSP.
     
  7. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs

    https://forum.team-mediaportal.com/threads/tvplugin-avoiding-rtsp-in-multiseat-mode-test-plz.36735/

    Took me a while to find it.

    open "mediaportal.xml" and insert this new "usertsp" tag.

    <section name="tvservice">
    <entry name="usertsp">yes</entry>
     
    • Thank You! Thank You! x 1
  8. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    At this point I have everything fixed up and working properly, unfortunately in order to get RTSP to work changes are definitely required to both the TVPlugin and the TVServer. Since there is a blackout on these what do you suggest I do? I could push just the changes for Media Portal, and then we could get those tested and ready for release, this will work with local recordings and UNC recordings. Once TV 3.5 is released we would only have to push the changes related to RTSP and no further changes would be required to Media Portal as it would be ready for these changes.

    A couple of notes on the changes made:
    1. Commercial skipping has gone back to only using txt file like before, except now it can read them live
    2. I added the requested change to manual skip forward where it will now remember the skip from position. You can them assign the new action (ACTION_SKIP_BACK_PREVIOUS_JUMP) to whatever button you want to skip back.
    3. Added an event for Skin dev's to subscribe to to be notified when there are changes to the chapter segments (I'm not sure this is necessary as they may load on demand (when the progress bar shows) anyway)

    I'll be updating the OP shortly to reflect the changes that were made.

    Please let me know what you think in regards to pushing the changes.
     
    Last edited: October 22, 2013
    • Like Like x 1
  9. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Massive thanks for this.

    I'd say we get this into a GIT branch and fully tested. Then if people want to test it, they can do, including in area 51.

    The TV devs can then see the code.

    But I also like your idea of separating the fixes out, so maybe we can do as you suggest and fix the singleseat/UNC path version.
     
  10. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America

    Attached Files:

    • comskip.txt
      File size:
      5.8 KB
      Uploaded:
      October 22, 2013
      Views:
      187
  11. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!