[WiP] madVR support in MP1 (35 Viewers)

[grabi_2001]

Hi Sebastiii,
Thank you, have a little fever, coughing, etc.
And I'm bored Here are the logs from 1.9 and 1.2 pre, maybe they say something. As I said 1.9 and 471 work .... without problems.
I once again this morning installed the 1.20 pre, tried everything, settings MadVR, reinstalling Nvidia, MadVR ... Settings MP ... does not really go around.
Error messages MadVR, video still or does not start ... etc.
On the hardware, it certainly can not lie, which is completely new ... Windows completely reinstalled .... MP a fresh installation .....
Maybe you see a mistake, otherwise I wait until there is a new version.

greetings
Dirk

 

[azzuro]

@grabi_2001
can yo utest this

 

[grabi_2001]

the same result .... attached the logs from the test

 

[el Filou]

Hello, long time no see, hope everyone's doing fine.

I've found a bug: when aspect ratio switches from 16:9 to 4:3 during playback (like in european SDTV), the 4:3 image is not displayed in the center of the view because MP keeps instructing madVR to 'align left top'.
This does not happen when starting playback directly from a position where it's already in 4:3, in this case MP does not tell madVR to align left top and the image is centered.
This also does not happen in MPC-HC because it never instruct madVR to align left top even with 16:9, so if aspect ratios change during playback madVR keeps everything centered.
This does not happen in MP with EVR either.

Please see attached screenshots for comparison.
Note that this happens only with TV channels where the stream aspect ratio changes dynamically, so I guess it means only with SDTV, or with 1440x1080 HDTV (but I think that is not used much anymore, I know it was used in France on DVB-T in the beginnings), so here's a 30 second sample to make it easier to test: MP 1.20 madVR 16-9 to 4-3 sample.ts

Tested with MP 1.20 Release, LAV Filters 0.72.0, madVR 0.92.14.

It's just a minor annoyance to me because I schedule-record everything, but it forces to stop playback and restart it so for people who watch live TV it would be more annoying.

Thanks a lot to the devs if you can fix it! Take care.

 

[Sebastiii]

Hi
Thanks for the reports, I have to try to fix this and for now, no luck, the only fast way I have found is to go from video fullscreen off -> on (it will correctly reset the correct place and avoid to stop the stream).
I have a hack idea it seems TsReader detect the aspect ratio change but not always and the idea is to trigger the fullscreen OFF to ON delayed to video mode.
I did try it without delay but not always works.

Thanks again for the sample that trigger it correctly

 

[Sebastiii]

@el Filou
For testing the hack delayed VideoWindow call

 

[el Filou]

Hello @Sebastiii

Unfortunately that new core.dll doesn't work, but I've only kept the 30 sec. sample and not the full recording, so maybe it needs more time for the hack to work?

Exiting then going back to full screen indeed fixes the problem, so is cycling through the different 'zoom modes' until it's set to 'Normal' again, so there's a workaround to fix the bug without stopping playback, thank you for this.
However, I thought you were gonna fix it by removing that 'align left top' that is applied at the start of playback, is there no way to do that?
Obviously I don't know much about the inner workings of MP and madVR interaction, but I don't understand why it is needed in the first place.
You can see that when you change the view by exiting then going back to fullscreen, or by cycling through the zoom modes, MP is no longer using 'align left top' after that, so obviously madVR presentation works just fine without it. And as I said in my previous post, MPC-HC for example nevers uses it, and I don't really get why you would align a video to the left top corner anyway, especially in full screen viewing.
Is it possible to fix it that way? Maybe a default option is left for madVR to decide when MP starts playback and madVR decides to align left top by itself?

Here are two screenshots of madVR's OSD in MP to illustrate this. The first is right at the start of playback, and the second is after exiting then going back to fullscreen. We can see that 'align left top' is the only difference and I think that's the root cause of the issue.

Thanks for your help!

 

[Sebastiii]

Thanks, I will higher the delay for testing in a new core and try to look at the align stuff. I'm not sure that I init it somewhere.

Tapatalk

 

[Sebastiii]

Added delay to 5 secs (before it was 2)

 

[el Filou]

It works now, it switches after one second or so.

I've found this regarding the 'align left top': http://madshi.net/89notesForDevs.pdf

IMadVRCommand::SendCommandDouble(“setZoomAlignX” / “setZoomAlignY”, whatever);

Allows you to align the video rectangle “left/top”, “center” or “right/bottom”. Center is default.

This says "center" is default so I guess MP calls it with left/top by mistake when starting playback?

Edit: unfortunately I can't find a public documentation of madVR's API anywhere. I guess madshi only sends it privately to devs that ask for it?