[Approved] Mantis 2624 patch (1 Viewer)

[romuz]

That Bug happens because of duplicate channel mapping has created while importing channels (double mapping for All Channels group)
this patch prevent it by checking if mapping already exists and update it.

 

[elliottmc]

Hi,

Thanks. I will brought this to the attention of the team. Hopefully someone with the relevant expertise will review your patch soon.

Best regards,

Mark

 

[morpheus_xx]

AW: Mantis 2624 patch

1 quick comments to this patch:

1) have you checked that the layer.AddChannelToRadioGroup/layer.AddChannelToGroup don't check for double assignments? at least I thought they do.

3) what's the difference between:
a) layer.AddChannelToGroup
b) GroupMap map = new GroupMap(group.IdGroup, channel.IdChannel, sortOrder); map.Persist();

if b) does the same as a), I would prefer to change it to layer.AddChannelToGroup (also to avoid doubles)

If point 1) is not the case, those 2 functions need to be fixed, that they won't map more than one time...

(removed point2, as it is a list.contains, not string )

 

[romuz]

Re: AW: Mantis 2624 patch

1 quick comments to this patch:

1) have you checked that the layer.AddChannelToRadioGroup/layer.AddChannelToGroup don't check for double assignments? at least I thought they do.

3) what's the difference between:
a) layer.AddChannelToGroup
b) GroupMap map = new GroupMap(group.IdGroup, channel.IdChannel, sortOrder); map.Persist();

if b) does the same as a), I would prefer to change it to layer.AddChannelToGroup (also to avoid doubles)

If point 1) is not the case, those 2 functions need to be fixed, that they won't map more than one time...

(removed point2, as it is a list.contains, not string )

imho difference between
a) layer.AddChannelToGroup
b) GroupMap map = new GroupMap(group.IdGroup, channel.IdChannel, sortOrder); map.Persist();
in that b) sets SortOrder and a) no

ill check "AddChannelToRadioGroup" part 1 tomorrow.

 

[romuz]

part 1 is true so i have reverted it and prepared patch with GroupMap map = new GroupMap(group.IdGroup, channel.IdChannel, sortOrder); map.Persist(); only.
(see first post)

 

[chemelli]

patch commited to svn25271.



Simone