1.23.0 MatroskaTagInfo uses the wrong casing for tags (1 Viewer)

[doskabouter]

MediaPortal Version: 1.23

Description
Title says it all...
Jira: [MP1-4977] MatroskaTagInfo uses the wrong casing for tags - MediaPortal Jira
PR:Bug mp1 4977 matroska tag info uses the wrong casing for tags by doskabouter · Pull Request #182 · MediaPortal/MediaPortal-1

Still needs some discussion, as this is a breaking change.
I could add something that is able to read old-style xml's and optionally save them as correct ones?

What do you guys think?

Steps to Reproduce:
Play a video downloaded by onlinevideos with the videos-plugin

 

[azzuro]

hello @doskabouter
thank you for providing support,
can you look for 1.23 test 3 branch please, new mediainfo is provided to this one for bugfix , please.
thank you.

ps: what result we will have actually when trying to play with onlinevideos ?

 

[azzuro]

@yartat
@ajs

 

[ajs]

I could add something that is able to read old-style xml's and optionally save them as correct ones?

Good idea

 

[doskabouter]

hello @doskabouter
thank you for providing support,
can you look for 1.23 test 3 branch please, new mediainfo is provided to this one for bugfix , please.
thank you.

ps: what result we will have actually when trying to play with onlinevideos ?

Are there relevant changes in that area in the test3 branch then?
And for onlinevideos there will not be any differences. the wrong casing is in mediaportal

 

[doskabouter]

Good idea

Any more opinions on this?
there are 3 choices:

1: Create separate a tool that fixes the xmlfiles, and have it run at install/update
2: When MP encounters a wrong-cased xmlfile fix it and save it
3: Support both wrong-cased and correctly-cased xmlfiles

In my opinion option 1 is the best one, and reduces the legacy stuff we have to maintain in mediaportal

It's also the hardest one to integrate in the update process.
Options 1 and 2 also make it impossible to downgrade Mediaportal.

So I guess we'll end up with option 3 and have another piece of legacy we have to maintain, test and keep working,,,
Unless ofcourse someone has a brilliant option 4 or a strong opinion on options 1 or 2

 

[ajs]

How determine where files from OnlineVideos stored? When MP installed some resources maybe not work... NAS shutdown ... etc...
IMHO support old and new better ...

--
WBR, ajs

 

[doskabouter]

I think you're misunderstanding me. The files from onlinevideos are correct, it's the files created by mediaportal that are wrong.
But apart from that, I think you're right about option 3 (reluctantly...). Anyone else want to give me their opinion?

 

[ajs]

I dont use OV for download, and dont know where and how this XML stored and used

--
WBR, ajs

 

[CyberSimian]

Anyone else want to give me their opinion?

I too have no idea what this is all about, but my view is that upward compatibility should be mandatory in all circumstances.

Yes, that means that there is legacy code in the product, but being legacy code also means that it should not need changing in the future (it's legacy -- it merely needs to be invoked when the circumstances demand it). So, the product is bigger than it need be, but in the era of multi-gigabyte RAM installations, who cares?

We do users a disservice if we change things without maintaining compatibility with what went before.

-- from CyberSimian in the UK