MP-TVSeries v4.3.6 Release [2020-01-24] (2 Viewers)

Edalex

Community Plugin Dev
  • Premium Supporter
  • January 3, 2008
    2,959
    1,270
    Saratov
    Home Country
    Russian Federation Russian Federation
    We have a lot of other stuff we're working through
    It's soooo true :D
    I have so many bug reports mostly about swagger and actual code mismatch.
    I've autogenerated my C# code with swagger and only half of methods worked from the box.
    The biggest problem for me are nullable types in C#. Integer in C# couldn't be null but no integer was tagged as nullable in swagger but several ones turned into null in fact. So I need to decide if I should make all integers as nullable in code or I should wait if you tag some of them as nullable in swagger or maybe you will use 0 instead of null everywhere for non-nullable types in C#. :oops:

    • class ArtworkExtendedRecord - nullable integer properties EpisodeId, MovieId,NetworkId,PeopleId,SeasonId,SeriesId,SeriesPeopleId and unlisted status property
    • class Character - nullable integer properties EpisodeId, MovieId,PeopleId,SeriesId and unlisted PeopleType property
    • class Company - problem with CompanyType property
    • class CompanyType - actual properties are companyTypeId and companyTypeName and not ID and Name like in swagger
    • class ContentRating - unlisted property Description
    • class Entity - nullable MovieId,SeriesId is fact
    • class EpisodeBaseRecord - nullable ImageType, Runtime and ulisted properties Overview, LastUpdated, FinaleType
    • class EpisodeExtendedRecord - nullable AirsAfterSeason, AirsBeforeEpisode, AirsBeforeSeason and unlisted properties Overview, LastUpdated, FinaleType, Nominations, Networks, Studios
    • class MovieBaseRecord - nullable Score, Runtime and unlisted LastUpdated
    • class MovieExtendedRecord - nullable Score, Runtime and unlisted LastUpdated, several problems with underscores, problem with Companies
    • class PeopleExtendedRecord - unlisted NameTranslations, OverviewTranslations, Translations
    • class SearchResult - tranlation and overviews properties have another structure, unlisted objectID, some properties has underscores. The most bugged class :)
    • class SeasonBaseRecord - nullable ImageType and problem with Companies property GetAllSeasons has unlisted properties · Issue #113 · thetvdb/v4-api.
    • class SeasonExtendedRecord - nullable ImageType, wrong Type for Type, unlisted Companies and problem with TagOptions
    • class SeasonType - Type has wrong type SeasonType type property is string · Issue #112 · thetvdb/v4-api
    • class SeriesBaseRecord - unlisted LastUpdated and averageRuntime
    • class SeriesExtendedRecord - unlisted Episodes, LastUpdated and averageRuntime, Translations
    • class Companies - looks differently in methods I think
    • class Translation - nullable IsAlias
    • method GetListTranslation has array inside "data" property while othe similar methods have single object inside "data" GetListTranslation array instead of object · Issue #120 · thetvdb/v4-api
    • method getSeasonTypes should have SeasonType array in swagger getSeasonTypes wrong attribute · Issue #116 · thetvdb/v4-api Also it has altdvd type which is not listed in seasontype enumerations in other methods
    • method GetSeriesSeasonEpisodesTranslated has Series object in swagger but it has Series properties without object
    • method GetSeriesExtended with meta=translation reffers to SeriesExtendedRecord object but it doesn't have "translation" object insid
    Not a bug: enumerations are case-sensitive and should be lowercase. First, I thought all meta methods are broken but I found that my generator capitalized first letter.
    I'll try to make issues for all of them but it will take some time. :D
     
    Last edited:

    Edalex

    Community Plugin Dev
  • Premium Supporter
  • January 3, 2008
    2,959
    1,270
    Saratov
    Home Country
    Russian Federation Russian Federation
    It's probaly because updates are not coming to MP. :confused:
    It's strange that our url /updates/updates_all.zip is HTTP 404 and /updates/updates_all.xml is fine
    2022-01-05 17:58:55.018 [INFO][05]: Can't connect to http://thetvdb.com/api/<apikey>/updates/updates_all.zip : Удаленный сервер возвратил ошибку: (404) Не найден.
    I'm not on current MP-TVSeries though :oops:
    Nah, my mp-tvseries is too outdated, modern version is able to fallback to xml file.
     
    Last edited:

    Edalex

    Community Plugin Dev
  • Premium Supporter
  • January 3, 2008
    2,959
    1,270
    Saratov
    Home Country
    Russian Federation Russian Federation
    From plugin or from browser?
    http & https from browser and http from plugin.
    MP-TVSeries doesn't control which link to use. It takes http mirrors from api's mirrors.xml.
    Also GetRatingsForUser.php and User_Favorites.php are failing for me too as I see from logs. But now I'm on more modern 4.3.3.11 plugin which is just two years old :D
     

    ajs

    Development Group
  • Team MediaPortal
  • February 29, 2008
    16,031
    11,097
    Kyiv
    Home Country
    Ukraine Ukraine
    Also GetRatingsForUser.php and User_Favorites.php are failing for me too as I see from logs.
    As far as I remember, this is not supported by the API. We have to switch to a new one.
     

    Users who are viewing this thread

    Top Bottom