[MP1-4838] Volume control no longer functions properly when changing audio device (3 Viewers)

[Sebastiii]

Here the log

Severity    Code    Description    Project    File    Line    Suppression State
Error        The type or namespace name 'AudioSwitcher' could not be found (are you missing a using directive or an assembly reference?)    Core    D:\MediaPortal-1\mediaportal\Core\Player\VolumeHandler.cs    26   
Error        The type or namespace name 'AudioSwitcher' could not be found (are you missing a using directive or an assembly reference?)    Core    D:\MediaPortal-1\mediaportal\Core\Player\VolumeHandler.cs    27   
Error        The type or namespace name 'CoreAudioController' could not be found (are you missing a using directive or an assembly reference?)    Core    D:\MediaPortal-1\mediaportal\Core\Player\VolumeHandler.cs    46   
Error        The type or namespace name 'AudioSwitcher' could not be found (are you missing a using directive or an assembly reference?)    Core    D:\MediaPortal-1\mediaportal\Core\Mixer\Mixer.cs    25   
Error        The type or namespace name 'AudioSwitcher' could not be found (are you missing a using directive or an assembly reference?)    Core    D:\MediaPortal-1\mediaportal\Core\Mixer\Mixer.cs    26   
Error        The type or namespace name 'AudioSwitcher' could not be found (are you missing a using directive or an assembly reference?)    Core    D:\MediaPortal-1\mediaportal\Core\Mixer\Mixer.cs    27   
Error        The type or namespace name 'CoreAudioController' could not be found (are you missing a using directive or an assembly reference?)    Core    D:\MediaPortal-1\mediaportal\Core\Mixer\Mixer.cs    217   
Error        The type or namespace name 'CoreAudioDevice' could not be found (are you missing a using directive or an assembly reference?)    Core    D:\MediaPortal-1\mediaportal\Core\Mixer\Mixer.cs    218   
Error    CS0246    The type or namespace name 'AudioSwitcher' could not be found (are you missing a using directive or an assembly reference?)    MediaPortal    D:\MediaPortal-1\mediaportal\MediaPortal.Application\MediaPortal.cs    62    Active
Error    CS0246    The type or namespace name 'CoreAudioController' could not be found (are you missing a using directive or an assembly reference?)    MediaPortal    D:\MediaPortal-1\mediaportal\MediaPortal.Application\MediaPortal.cs    222    Active
Error    CS0246    The type or namespace name 'CoreAudioController' could not be found (are you missing a using directive or an assembly reference?)    MediaPortal    D:\MediaPortal-1\mediaportal\MediaPortal.Application\MediaPortal.cs    222    Active
Error    CS0246    The type or namespace name 'CoreAudioController' could not be found (are you missing a using directive or an assembly reference?)    MediaPortal    D:\MediaPortal-1\mediaportal\MediaPortal.Application\MediaPortal.cs    3112    Active
Error    CS0246    The type or namespace name 'CoreAudioDevice' could not be found (are you missing a using directive or an assembly reference?)    MediaPortal    D:\MediaPortal-1\mediaportal\MediaPortal.Application\MediaPortal.cs    3117    Active
Error    CS0103    The name 'AudioSwitcher' does not exist in the current context    MediaPortal    D:\MediaPortal-1\mediaportal\MediaPortal.Application\MediaPortal.cs    3118    Active
Error    CS0103    The name 'AudioSwitcher' does not exist in the current context    MediaPortal    D:\MediaPortal-1\mediaportal\MediaPortal.Application\MediaPortal.cs    3119    Active

 

[Rick164]

Thanks, just pushed packages.config and that should fix it I hope

 

[Sebastiii]

Probably missing app.conf, in Mediaportal.Application by any chance?
Can commit all changes but it added app.conf in other un-related projects when I added the nuget package

No clue lol
The dll are present in package so don't know why it failed, i think remember that i already seen this because of the version of dll NET3.5 vs NET4.0 but it oes to NET4.0 dll so i don't know lol

 

[Rick164]

It could also need a restore nuget packages run from within Visual Studio

 

[Sebastiii]

Thanks, just pushed packages.config and that should fix it I hope

Let's try

 

[Sebastiii]

It could also need a restore nuget packages run from within Visual Studio

Maybe how did you do that ?
I have close VS -> clean up (git) -> open VS and again error

 

[Rick164]

Trying to find good example but it's:

- Either happens during build or manually:

Right click solution -> Restore NuGet packages

 

[Rick164]

Hopefully found the problem, the online nuget package for AudioSwitcher has an incorrect reference to BCL version in it which I reported to dev a while back but seems it wasn't updated afterwards.
So for now manually corrected references and linked to 2 projects (Core / Mediaportal.Application), tested with fresh clone and worked

https://github.com/RickDB/MediaPortal-1/tree/MP1-4838-Rework_volume_control_management

 

[Rick164]

Since we still run into issues with BCL (build bot doesn't like it), decided to go the NAudio route which was surprisingly easy to get working.
Upsides are:

- No BCL needed for NET40 builds (less deps)
- Maintained and used by mayor companies
- One .dll to include: "NAudio.dll"
- Packed with features for later use:

https://github.com/naudio/NAudio/blob/master/README.md

So a lot of extra features in library, thanks @Stéphane Lenclud for suggesting this one
Will push to clean branch in a sec which will hopefully solve our build problems completely.

// Update

Pushed to re-created branch:

https://github.com/RickDB/MediaPortal-1/tree/MP1-4838-Rework_volume_control_management

 

[Sebastiii]

Nice nice