[MP1-4838] Volume control no longer functions properly when changing audio device (3 Viewers)

[Rick164]

Hi,

Can't reproduce on latest commit from here, removed more old locks we had before so should not be able to lock it up
Will see if we can get wave output device working but the libraries so far lack it like NAudio:

http://stackoverflow.com/questions/20891778/controlling-a-specific-applications-volume-level

Unless we go Windows Core Audio but that is Windows 7 and up only, CSCore might allow for it just not clear from documentation:

https://github.com/filoe/cscore

Bit of a mess in the Windows Audio libraries, some are either dated / requiring lots of code or missing the features we have now

 

[azzuro]

Last commit , it don't lock MP on volume manipulation

Envoyé de mon D5803 en utilisant Tapatalk

 

[Rick164]

Discussed it some more with @Sebastiii and decided to make 2 solutions we can choose from, first being the rework and second being a bug fix only where we keep old code.
So think we need to throw this in the group and see what everyone would prefer , from my point of view would rather not trim down on features so prefer option 2 (bugfix only)

Branches for them:

1. Rework where we lose wave output device support and need some workarounds for NAudio (external volume control is not ideal)

https://github.com/RickDB/MediaPortal-1/commits/MP1-4838-Rework_volume_control_management

2. Bugfix only + Audio renderer detection improved (no extra deps).

https://github.com/RickDB/MediaPortal-1/commits/MP1-4838-BugfixOnly

Bug was basically that we had a device ID history, it will now clear it if device has changed and go thru mixer re-init.
Attached test version for bugfix only version.

 

[azzuro]

call @Developers for opinions

 

[Sebastiii]

Will test the bugfix today seems safe so maybe good for 1.16

 

[Stéphane Lenclud]

I would definitely go for the simpler bug fix at this stage.
@Rick164 You commits comments should start with the JIRA ID like that: "MP1-4838: My comments".
Thus JIRA can pick them up.

 

[Rick164]

Ah didn't know that, new to Jira but will add comments in that style
Can do PR if you guys want or can clone to own MP branch.

 

[azzuro]

Will test the bugfix today seems safe so maybe good for 1.16

if it's bugfix, for me yes
we can keep as branch, with dedicated thread about the Naudio implementation, in case !
i don't understand the change between using Naudio or continu to use the actual code.

 

[Rick164]

i don't understand the change between using Naudio or continu to use the actual code.

NAudio was to fix and reduce the code (smaller implementation) at the same time however with just the bugfix works just as good but feels slightly less smooth, tried to break it a few times with external device changes / standby etc.. but can't so far

 

[Sebastiii]

Working Good
Merged to master : https://issues.team-mediaportal.com/browse/MP1-4838