[MP1-4838] Volume control no longer functions properly when changing audio device (1 Viewer)

Rick164

Super User
  • Team MediaPortal
  • Super User
  • January 7, 2006
    1,335
    1,005
    Netherlands Netherlands
    Country flag
    Hi,

    Can't reproduce on latest commit from here, removed more old locks we had before so should not be able to lock it up :)
    Will see if we can get wave output device working but the libraries so far lack it like NAudio:

    http://stackoverflow.com/questions/20891778/controlling-a-specific-applications-volume-level

    Unless we go Windows Core Audio but that is Windows 7 and up only, CSCore might allow for it just not clear from documentation:

    https://github.com/filoe/cscore

    Bit of a mess in the Windows Audio libraries, some are either dated / requiring lots of code or missing the features we have now :p
     
    Last edited:

    Rick164

    Super User
  • Team MediaPortal
  • Super User
  • January 7, 2006
    1,335
    1,005
    Netherlands Netherlands
    Country flag
    Discussed it some more with @Sebastiii and decided to make 2 solutions we can choose from, first being the rework and second being a bug fix only where we keep old code.
    So think we need to throw this in the group and see what everyone would prefer :) , from my point of view would rather not trim down on features so prefer option 2 (bugfix only)

    Branches for them:

    1. Rework where we lose wave output device support and need some workarounds for NAudio (external volume control is not ideal)

    https://github.com/RickDB/MediaPortal-1/commits/MP1-4838-Rework_volume_control_management

    2. Bugfix only + Audio renderer detection improved (no extra deps).

    https://github.com/RickDB/MediaPortal-1/commits/MP1-4838-BugfixOnly

    Bug was basically that we had a device ID history, it will now clear it if device has changed and go thru mixer re-init.
    Attached test version for bugfix only version.
     

    Attachments

    Last edited:

    Stéphane Lenclud

    Development Group
  • Team MediaPortal
  • April 29, 2013
    2,563
    1,288
    Germany Germany
    Country flag
    I would definitely go for the simpler bug fix at this stage.
    @Rick164 You commits comments should start with the JIRA ID like that: "MP1-4838: My comments".
    Thus JIRA can pick them up.
     

    Rick164

    Super User
  • Team MediaPortal
  • Super User
  • January 7, 2006
    1,335
    1,005
    Netherlands Netherlands
    Country flag
    Ah didn't know that, new to Jira but will add comments in that style :)
    Can do PR if you guys want or can clone to own MP branch.
     
    Last edited:

    Rick164

    Super User
  • Team MediaPortal
  • Super User
  • January 7, 2006
    1,335
    1,005
    Netherlands Netherlands
    Country flag
    i don't understand the change between using Naudio or continu to use the actual code.
    NAudio was to fix and reduce the code (smaller implementation) at the same time however with just the bugfix works just as good but feels slightly less smooth, tried to break it a few times with external device changes / standby etc.. but can't so far :)
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    C Hauppauge HVR-1265 -- does it work with MP1? MediaPortal 1 Talk 1
    ajs MP2Web - MP1 compatibility MediaPortal 1 20
    T MadVR + LAV Filters, Perfect in MPC-BE, Bad in MP1 MediaPortal 1 Talk 13
    P MP2: US user, OTA - can NOT get SchedulesDirect plugin to work on MP1 or MP2 --> how do I get OTA schedule? General 5
    framug [solved] Some changes/fix in MP1 configuration client and server Submit: code patches (MediaPortal/TV-Server/etc.) 14
    S TV-Server MP1 - Automatic search doesn't work Installation, configuration support 2
    C Streaming/transcoding MP2 vs MP1? General 4
    ajs [fixed] 5015: Improving the MP1 installer, providing nicer GUI :) MediaPortal 1 138
    C Streaming to clients over Wifi. MP1 or MP2? Newcomers Forum 0
    S Shortcuts MP1 My Recorded & TV Guide General 10
    azzuro [WiP] MP1-4999 - Big changes with many related change at once by Sebastiii MediaPortal 1 12
    ajs [Help Us!] MP1 X64 Version MediaPortal 1 20
    joecrow How about a Launcher plugin for MP1? MediaPortal 1 6
    wizard123 [solved] MP1 Build help MediaPortal 1 21
    ajs [News] MediaPortal 1 - 1.24 Released! News and Announcements 3
    CyberSimian [fixed] MP1-4990 : Improve horizontal scrolling in the EPG MediaPortal 1 10
    azzuro [WiP] MP1-5019: Replace MySQL with MariaDB MediaPortal 1 40
    catalpa Umsteiger von MP1: Schwierigkeiten Allgemeines Support- und Diskussionsforum 17
    CyberSimian [solved] MP1-4976 Built-in skin variables for current date MediaPortal 1 8
    rbo [solved] Umsteiger MP1 zu MP2 Allgemeines Support- und Diskussionsforum 67
    azzuro [Info] MP2 TVE inside MP1 repo MediaPortal 2 12
    G MP1 TV Server "failed to upgrade the database" using MS Sql Server Installation, configuration support 3
    lisag Can I get MP1 to open in the Recorded TV screen? MediaPortal 1 Talk 2
    M MP1 stops responding after Starting Plugins General Support 14
    R Problem with MP1 and WifiRemote Skins and Plugins Installer (MPEI) 8
    Similar threads

























    Top Bottom