[MP1-4838] Volume control no longer functions properly when changing audio device | Page 7

Discussion in 'General Support' started by Rick164, January 6, 2017.

Tags:
  1. Rick164
    • Super User

    Rick164 Super User

    Joined:
    January 7, 2006
    Messages:
    1,335
    Likes Received:
    918
    Ratings:
    +1,359 / 0
    Home Country:
    Netherlands Netherlands
    Show System Specs
    Hi,

    Can't reproduce on latest commit from here, removed more old locks we had before so should not be able to lock it up :)
    Will see if we can get wave output device working but the libraries so far lack it like NAudio:

    http://stackoverflow.com/questions/20891778/controlling-a-specific-applications-volume-level

    Unless we go Windows Core Audio but that is Windows 7 and up only, CSCore might allow for it just not clear from documentation:

    https://github.com/filoe/cscore

    Bit of a mess in the Windows Audio libraries, some are either dated / requiring lots of code or missing the features we have now :p


     
    Last edited: January 12, 2017
    • Thank You! Thank You! x 2
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. azzuro
    • Team MediaPortal

    azzuro Test Group

    Joined:
    May 10, 2007
    Messages:
    8,523
    Likes Received:
    2,566
    Occupation:
    technician HVAC
    Location:
    France - IDF
    Ratings:
    +4,251 / 13
    Home Country:
    France France
    Show System Specs
    Last commit , it don't lock MP on volume manipulation

    Envoyé de mon D5803 en utilisant Tapatalk
     
    • Like Like x 1
    • Thank You! Thank You! x 1
  4. Rick164
    • Super User

    Rick164 Super User

    Joined:
    January 7, 2006
    Messages:
    1,335
    Likes Received:
    918
    Ratings:
    +1,359 / 0
    Home Country:
    Netherlands Netherlands
    Show System Specs
    Discussed it some more with @Sebastiii and decided to make 2 solutions we can choose from, first being the rework and second being a bug fix only where we keep old code.
    So think we need to throw this in the group and see what everyone would prefer :) , from my point of view would rather not trim down on features so prefer option 2 (bugfix only)

    Branches for them:

    1. Rework where we lose wave output device support and need some workarounds for NAudio (external volume control is not ideal)

    https://github.com/RickDB/MediaPortal-1/commits/MP1-4838-Rework_volume_control_management

    2. Bugfix only + Audio renderer detection improved (no extra deps).

    https://github.com/RickDB/MediaPortal-1/commits/MP1-4838-BugfixOnly

    Bug was basically that we had a device ID history, it will now clear it if device has changed and go thru mixer re-init.
    Attached test version for bugfix only version.
     

    Attached Files:

    Last edited: January 13, 2017
    • Thank You! Thank You! x 4
  5. azzuro
    • Team MediaPortal

    azzuro Test Group

    Joined:
    May 10, 2007
    Messages:
    8,523
    Likes Received:
    2,566
    Occupation:
    technician HVAC
    Location:
    France - IDF
    Ratings:
    +4,251 / 13
    Home Country:
    France France
    Show System Specs
  6. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,297
    Likes Received:
    6,249
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,270 / 9
    Home Country:
    France France
    Show System Specs
    Will test the bugfix today seems safe :) so maybe good for 1.16 :p
     
    • Thank You! Thank You! x 2
  7. Stéphane Lenclud
    • Team MediaPortal

    Stéphane Lenclud Development Group

    Joined:
    April 29, 2013
    Messages:
    2,563
    Likes Received:
    657
    Gender:
    Male
    Ratings:
    +1,270 / 8
    Home Country:
    Germany Germany
    Show System Specs
    I would definitely go for the simpler bug fix at this stage.
    @Rick164 You commits comments should start with the JIRA ID like that: "MP1-4838: My comments".
    Thus JIRA can pick them up.
     
    • Like Like x 1
  8. Rick164
    • Super User

    Rick164 Super User

    Joined:
    January 7, 2006
    Messages:
    1,335
    Likes Received:
    918
    Ratings:
    +1,359 / 0
    Home Country:
    Netherlands Netherlands
    Show System Specs
    Ah didn't know that, new to Jira but will add comments in that style :)
    Can do PR if you guys want or can clone to own MP branch.
     
    Last edited: January 13, 2017
    • Thank You! Thank You! x 1
  9. azzuro
    • Team MediaPortal

    azzuro Test Group

    Joined:
    May 10, 2007
    Messages:
    8,523
    Likes Received:
    2,566
    Occupation:
    technician HVAC
    Location:
    France - IDF
    Ratings:
    +4,251 / 13
    Home Country:
    France France
    Show System Specs
    if it's bugfix, for me yes
    we can keep as branch, with dedicated thread about the Naudio implementation, in case !
    i don't understand the change between using Naudio or continu to use the actual code.
     
    • Like Like x 1
  10. Rick164
    • Super User

    Rick164 Super User

    Joined:
    January 7, 2006
    Messages:
    1,335
    Likes Received:
    918
    Ratings:
    +1,359 / 0
    Home Country:
    Netherlands Netherlands
    Show System Specs
    NAudio was to fix and reduce the code (smaller implementation) at the same time however with just the bugfix works just as good but feels slightly less smooth, tried to break it a few times with external device changes / standby etc.. but can't so far :)
     
    • Thank You! Thank You! x 2
  11. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,297
    Likes Received:
    6,249
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,270 / 9
    Home Country:
    France France
    Show System Specs
    • Thank You! Thank You! x 2
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!