MPTagThat - The Mediaportal Tag Editor (1 Viewer)

Abel56

New Member
February 8, 2018
2
0
62
Home Country
Portugal Portugal
Yes, I mean MPTThat, as you know this app has a built in player, but can't find where to control the volume.

Thnks.
 

hwahrmann

Development Group
  • Team MediaPortal
  • September 15, 2004
    4,633
    2,457
    Vienna, Austria
    Home Country
    Austria Austria
    ah i see.
    There is no volume control in the application itself. you need to use the Windows volume contreol or hardware control on the speaker.
    I am currently rewriting the application and will include a volume control
     

    henso

    Development Group
  • Team MediaPortal
  • February 16, 2012
    2,341
    829
    Home Country
    Denmark Denmark
    @hwahrmann
    I think I found a bug in taglib-sharp. Should this part of the code not be:
    Code:
    if (box_size == 1) {
                    offset += 8;
                    if (data.Count < 8 + offset)
                        throw new CorruptFileException (
                            "Not enough data in box header.");
                   
                    header_size += 8;
                    box_size = data.Mid (offset, 8).ToULong ();
                }
    Also this line is missing the parameters for the string format and should probably be something like:
    Code:
    throw new CorruptFileException (string.Format("Box header specified a size of {0} bytes but only {1} bytes left in the file", box_size, file.Length - position));
     

    henso

    Development Group
  • Team MediaPortal
  • February 16, 2012
    2,341
    829
    Home Country
    Denmark Denmark
    Do you have a sample file to test/debug that?
    I uploaded a sample to our FTP (/Sample-Media-Files/Mp4 Big Atom). With that file the parsing of the 64 bit box size is larger than the file. With the proposed change it works and I verified the 64 bit box size with AtomicParsley.
     
    I

    igoldrate

    Guest
    I guess you are running it with the Admin user.
    Please go into C:\Users\Admin\AppData\Roaming and remove/rename the Config folder.

    try again
     

    hwahrmann

    Development Group
  • Team MediaPortal
  • September 15, 2004
    4,633
    2,457
    Vienna, Austria
    Home Country
    Austria Austria
    not in detail yet. will have some time later today.
     

    hwahrmann

    Development Group
  • Team MediaPortal
  • September 15, 2004
    4,633
    2,457
    Vienna, Austria
    Home Country
    Austria Austria
    @henso: Yes you are right, in case of box_size=1 i need 16 bytes in the box.
    Currently the code only checks for 8 bytes.

    In your test file, this doesn't have any negative consequence.
    I am just wondering, if we ever would face a problem.
    It only might occur if this box is the very last one in the file and there are just 8 bytes in the box, i.e. only the header.

    If there is another box following, we would always have more than 16 bytes, since we always read 32 bytes.
    The calculation of the box would be wrong, since we would include the length field of the following box, but we would never get a CorrupFileException
     

    Users who are viewing this thread

    Top Bottom