Music Player Rework (3 Viewers)

[hwahrmann]

Could be a messy audio driver. i had such an issue on one of my test PCs.
Or it is a resource problem. something running in parallel, taking too much CPU.

How the buffers are filled? Is BASS handling the filling internally or do we need to fill the buffers when BASS resuests? Or even worse are we required to track the buffer and fill them?

BASS is handling the filling internally. No need for us to do anything.

 

[hwahrmann]

@Helios61 first post contains a new build

I was able to crash MP with your files.
I started playback of some file. while still playing i clicked at another song and so on.
After changing 5 or 6 times a song, i had the crash.

Was making now some changes and i can no longer reproduce the crash.
Please give it a try and let me know.

 

[Helios61]

Made some quick tests. All seems to work fine!
Big Thanks!

 

[elliottmc]

Is that the last show-stopper fixed?

 

[hwahrmann]

Yes. Go for it

 

[elliottmc]

Yes. Go for it

In that case, it is developed, tested, documented (???). If the docs are done, you should merge it to master.

 

[Sebastiii]

I have try to reproduce it but can't trigger like this night, i know that it happen by starting MP config from different branch (for sure Thumbnail one without BASS and another one with BASS) to solve the issue, i just do set music extension to default (when i'm on BASS branch) and error is gone.

But if i start no BASS branch play with config and again retry with BASS (error) i think the error comes when i try to play a video.

But right now i can't reproduce it lol

 

[elliottmc]

I have try to reproduce it but can't trigger like this night, i know that it happen by starting MP config from different branch (for sure Thumbnail one without BASS and another one with BASS) to solve the issue, i just do set music extension to default (when i'm on BASS branch) and error is gone.

But if i start no BASS branch play with config and again retry with BASS (error) i think the error comes when i try to play a video.

But right now i can't reproduce it lol

Well, if this was a problem when you used BASS branch + different config, I don't think we should worry about it.

 

[Sebastiii]

It's not really that

Sorry for my english, what i suppose is :

User is on 1.3Final and upgrade to 1.4Final (with BASS), it seems that we need to reset default Music extension otherwise -> we lead to error.
It's the issue i have see by playing with branch based without BASS and branch with BASS.

But maybe it was already fixed (the BASS branch where i do the test latest night was maybe not up to date lol) that why i try to trigger it (if i can)

 

[Sebastiii]

Ah

Now i think i get the error :

[2013-04-12 20:59:58,216] [Log	] [MPMain  ] [ERROR] - Exception: System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
  at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource)
  at MediaPortal.MusicPlayer.BASS.BassAudioEngine.DisposeAndCleanUp()
  at MediaPortal.MusicPlayer.BASS.BassAudioEngine.OnAppFormDisposed(Object sender, EventArgs e)
  at System.ComponentModel.Component.Dispose(Boolean disposing)
  at System.Windows.Forms.Control.Dispose(Boolean disposing)
  at System.Windows.Forms.ContainerControl.Dispose(Boolean disposing)
  at System.Windows.Forms.Form.Dispose(Boolean disposing)
  at MediaPortal.UserInterface.Controls.MPForm.Dispose(Boolean disposing)
  at MediaPortal.D3DApp.Dispose(Boolean disposing)
  at System.ComponentModel.Component.Dispose()
  at System.Windows.Forms.Form.WmClose(Message& m)
  at System.Windows.Forms.Form.WndProc(Message& m)
  at MediaPortalApp.WndProc(Message& msg)  Message: Collection was modified; enumeration operation may not execute.  Site  : Void ThrowInvalidOperationException(System.ExceptionResource)  Source : mscorlib  Stack Trace:	at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource)
  at MediaPortal.MusicPlayer.BASS.BassAudioEngine.DisposeAndCleanUp()
  at MediaPortal.MusicPlayer.BASS.BassAudioEngine.OnAppFormDisposed(Object sender, EventArgs e)
  at System.ComponentModel.Component.Dispose(Boolean disposing)
  at System.Windows.Forms.Control.Dispose(Boolean disposing)
  at System.Windows.Forms.ContainerControl.Dispose(Boolean disposing)
  at System.Windows.Forms.Form.Dispose(Boolean disposing)
  at MediaPortal.UserInterface.Controls.MPForm.Dispose(Boolean disposing)
  at MediaPortal.D3DApp.Dispose(Boolean disposing)
  at System.ComponentModel.Component.Dispose()
  at System.Windows.Forms.Form.WmClose(Message& m)
  at System.Windows.Forms.Form.WndProc(Message& m)
  at MediaPortalApp.WndProc(Message& msg)
[2013-04-12 20:59:58,219] [Error  ] [BASS Stop] [ERROR] - BASS: Error stopping mixer: BASS_ERROR_HANDLE
[2013-04-12 20:59:58,219] [Error  ] [BASS Stop] [ERROR] - BASS: Error freeing mixer: BASS_ERROR_HANDLE