Music Player Rework (2 Viewers)

[elliottmc]

I hope it's that. unfortunately i don't have any plain 1.3 install anymore.
everything is updated with a build containing the BASS rework

Can easily be set to 1 (or whatever it was), see if the problem can be reproduced, then set it to 0 and try again.

 

[jameson_uk]

I hope it's that. unfortunately i don't have any plain 1.3 install anymore.
everything is updated with a build containing the BASS rework

Me neither but we can get this tested
The best way to do this is going to be to rename that property in mediaportal.xml

So perhaps calling this playerType or playbackMode ? (then reference to loading it need updating)

Then for users we could simply add this to UpgradeToLatest within SettingsUpgradeManager.cs inside config project

RemoveEntry(settings, "audioplayer", "player");

Then as long as everything defaults to 0 when loading from mediaportal.xml / settings then all should work seamlessly?

 

[jameson_uk]

Can easily be set to 1 (or whatever it was), see if the problem can be reproduced, then set it to 0 and try again.

Old value was

<entry name="player">BASS engine</entry>

and is no a number. I guess one question might be why have we changed from text to an ID? Is this to match to an enum?
Anyway I think as we are changing the meaning of the data we should rename and deal with as in my previous post

To test we would need to launch config in deploy mode or force and upgrade (bump version numbers or tweak deploytool code)

 

[hwahrmann]

Yes, this is to match an Enum.

And if we remove the value, as you suggested above it will default to "0" and everything is fine.

 

[jameson_uk]

Yes, this is to match an Enum.

And if we remove the value, as you suggested above it will default to "0" and everything is fine.

But if you don't rename it will be fine on upgrade 1 but on upgrade 2 it will delete it again and the user will loose the setting.
If we rename it will only delete the entry if it exists and after that the new value will be used an unaffected by any upgrade

 

[elliottmc]

Yes, this is to match an Enum.

And if we remove the value, as you suggested above it will default to "0" and everything is fine.

But if you don't rename it will be fine on upgrade 1 but on upgrade 2 it will delete it again and the user will loose the setting.
If we rename it will only delete the entry if it exists and after that the new value will be used an unaffected by any upgrade

Can you help?

 

[jameson_uk]

Can you help?

https://github.com/MediaPortal/MediaPortal-1/commit/bbf1c66ec27a477b3b1a285448da027aa0bd7d32
Have not had time to verify this though.
@hwahrmann can you check this? Is this the only property in mediaportal.xml that needs to have the value changed? (presumably the other audioplayer properties are still valid ?)

My clean install has

  <section name="audioplayer">
	<entry name="player">BASS engine</entry>
	<entry name="sounddevice">Default Sound Device</entry>
	<entry name="mixing">no</entry>
	<entry name="crossfade">4000</entry>
	<entry name="buffering">5000</entry>
	<entry name="fadeOnStartStop">yes</entry>
	<entry name="gaplessPlayback">no</entry>
	<entry name="streamOutputLevel">85</entry>
	<entry name="asio">no</entry>
	<entry name="asiodevice">None</entry>
	<entry name="asiobalance">0</entry>
  </section>

Do the ASIO settings need to be cleaned up? Are any of these now redundant?

 

[hwahrmann]

Hi Mike,

the following lines are obsolete

<entry name="mixing">no</entry>
<entry name="asio">no</entry>
<entry name="asiodevice">None</entry>

thx,

Helmut

 

[jameson_uk]

Gone
https://github.com/MediaPortal/MediaPortal-1/commit/bfd84587d5ddacff8f746afd91b89787568a7f8a

 

[elliottmc]

Testing. Before update I have

<section name="audioplayer">
<entry name="player">BASS engine</entry>
<entry name="sounddevice">Default Sound Device</entry>
<entry name="mixing">no</entry>
<entry name="crossfade">4000</entry>
<entry name="buffering">2000</entry>
<entry name="fadeOnStartStop">yes</entry>
<entry name="gaplessPlayback">no</entry>
<entry name="streamOutputLevel">85</entry>
<entry name="asio">no</entry>
<entry name="asiodevice">None</entry>
<entry name="asiobalance">0</entry>
<entry name="sounddeviceid">
</entry>

After update I have no change.

I deliberately didn't run config at the end of installation.

Run MP and start music playing. All works and is clearly using BASS according to logs.

[2013-04-14 19:37:35,901] [Log	] [MPMain   ] [INFO ] - BASS: Initializing BASS audio engine...
[2013-04-14 19:37:35,903] [Log	] [MPMain   ] [INFO ] - BASS: Using default Sound Device
[2013-04-14 19:37:37,063] [Log	] [MPMain   ] [INFO ] - BASS: Device Information
[2013-04-14 19:37:37,063] [Log	] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2013-04-14 19:37:37,064] [Log	] [MPMain   ] [INFO ] - BASS: Name: Speakers=2, MinRate=100, MaxRate=200000, DX=9, EAX=False
[2013-04-14 19:37:37,064] [Log	] [MPMain   ] [INFO ] - BASS: Directsound version: 9
[2013-04-14 19:37:37,064] [Log	] [MPMain   ] [INFO ] - BASS: # Output Channels: 2
[2013-04-14 19:37:37,064] [Log	] [MPMain   ] [DEBUG] - BASS: Minimum Buffer Samples: 39
[2013-04-14 19:37:37,064] [Log	] [MPMain   ] [DEBUG] - BASS: Current Sample rate: 44100
[2013-04-14 19:37:37,064] [Log	] [MPMain   ] [DEBUG] - BASS: Maximum Sample rate: 200000
[2013-04-14 19:37:37,064] [Log	] [MPMain   ] [DEBUG] - BASS: Minimum Sample rate: 100
[2013-04-14 19:37:37,064] [Log	] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2013-04-14 19:37:37,065] [Log	] [MPMain   ] [INFO ] - BASS: Initialization done.
[2013-04-14 19:37:37,065] [Log	] [MPMain   ] [DEBUG] - PlayerFactory: Successfully created player instance for file - E:\iTunes\iTunes Media\Music\Eric Clapton\24 Nights\1-01 Badge.mp3
[2013-04-14 19:37:37,111] [Log	] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2013-04-14 19:37:37,111] [Log	] [MPMain   ] [INFO ] - BASS: Creating BASS audio stream
[2013-04-14 19:37:37,223] [Log	] [MPMain   ] [INFO ] - BASS: Stream Information
[2013-04-14 19:37:37,223] [Log	] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2013-04-14 19:37:37,223] [Log	] [MPMain   ] [INFO ] - BASS: File: E:\iTunes\iTunes Media\Music\Eric Clapton\24 Nights\1-01 Badge.mp3
[2013-04-14 19:37:37,223] [Log	] [MPMain   ] [DEBUG] - BASS: Type of Stream: BASS_CTYPE_STREAM_MP3
[2013-04-14 19:37:37,223] [Log	] [MPMain   ] [INFO ] - BASS: Number of Channels: 2
[2013-04-14 19:37:37,223] [Log	] [MPMain   ] [INFO ] - BASS: Stream Samplerate: 44100
[2013-04-14 19:37:37,223] [Log	] [MPMain   ] [DEBUG] - BASS: Stream Flags: BASS_MUSIC_FLOAT, BASS_STREAM_DECODE, BASS_UNICODE
[2013-04-14 19:37:37,223] [Log	] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2013-04-14 19:37:37,223] [Log	] [MPMain   ] [DEBUG] - BASS: Registering stream playback events
[2013-04-14 19:37:37,229] [Log	] [MPMain   ] [INFO ] - BASS: Successfully created BASS audio stream
[2013-04-14 19:37:37,229] [Log	] [MPMain   ] [INFO ] - BASS: ---------------------------------------------
[2013-04-14 19:37:37,235] [Log	] [MPMain   ] [DEBUG] - BASS: ---------------------------------------------
[2013-04-14 19:37:37,235] [Log	] [MPMain   ] [DEBUG] - BASS: Creating BASS mixer stream
[2013-04-14 19:37:37,235] [Log	] [MPMain   ] [DEBUG] - BASS: Creating 2 channel mixer with sample rate of 44100
[2013-04-14 19:37:37,238] [Log	] [MPMain   ] [DEBUG] - BASS: Successfully created BASS Mixer stream
[2013-04-14 19:37:37,239] [Log	] [MPMain   ] [INFO ] - BASS: playback started

but playerID is not added to MediaPortal.xml

After running config,

<entry name="playerId">0</entry>
</section>

has been added.

So, all seems to be working well.

Are there any other known issues with the BASS rework ?