Music Player Rework (4 Viewers)

[Sebastiii]

Another log

 

[Sebastiii]

And another :

[2013-04-12 21:08:48,242] [Log	] [MPMain  ] [DEBUG] - PlayerFactory: Successfully created player instance for file - Y:\Ian Van Dahl - Lost and Found\01 - Ian Van Dahl - I Can't Let You Go.mp3
[2013-04-12 21:08:48,242] [Error  ] [MPMain  ] [ERROR] - PlayerFactory: Error creating player instance - Requested value 'BASS engine' was not found.
[2013-04-12 21:08:48,244] [Log	] [MPMain  ] [DEBUG] - PlayerFactory: Successfully created player instance for file - Y:\Ian Van Dahl - Lost and Found\01 - Ian Van Dahl - I Can't Let You Go.mp3
[2013-04-12 21:08:48,245] [Error  ] [MPMain  ] [ERROR] - OnMessage exception:System.ArgumentException: Requested value 'BASS engine' was not found.
  at System.Enum.Parse(Type enumType, String value, Boolean ignoreCase)
  at MediaPortal.Player.PlayerFactory.Create(String aFileName, Nullable`1 aMediaType)
  at MediaPortal.Player.PlayerFactory.Create(String fileName, MediaType type)
  at MediaPortal.Plugins.BDHandler.FactoryWrapper.Create(String filename, MediaType type)
  at MediaPortal.Player.g_Player.Play(String strFile, MediaType type, TextReader chapters, Boolean fromPictures, Boolean fromExtTS, Int32 title, Boolean forcePlay)
  at MediaPortal.Player.g_Player.Play(String strFile, MediaType type)
  at MediaPortal.Playlists.PlayListPlayer.FakePlayer.MediaPortal.Playlists.PlayListPlayer.IPlayer.Play(String strFile, MediaType type)
  at MediaPortal.Playlists.PlayListPlayer.Play(Int32 iSong, Boolean setFullScreenVideo)
  at MediaPortal.Playlists.PlayListPlayer.Play(Int32 iSong)
  at MediaPortal.GUI.Music.GUIMusicBaseWindow.AddItemsToCurrentPlaylist(List`1 pItems, Boolean clearPlaylist, Boolean addAllTracks)
  at MediaPortal.GUI.Music.GUIMusicFiles.AddSelectionToCurrentPlaylist(Boolean clearPlaylist, Boolean addAllTracks)
  at MediaPortal.GUI.Music.GUIMusicFiles.OnClick(Int32 iItem)
  at WindowPlugins.WindowPluginBase.OnClicked(Int32 controlId, GUIControl control, ActionType actionType)
  at MediaPortal.GUI.Music.GUIMusicBaseWindow.OnClicked(Int32 controlId, GUIControl control, ActionType actionType)
  at MediaPortal.GUI.Music.GUIMusicFiles.OnClicked(Int32 controlId, GUIControl control, ActionType actionType)
  at MediaPortal.GUI.Library.GUIWindow.OnMessage(GUIMessage message)

So it's seems happening because BASS Engine setting from 1.3 differ from the new one (the setting in mediaportal.xml maybe) and maybe related to default music extension.

So maybe on Music Rework Branch, we should force default new BASS Engine if old is detected ?

 

[Sebastiii]

I can confirm that just open MP Config seems to do the trick

So, after all, maybe all is ok, but user need to open config first (that should happen with deploytool in silence) i assume

 

[hwahrmann]

Yes. Go for it

In that case, it is developed, tested, documented (???). If the docs are done, you should merge it to master.

Docs will be done in the next days.

 

[hwahrmann]

I can confirm that just open MP Config seems to do the trick

So, after all, maybe all is ok, but user need to open config first (that should happen with deploytool in silence) i assume

I never start MP after an upgrade without opening Config first.
It is a complete rework and a lot of new options added.
Starting Config is a must.

 

[elliottmc]

I can confirm that just open MP Config seems to do the trick

So, after all, maybe all is ok, but user need to open config first (that should happen with deploytool in silence) i assume

I never start MP after an upgrade without opening Config first.
It is a complete rework and a lot of new options added.
Starting Config is a must.

So we just need to make sure this is clear in the release notes!

 

[jameson_uk]

I never start MP after an upgrade without opening Config first.
It is a complete rework and a lot of new options added.
Starting Config is a must.

What actually needs setting? We have functionality in config to change mediaportal.xml setting on upgrade (config gets opened silently in the background)

We should make this as easy and transparent as possible to users

 

[hwahrmann]

if i understand the error log correctly, then it is the player setting:

 <section name="audioplayer">
	<entry name="player">0</entry>

if this is set to 0 it should work

 

[jameson_uk]

if i understand the error log correctly, then it is the player setting:

 <section name="audioplayer">
	<entry name="player">0</entry>

if this is set to 0 it should work

If that is the only change that give me 10 mins...

 

[hwahrmann]

I hope it's that. unfortunately i don't have any plain 1.3 install anymore.
everything is updated with a build containing the BASS rework