My Music Videos broken since MediaPortal-svn Rev11662.exe (1 Viewer)

[Al_Capone]

really reconfiguring it from scratch each time would be a lot of work, radio stations, EPG, TV, not to mention network shares... does anybody really do that for each svn ?

 

[ronilse]

Hi,
The answer it's no, but every-time a bug occurs I install a fresh version -> apply SVN & configure everything from bottom to rule out that it's not my installation that causes the bug. I do take a backup of the old folder before uninstalling MP & start from fresh, if the bug isn't caused by my installation then i copy back the old folder to continue.........

Regards
Roy

 

[Spragleknas]

I find it strange that this bug hasn't been fixed yet... normally bugs don't last this long here in MP-land, due to the terrific Team that works here. What makes this bug so difficult? I believe MyVideos is a popular plug in (and is integrated in MP now?).

 

[russtaylor]

Everyone's got too many Christmas parties to attend.

 

[gemx]

Hi,
i found the source of the problem. Although i had quite a hard time to track the problem down i finally found it:
- There is a timing issue in g_player.cs -> static public void Process()
The graph needs some time to init the stream because its from the web, so the "Playing" property is not set to "true". That means, while the graph initially tries to play, the "Process" function thinks that the player is not playing and therefore shuts down vmr9. This is bad because while shutting down, the graphbuilder tries to play the graph. This happens at the same time.
I did a quick hack by just commenting out the part where the "Playing" property is checked.
This worked for me but might cause some bad implications in other aspects.
So if perhaps someone could have a look at this?
I hope i could at least point to the right direction

 

[gemx]

Hi again,
i think i fixed the issue correctly now.
Had to modify IPlayer.cs too.
Now a new state is exposed -> Initializing.
This is set when the video is going to play but not ready.
This should fix it.
Although i found a dependency to GUITrailers:
Both GUITrailers AND GUIMusicVideos must use the same method. Either both VMR9 or no one VMR9.
So i added VMR9 functionality to GUITrailes too
It uses the config for VRM9 from GUIMusicVideos. That's not perfect but i don't have any time left today.
Perhaps someone can complete the work?
The patch so far is attached.
Although it is for rev. 12218 is should be easily applicable to current revisions.

 

[SciDoctor]

You are a God .

A fix for mymusicvideos and VRM9 in mytrailers.

I am humbled.

Now some advice on how to add the attached file. Many Thanks

 

[gemx]

Thanks,
the file does not have to be "added".
You need the sources of current SVN rev..
Check them out with TortoiseSVN.
Then right click on the root folder of the sources and select "TortoiseSVN -> Apply Patch" and select the patch.
Now if you have already installed the SVN, just build the "WindowPlugins" Project and exchange the WindowPlugins.dll.
That's all.
But be warned: it's not completely checked. Although it should work at least in most cases.

By the way:
The bug was caused by the new render thread (not the ui render thread) which was introduced in rev. 11663.

 

[gemx]

For those who want to play, see the attached WindowPlugins.dll.
Just unzip it and replace it with your .dll, check "VMR9" checkbox in MyMusicVideos and try.
This is for rev. 12118 but should also work with current rev.

@the devs:
I would suggest adding a new global option to Configuration:
- use VMR9 for Webstreams
MyVideoTrailers and MyMusicVideos could both use this flag, so there is no problem anymore.
I am preparing this change but it will be friday when i can have another look into this to make things complete, since i am on a business trip tomorrow.

 

[SciDoctor]

Thanks for your work but unfortunatly I still get the same error as before with mymusicvideos and the error occurs (correctly ) now with trailers.

I'll try different svn's to see if there is a connection.