My Music Videos broken since MediaPortal-svn Rev11662.exe (1 Viewer)

[SciDoctor]

Further testing this morning and I think I have found what is causing the problem.

If mymusicvideos is flaged to overlay before the patch is added then MP forces overlay instead of VMR9 and causes a conflict that breaks the VMR9 routine for It and mytrailers.

If mymusicvideos is flaged for VMR9 before the patch is applied then all is OK.

Stilll testing across various platforms .

Many thanks for some excellent coding/bug busting to bring this great addition to MP.

 

[gemx]

thanks, SciDoctor, for testing
1. There was another bug in MyTrailers, so the name of the trailer was not always correctly set -> fixed
2. The bug you mentioned occured because the VMR9 Player has a fallback method if VMR9 can not be initialized. In this case it tries to initialize VMR7 but VMR7 is not installed on the system anymore. This caused an unhandled exception and from this point everything related to vmr gets screwed up.
By the way, this is not the same overlay as when you uncheck the "usevrm9forwebstreams". In this case WMP is used !!!
I just skipped the fallback, so that if vmr9 can't play the stream it shows an error via the notify box.
I experienced this more often than with the old method so if a stream does not play at once it may with a second try.
I am sorry but this seems to be a problem of vmr9.
I reworked the patch and the binaries.
So if you want to test, use the new files in the attachment.

 

[chenks]

is this going to be included in official SVN releases ?

nothing against gemx, but i prefer to only use official released code.

 

[SciDoctor]

I've been running this code all day without problems and as the official code is broken with respect to VMR9 I can recommend it as is.

I hope they move this into SVN and the upcoming stable release as soon as possible.

 

[gemx]

chenks:
No problem. I already uploaded it to the sourceforge page.
Hope the devs will have time to evaluate this soon.

SciDoctor:
Have already tried the new patch?

 

[SciDoctor]

Thanks for the new code.

There still is the same problem that prior to the patch you must ensure that the mymusicvideo plugin has to be set to VMR9 otherwise the same error as previously mentioned occurs.

There must be a seting in an MP xml or the plugin that is forcing the conflict .

Apart from that little setup issue the code works great .

The only other thing I noticed is that when playing files from a playlist the filename isn't corected from the full link name.

 

[gemx]

Damn it!
You are right SciDoctor.
I missed removing the lines to read the config from YahooSettings.cs for MyMusicVideos.
Now all should work as expected.
Playing files from the playlist and showing the "real" songnames is a bit harder but will have a look at it later.
Please report back if the other issues are solved now.
Thank you very much for your patience in testing

 

[SciDoctor]

Nearly there.

I set up mmv plugin to non- vmr9

The patch correctly forced VMR9 when overlay had previously been set in mmv plugin config but only for the very first file played then MP reverted to the errors.

On further checking this bug is only linked to the files being played from a playlist and not individualy.

 

[gemx]

SciDoctor:
Just to be sure.
All is working correctly except playing streams in MyMusicVideos via the playlist?
The playlist is a seperate player class which i didn't care for so far.
This will be next step

 

[SciDoctor]

Correct.

Errors only occur if you don't set the plugin to VMR9 before you copy over the patch files.