New DVB subtitle filter (TsReader based) (1 Viewer)

[THDBASED]

Now it works !!!

Because you had forgotten to enable it as per the post above?

Maybe a good idea to put this info on the front page, that DVB subtitle support is official but needs to be turned on...

 

[SciDoctor]

Using Cyberlink(ATI) filters SVN 16993.


Is there a failsafe if the subtitle cache is overfull, ie restart the subtitle routine if cache > X ,so as to stop this from happening.The result of the following is MP became unresponsive, video/audio carried on and subtitles froze.

2008-01-11 18:44:34.218750 [Debug][18]: OnSubtitle - stream position 377.5723334
2008-01-11 18:44:34.218750 [Debug][18]: SubtitleRenderer: Bitmap: bpp=32 planes 1 dim = 720 x 196 stride : 2880
2008-01-11 18:44:34.218750 [Debug][18]: SubtitleRenderer: to = 6 ts=666940 fsl=380 (startPos = 0)
2008-01-11 18:44:34.234375 [Debug][18]: SubtitleRenderer: Subtitle added, now have 131 subtitles in cache
2008-01-11 18:44:35.640625 [Debug][18]: OnSubtitle - stream position 377.5723334
2008-01-11 18:44:35.640625 [Debug][18]: SubtitleRenderer: Bitmap: bpp=32 planes 1 dim = 720 x 196 stride : 2880
2008-01-11 18:44:35.656250 [Debug][18]: SubtitleRenderer: to = 6 ts=668380 fsl=380 (startPos = 0)
2008-01-11 18:44:35.671875 [Debug][18]: SubtitleRenderer: Subtitle added, now have 132 subtitles in cache
2008-01-11 18:44:40.453125 [Debug][9]: PSClientPlugin: PowerScheduler: User input detected at 11/01/2008 18:44:40
2008-01-11 18:44:40.984375 [Debug][18]: OnSubtitle - stream position 377.5723334
2008-01-11 18:44:40.984375 [Debug][18]: SubtitleRenderer: Bitmap: bpp=32 planes 1 dim = 720 x 196 stride : 2880
2008-01-11 18:44:40.984375 [Debug][18]: SubtitleRenderer: to = 6 ts=673700 fsl=380 (startPos = 0)
2008-01-11 18:44:41.031250 [Debug][18]: SubtitleRenderer: Subtitle added, now have 133 subtitles in cache

 

[SciDoctor]

LOGS didn't upload.

 

[ziphnor]

Is there a failsafe if the subtitle cache is overfull, ie restart the subtitle routine if cache > X ,so as to stop this from happening.The result of the following is MP became unresponsive, video/audio carried on and subtitles froze.

Just added one today (as of 17002) . However i would like to know when and why this happened. I added the limit because in some cases the video stream stops (for example if the CI dies) but subtitles are still delivered, but as the playback doesnt proceed they just pile up. But you say that video/audio continued?

As to the small copy-paste of the log you gave in the post, it looks like the playback position does not move forward (stream position stays the same even though some time passes), and so i wouldnt except the video playback to continue.

Btw, i might be mistaken but the logs you attached afterwards doesnt seem to display this behavior and doesnt seem to belong to the same execution as what you copy-pasted?

 

[mbb]

I follow this thread for a while but I didnt test it until now.
My 1st try is pretty good.

There is just a small french accent problem.

I put the file "french_accent.rar" on ftp.team-mediaportal.com with a short .ts file and the mediaportal.log

wrong sign: corresponding french letter:
# é
` è
\ ê
@ à

Hope it help you to make this wonderfull feature perfect

Thanks

mbb

 

[ziphnor]

There is just a small french accent problem.

I put the file "french_accent.rar" on ftp.team-mediaportal.com with a short .ts file and the mediaportal.log

Good to get a french tester as well (and excellent that you upload a sample). The french character table is regrettably not complete right now (that part of the code is taken from another open source teletext implementation), with your input it should be somewhat easier to complete it. (this is different from the situation with the danish character, as there simply do not exist a danish character table, only a swedish one).

Several other character tables are also incomplete for example the german one.

Im going on vacation tomorrow for two weeks though, so dont except to see any updates before then

 

[risu]

Just added one today (as of 17002) . However i would like to know when and why this happened. I added the limit because in some cases the video stream stops (for example if the CI dies) but subtitles are still delivered, but as the playback doesnt proceed they just pile up. But you say that video/audio continued?

I've seen this few times, I'll try to upload some sample for you later today, I haven't yet updated your fix so I'll also test if it works on that recording I have.

Btw. I previously reported txt subtitle timing was now correct, I only tested it from viasat recordings. On finnish channels we have bitmaps but txt subs also, I normally use only bitmap subs but I found that txtsubs have still some timing trouble. You can see this yourself when I get that file uploaded.

 

[SciDoctor]

Thanks for the update.

Odd the logs don't match, must be because I had already restarted MP and the usefull logs were now '.bak.

I will keep testing. Thanks again.

The video and audio was still being produced with one static line of subs and MP unresponsive.

 

[ziphnor]

I've seen this few times, I'll try to upload some sample for you later today, I haven't yet updated your fix so I'll also test if it works on that recording I have.
.

Excellent, but no rush, as i said ill be on vacation (and have no computer access) until the 27th.

Regardless of whether the fix works i need to understand why this happens, the subtitles should *only* pile up if for some reason the playback position does not move forward ( so that it never becomes time to show them), and if that happens then it might be a bug elsewhere in MP (or just a bug elsewhere in my code

Btw. I previously reported txt subtitle timing was now correct, I only tested it from viasat recordings. On finnish channels we have bitmaps but txt subs also, I normally use only bitmap subs but I found that txtsubs have still some timing trouble. You can see this yourself when I get that file uploaded.

Yes i believe there are some teletext subtitles transmitted that dont quite live up to the standard. Teletext subtitles are only supposed to be kept 40ms after being received whether or not they have a presentation time stamp. I have on some channels seen teletext where this doesn't seem to be the case but this is always pages for which no service info exists and bitmap subtitles are available instead, so i am not sure whether or not these subs are actually meant to be used or not or is just some leftover from somewhere. This is not something i plan to do anything about.

 

[risu]

I've seen this few times, I'll try to upload some sample for you later today, I haven't yet updated your fix so I'll also test if it works on that recording I have.
.

Excellent, but no rush, as i said ill be on vacation (and have no computer access) until the 27th.

Regardless of whether the fix works i need to understand why this happens, the subtitles should *only* pile up if for some reason the playback position does not move forward ( so that it never becomes time to show them), and if that happens then it might be a bug elsewhere in MP (or just a bug elsewhere in my code .

File in under dvb subtitles named bitmapsubs_frozen.ts. It's a short clip, just let know if bigger clip is needed. I'm not quite sure if it's the same problem after all but what happens there is that bitmap subs get frozen and doesn't change until two minutes has passed (I already uploaded the splitted file before I figured subs will eventually come back with this newer SVN, but on original file it takes about 2 mins for subs to show again correctly). If I seek over the place where subs get frozen, it works just fine and new subs get displayed. Maybe tourettes can take a look here?

Btw. I previously reported txt subtitle timing was now correct, I only tested it from viasat recordings. On finnish channels we have bitmaps but txt subs also, I normally use only bitmap subs but I found that txtsubs have still some timing trouble. You can see this yourself when I get that file uploaded.

Yes i believe there are some teletext subtitles transmitted that dont quite live up to the standard. Teletext subtitles are only supposed to be kept 40ms after being received whether or not they have a presentation time stamp. I have on some channels seen teletext where this doesn't seem to be the case but this is always pages for which no service info exists and bitmap subtitles are available instead, so i am not sure whether or not these subs are actually meant to be used or not or is just some leftover from somewhere. This is not something i plan to do anything about.[/QUOTE]
I just checked the clip with VLC and yes, teletext subs are not on sync there either if bitmapsubs are present, so no worries