[fixed] Pictures : 1st transition sometimes buggy (1 Viewer)

Smeulf

Retired Team Member
  • Premium Supporter
  • October 27, 2010
    672
    454
    France
    Home Country
    France France
    Hi,

    Very nice transitions between pictures.

    But I notice sometime the 1st transition does not complete and is replace by another one (or by the same with does complete at the second time).

    Joined logs, I saw the last transition buging.

    Smeulf.

    [Edit] From rev. 3537 : Start playing an image can cause the client to crash in my system. Will try tomorow on an another one.
     

    Albert

    MP2 Developer
  • Premium Supporter
  • February 18, 2008
    1,297
    1,130
    45
    Freiburg im Breisgau, Germany
    Home Country
    Germany Germany
    AW: Pictures : 1st transition sometimes buggy

    I had a short talk with Baboonanza; he says the bug could already have been gone by a bugfix he did.
    I didn't notify that bug so could you please check it again, Smeulf? Thx.
     

    Smeulf

    Retired Team Member
  • Premium Supporter
  • October 27, 2010
    672
    454
    France
    Home Country
    France France
    Hi,

    Hard to say, as the pictureplayer crash many times. Errors fond in debug mode, no logs generated, so hard here to tell more :

    TextureAssetCore.cs, line 286 : AccessViolationExeption Not Managed

    I hope the joined files can help.
     

    Attachments

    • error1.jpg
      error1.jpg
      173.2 KB
    • exeption_details.txt
      3 KB

    tourettes

    Retired Team Member
  • Premium Supporter
  • January 7, 2005
    17,301
    4,800
    Hi,

    Hard to say, as the pictureplayer crash many times. Errors fond in debug mode, no logs generated, so hard here to tell more :

    TextureAssetCore.cs, line 286 : AccessViolationExeption Not Managed

    I hope the joined files can help.

    I managed to reproduce that issue once - but not anymore (and there was no code changes at all between the tries).
     

    Smeulf

    Retired Team Member
  • Premium Supporter
  • October 27, 2010
    672
    454
    France
    Home Country
    France France
    This does not appears all the time, but very often in my case.

    Most of the time, it appears at the 2nd of 3rd try.

    Sometime, I can play the picture 10 times right, and the 11 one, on the same picture, the error appears.

    Sometime it appears at the 1st try. Pretty strange.

    My graphics drivers are up to date, and my DirectX is the last one...
     

    Baboonanza

    Retired Team Member
  • Premium Supporter
  • February 5, 2010
    143
    57
    North London
    Home Country
    United Kingdom United Kingdom
    This does not appears all the time, but very often in my case.

    Most of the time, it appears at the 2nd of 3rd try.

    Sometime, I can play the picture 10 times right, and the 11 one, on the same picture, the error appears.

    Sometime it appears at the 1st try. Pretty strange.

    My graphics drivers are up to date, and my DirectX is the last one...
    I still can't reproduce the problem even with DirectX full debug validation enabled. My best guess is that the DataStream is corrupt for some reason, perhaps related to me changing file access to asyncronous mode. I have attached a patch that should make the texture loading code more fault tolerant, could you please test it and see if improves the situation?

    I would really like to know what the cause of the problem is though, and why you get it more than us. Are these pictures located on a network drive?

    Albert said:
    I had a short talk with Baboonanza; he says the bug could already have been gone by a bugfix he did.
    I didn't notify that bug so could you please check it again, Smeulf? Thx.
    It appear there has been a miscommunication. In my testing branch I fixed the problem in a way that broke something else. Albert said he had fixed the problem in a better way but it appear that his fix does not work (I think my explanation of the problem was inadequate).

    The problem is actually an artifact of the asyncronous messaging queues used to show screens, but there is also a deeper problem that some screen transitions seem to trigger screen reloads when they (ideally) shouldn't. You can see this when closing the context menu in the picture player and I think it is also the cause of the dropped video frames that tourrettes mentions in another post. We will work on it.
     

    morpheus_xx

    Retired Team Member
  • Team MediaPortal
  • March 24, 2007
    12,073
    7,459
    Home Country
    Germany Germany
    AW: Pictures : 1st transition sometimes buggy

    Do I interpret the patch correctly, that you allow 3 retries for the action?
     

    Baboonanza

    Retired Team Member
  • Premium Supporter
  • February 5, 2010
    143
    57
    North London
    Home Country
    United Kingdom United Kingdom
    Re: AW: Pictures : 1st transition sometimes buggy

    Yes. Although come to think of it I'll remove the 3 re-tries for syncronous texture loads since that could give a noticable delay. For asyncronous loads it should be fine.

    Whether or not it works is another question.
     

    Users who are viewing this thread

    Top Bottom