Scythe42's fixes for 1.4.0 (3 Viewers)

[Pythagoras]

Hi,

yesterday I upgraded from 1.3.0final to the patch bundles provided on 19th April. In the evening after resuming I tried to view a recorded TV show (ZDF Heute) and got an error about AVC Codec displayed. Tried again, same error. Exit Media Portal Client, Started Media Portal Client and tried to view again => No problem.

Please find attached the logs, the problem should be somewhere 20:49 in MediaPortal.log.1.

Template for report Bug :
- System Specs used : HTPC
- How many displays : 1
- What resolution does each display use : 1920x1080
- More than one GPU used : No
- How are displays connected : Onboard Graka ==HDMI==> Onkyo AVR ==HDMI==> TV
- How are they positioned :
- Which one is the primary one : TV
- On which do you start MP : TV
- Where is the taskkbar positioned of Windows : at the bottom
- Screenshot of the whole windows desktop when it is wrong. Not just MP, that does not elp me.: Sorry didnt take it.
- Skin Used : Titan

 

[GeoffC]

With the patched version found a problem when MP is started using the green button on an MCE remote. MP starts ok but the task bar remains at the bottom of the screen and the remote does not work (maybe doesnt have focus). No selection on the remote will work, only solution is to shutdown MP using a mouse and then restart using the mouse, then MCE remote works normally

Template for report Bug :
- System Specs used : HTPC
- How many displays : 1
- What resolution does each display use : 1920x1080
- More than one GPU used : No
- How are displays connected : PC==>HDMI==> TV
- How are they positioned :
- Which one is the primary one : TV
- On which do you start MP : TV
- Where is the taskkbar positioned of Windows : at the bottom
- Screenshot of the whole windows desktop when it is wrong. Not just MP, that does not elp me.: Sorry didnt take it.
- Skin Used : Titan

 

[Owlsroost]

You might not have noticed, but a 16:9 skin looks a bit different on 16:10 when running in full screen. As the aspect ratio does not really match it will always. That's why you probably did not notice it.

I had noticed it.

You will have the same with 4:3. You will have black bars on the left and right.

Agreed, and expected (I much prefer this to having the window resize itself to the video size, which I find *really* annoying in other players)

Will not fix for 1.4.0.

Completely OK with that - it just becomes a known issue for 1.4.0

I'll add a note to Mantis 3991 to explain the symptoms/effects of the problem (for the benefit of users who don't know much about how MP works inside).

Tony

 

[Scythe42]

yesterday I upgraded from 1.3.0final to the patch bundles provided on 19th April. In the evening after resuming I tried to view a recorded TV show (ZDF Heute) and got an error about AVC Codec displayed. Tried again, same error. Exit Media Portal Client, Started Media Portal Client and tried to view again => No problem.

From the logs:

[2013-04-21 20:48:10,785] [Log	] [MPMain  ] [INFO ] - TsReaderPlayer: OnVideoFormatChanged - streamtype=H264 resolution=1280x720 aspect ratio=16:9 bitrate=15000000 isInterlaced=False
[2013-04-21 20:48:10,790] [Log	] [MPMain  ] [INFO ] - TSReaderPlayer: Add codecs
[2013-04-21 20:48:10,943] [Log	] [MPMain  ] [INFO ] - VMR9: added EVR Renderer to graph
[2013-04-21 20:48:10,943] [Log	] [MPMain  ] [DEBUG] - VMR9: Now active
[2013-04-21 20:48:10,943] [Log	] [MPMain  ] [DEBUG] - VMR9: Renderer successfully added
[2013-04-21 20:48:10,944] [Log	] [MPMain  ] [INFO ] - Added filter: LAV Video Decoder to graph
[2013-04-21 20:48:10,944] [Log	] [MPMain  ] [DEBUG] - TSReaderPlayer: UpdateFilters Video done
[2013-04-21 20:48:10,948] [Log	] [MPMain  ] [INFO ] - Added filter: LAV Audio Decoder to graph
[2013-04-21 20:48:10,948] [Log	] [MPMain  ] [DEBUG] - TSReaderPlayer: UpdateFilters Audio done
[2013-04-21 20:48:10,948] [Log	] [MPMain  ] [DEBUG] - TSReaderPlayer: PostProcessingEngine to DummyEngine
[2013-04-21 20:48:10,948] [Log	] [MPMain  ] [INFO ] - TSReaderPlayer: Render TsReader outputs
[2013-04-21 20:48:10,948] [Log	] [MPMain  ] [DEBUG] - Filter: TsReader - try to connect: Audio
[2013-04-21 20:48:10,987] [Log	] [MPMain  ] [DEBUG] - Main: WM_DEVICECHANGE (Event: 32772)
[2013-04-21 20:48:10,987] [Log	] [MPMain  ] [DEBUG] - Filter: TsReader - try to connect: Video
[2013-04-21 20:48:10,990] [Log	] [MPMain  ] [DEBUG] - PlaneScene: PresentImage() dispose surfaces
[2013-04-21 20:48:10,994] [Log	] [MPMain  ] [DEBUG] - Main: WM_DEVICECHANGE (Event: 32768)
[2013-04-21 20:48:10,994] [Log	] [MPMain  ] [DEBUG] - Main: WM_DEVICECHANGE (Event: 7)
[2013-04-21 20:48:10,995] [Log	] [MPMain  ] [DEBUG] - Main: WM_DEVICECHANGE (Event: 32772)
[2013-04-21 20:48:10,995] [Log	] [MPMain  ] [DEBUG] - Filter: TsReader - try to connect: Subtitle
[2013-04-21 20:48:10,995] [Log	] [MPMain  ] [DEBUG] - Main: WM_DEVICECHANGE (Event: 32772)
[2013-04-21 20:48:10,995] [Log	] [MPMain  ] [DEBUG] - Main: WM_DEVICECHANGE (Event: 32768)
[2013-04-21 20:48:10,996] [Log	] [MPMain  ] [DEBUG] - Main: WM_DEVICECHANGE (Event: 32772)
[2013-04-21 20:48:10,998] [Log	] [MPMain  ] [DEBUG] -  - failed
[2013-04-21 20:48:10,998] [Log	] [MPMain  ] [DEBUG] - TSReaderPlayer: CleanupCC filter (Tv/Recorded Stream Detected)
[2013-04-21 20:48:10,998] [Log	] [MPMain  ] [DEBUG] - Check graph connections for: Enhanced Video Renderer
[2013-04-21 20:48:10,998] [Log	] [MPMain  ] [DEBUG] - Check graph connections for: Default DirectSound Device
[2013-04-21 20:48:10,998] [Log	] [MPMain  ] [DEBUG] - Check graph connections for: LAV Video Decoder
[2013-04-21 20:48:10,998] [Log	] [MPMain  ] [DEBUG] - Check graph connections for: LAV Audio Decoder
[2013-04-21 20:48:10,998] [Log	] [MPMain  ] [DEBUG] - Check graph connections for: TsReader
[2013-04-21 20:48:10,999] [Log	] [MPMain  ] [DEBUG] - TSReaderPlayer: Last subtitle index: 0
[2013-04-21 20:48:11,018] [Log	] [MPMain  ] [INFO ] - TSReaderPlayer: OnInitialized
[2013-04-21 20:48:11,018] [Log	] [MPMain  ] [INFO ] - TSReaderPlayer: position:0, duration:0,592
[2013-04-21 20:48:11,031] [Log	] [MPMain  ] [DEBUG] - TvPlugin:ViewChannelandCheckV2 Exception System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
  bei MediaPortal.Player.g_Player.Play(String strFile, MediaType type, TextReader chapters, Boolean fromPictures)
  bei MediaPortal.Player.g_Player.Play(String strFile, MediaType type)
  bei TvPlugin.TVHome.StartPlay()
  bei TvPlugin.TVHome.ViewChannelAndCheck(Channel channel)
[2013-04-21 20:48:11,148] [Log	] [MPMain  ] [INFO ] - tv home init:Das Erste HD done

As you can see TVPlugin runs into an unhandled exception and calls the start of playback even it it cannot playback stuff.

What error are you seeing on screen from the codec? This is not logged inside MP.

I also still see DEVICECHANGE messages from Windows. Maybe it has not fully woken up yet when you started playback?

Does it happen when you use a different codec that LAV?

All in all, not related to my changes.

 

[Scythe42]

With the patched version found a problem when MP is started using the green button on an MCE remote. MP starts ok but the task bar remains at the bottom of the screen and the remote does not work (maybe doesnt have focus).

Focus problem. Did you see some icon of MP or so flashing in the taskbar? Icon in the taskbar should have a different color compared to when just indicating that the app is active. That can be configured in Windows.

See: http://superuser.com/questions/316879/how-can-i-disable-flashing-icons-on-windows-7-taskbar

Can you try to disable task bar flashes for me, please? And let me know if this helps.

Task Bar Flashes are allows to steal focus because this should only be done when something important is happening. They can happen now and when MP starts up, especially because MPTray has a Tray icon and therefore a Windows Form.

This means focus change takes place. Green Button activates MP tray, MP trays starts MP, MP steals focus from MPTray.

Will try to work around it or to minimize it possibility of this happening.

 

[Scythe42]

I'll add a note to Mantis 3991 to explain the symptoms/effects of the problem (for the benefit of users who don't know much about how MP works inside).
Tony

Thank you. I experimented with using additional swap chains. But has not yet worked out properly because of too many stuff that is directly tied in to the device creation. But does not mean that I do not find a trick here.

 

[GeoffC]

Did you see some icon of MP or so flashing in the taskbar? Icon in the taskbar should have a different color compared to when just indicating that the app is active. That can be configured in Windows

Yes the MP icon is flashing
Will now try and disable flashing, when flashing disabled works great
Thanks

 

[Wo0zy]

With the patched version found a problem when MP is started using the green button on an MCE remote. MP starts ok but the task bar remains at the bottom of the screen and the remote does not work (maybe doesnt have focus).

Focus problem. Did you see some icon of MP or so flashing in the taskbar? Icon in the taskbar should have a different color compared to when just indicating that the app is active. That can be configured in Windows.

See: http://superuser.com/questions/316879/how-can-i-disable-flashing-icons-on-windows-7-taskbar

Can you try to disable task bar flashes for me, please? And let me know if this helps.

Task Bar Flashes are allows to steal focus because this should only be done when something important is happening. They can happen now and when MP starts up, especially because MPTray has a Tray icon and therefore a Windows Form.

This means focus change takes place. Green Button activates MP tray, MP trays starts MP, MP steals focus from MPTray.

Will try to work around it or to minimize it possibility of this happening.

Awesome!

I've had this problem forever. Can't wait to try this at home.

Thanks Scythe

 

[Scythe42]

@Docs Team: can someone add the task bar flashes to the Wiki? See the above links on how to control the task bar flashes.

In a HTPC setup, where MP is not the shell, this should be disable depending on MP is started. Does not necessarily apply to MPTray only and might not happen on all installations. Other stuff on a machine might do also stuff that cause Windows to flash the task bar and therefore stealing focus. It is meant to be a focus stealer.

MP cannot be allowed to play with general Windows settings. And adding options for tweaking Windows should not be done. We can add at least a dozen of them and that would confuse users and create a code maintenance nightmare.

 

[Scythe42]

I'll add a note to Mantis 3991 to explain the symptoms/effects of the problem (for the benefit of users who don't know much about how MP works inside).
Tony

Thank you. I experimented with using additional swap chains. But has not yet worked out properly because of too many stuff that is directly tied in to the device creation. But does not mean that I do not find a trick here.

I added a compromise: If on a toggle windowed/fullscreen mode the backbuffer size does not equal the skin size, the D3D device is reset.

When does it happen:

• Using a 16:9 skin on a 16:10 display
• Using a 720p skin on a 1080p display (I know, same aspect ratio, but I do not want too much complexity here)
• Using a 4:3 skin on a 16:9 display (that will result in letterboxed plackback of 16:9 movies anyway)
• MP started in Windowed mode and you switch the first time to a full screen mode (backbuffer was initially limited to maximum aspect ratio safe size of the skin)
• ... and so on

We go through a full device reset, unloading and reloading every resource here. No need to check if we are using EVR or not. That is the quickest solution I can offer without spending hours and hours on something that's is not needed for a very long time.

The Skin defines the aspect ratio MP is using for windowed mode. In other words in windowed mode the aspect ratio set by the skin can be obeys, whereas in full screen mode it cannot.

That should hold until the player side has its own D3D device. Needs it anyway when we are moving to D3D11 as EVR needs a D3D9Ex device anyway. Also at this time the refresh rate changer is managed from the presenter side.