Subtitle issue (1 Viewer)

[Rick164]

For now you can try DirectVobSub with Mediaportal, know this is a workaround which does limit DXVA however you will get correct subtitles.
Just tried Mad Max Fury Road (BR-disk / PGS streams) and that worked with Mediaportal in combination with DirectVobSub(xy-VSfilter).

 

[Helios61]

know this is a workaround which does limit DXVA

Unfortunately without DXVA i get heavy stuttering on my Beebox .
Is this a Mediaportal bug or a LAV bug?

 

[Rick164]

Will do some more testing this weekend with GraphStudio to pinpoint it, not sure which version of MPC engine Mediaportal uses and if that could be updated but will check that as well.

 

[Rick164]

@Sebastiii Loaded the Directshow filters project in located here:

https://github.com/MediaPortal/MediaPortal-1/tree/master/DirectShowFilters/Filters.sln

and followed the instructions here:

https://github.com/MediaPortal/MediaPortal-1/blob/master/DirectShowFilters/VS Environment Setup.txt

However Visual Studio 2013 will report a lot of errors (2000+) like these:

Error    2637    error C4430: missing type specifier - int assumed. Note: C++ does not support default-int (source\VideoPin.cpp)    C:\Program Files (x86)\Microsoft SDKs\Windows\v7.1A\include\UIAnimation.h    2428    1    BDReader

    4236    IntelliSense: identifier "GC_PAN_WITH_SINGLE_FINGER_VERTICALLY" is undefined    c:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\atlmfc\include\afxwin.h    2051    61    TsReader

So for some reason it reports that includes provided by Visual Studio and Windows SDK itself are invalid for this project, do I need to install additional libraries or different versions to get that project compiled properly?

 

[Sebastiii]

It's not easy to build lol.
I have followed the wiki for it
http://wiki.team-mediaportal.com/1_...t_Changes/Visual_Studio_2013?highlight=vs2013 (for VS2013)
But maybe need this is it didn't work :
http://wiki.team-mediaportal.com/1_.../Building_MediaPortal_from_source/1_Git_Setup

 

[Rick164]

Works, thanks

Had to change WINDOWS_SDK system variable to C:\Program Files (x86)\Windows Kits\8.1 and also use vsyasm 1.2 like described there.

// Update

Just merged mpcSubs successfully with the latest MPC-HC master branch so off to test it out
Hoping the issue isn't somewhere in the mpcSub handler code which hooks into various places of the MPC subtitle engine as my C++ isn't that great.

 

[Rick164]

Needed to rewrite a lot more than expected to make it conform to the newer MPC code, seems they changed just about everything
However after doing some comparing and changes there are now only a few minor things left on the list and 12 or so errors, gonna work on that this weekend and after that testing it again.
Can follow the progress in this forked branch:

https://github.com/RickDB/MediaPortal-1/commits/EXP-MPC-HC-Engine_Update

// Update

Seems some of the original C++ code which hooks into mc-hc isn't compatible anymore and not sure how to solve that, in the submanager code it now expects a different input format (rectangle instead of &size)

https://github.com/RickDB/MediaPort...c-hc_subs/src/mpc-hc_subs/SubManager.cpp#L292

 

[Sebastiii]

Thanks m8

I have try to port the code recently and run to headache, so like it was working, i didn't continue but in fact we have an issue
Do you have a sample for testing your change ?
I will create one this week-end

The original author @cpp2005 (https://forum.team-mediaportal.com/members/cpp2005.26608/) but long time he didn't comes here.
Maybe @Owlsroost can help on this

I can try too, i will go to switch to your branch

 

[Sebastiii]

It seems to break also StreamingServer, for you too ?

 

[Rick164]

Do you have a sample for testing your change ?

Will create a sample clip and PM it to you

It seems to break also StreamingServer, for you too ?

Yeah, not sure why that one is affected but did compile fine before the MPC changes so must have something to do with it.

Been a while since I worked this much with C++ so bit rusty and never was that good at that to begin with , did manage to port all the required parts albeit a bit broken at the moment however even when making a few things static (settings / temporary CRECT) it will fail on LNK libraries with no option to see where it's coming from from within VS.